From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:43825) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7b4x-00011E-57 for guix-patches@gnu.org; Fri, 28 Feb 2020 03:33:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7b4v-0002j4-RE for guix-patches@gnu.org; Fri, 28 Feb 2020 03:33:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54656) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7b4v-0002iz-O2 for guix-patches@gnu.org; Fri, 28 Feb 2020 03:33:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j7b4v-0006Jf-Jw for guix-patches@gnu.org; Fri, 28 Feb 2020 03:33:01 -0500 Subject: [bug#39804] [PATCH] gnu: add emacs-exwm-next package (i.e. exwm for emacs-next) Resent-Message-ID: From: Pierre Neidhardt In-Reply-To: <87tv3bd6v1.fsf@web.de> References: <87blplqcdd.fsf@web.de> <8736aw8igd.fsf@ambrevar.xyz> <87tv3bd6v1.fsf@web.de> Date: Fri, 28 Feb 2020 09:32:27 +0100 Message-ID: <878skn5cys.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: dario Cc: 39804@debbugs.gnu.org, Maxim Cournoyer , Leo Prikler --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Dario, dario writes: > Thanks for your feedback. > >>> --- >>> gnu/packages/emacs-xyz.scm | 71 ++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 71 insertions(+) >>> >>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm >>> index 6b9027df8a..c6df469895 100644 >>> --- a/gnu/packages/emacs-xyz.scm >>> +++ b/gnu/packages/emacs-xyz.scm >>> @@ -8601,6 +8601,77 @@ It should enable you to implement low-level X11 = applications.") >>> built on top of XELB.") >>> (license license:gpl3+))) >>> >>> +(define-public emacs-exwm-next >> >> I think you don't need to copy the whole package definition. Instead, >> you could `inherit' from the original definition and only adjust the >> name, description, inputs and maybe arguments. >> >> For instance >> >> --8<---------------cut here---------------start------------->8--- >> (define-public emacs-exwm-next >> (package >> (inherit emacs) >> (name "emacs-exwm-next") >> (inputs ...) >> (synopsys ...))) >> --8<---------------cut here---------------end--------------->8--- >> >> See `substitute-keyword-arguments' in the fftwf package for a convenient >> way to modify just one argument. >> >>> + (package >>> + (name "emacs-exwm-next") >>> + (version "0.23") >>> + (synopsis "Emacs X window manager") > > Nice - I was not aware of that. The following definition seems to work > (see also the patch at the end of this mail) >> --8<---------------cut here---------------start------------->8--- > (define-public emacs-exwm-next > (package > (inherit emacs-exwm) > (name "emacs-exwm-next") > (synopsis "Emacs X window manager using the next version of emacs") > (inputs > (cons > `("emacs-next" ,emacs-next) > (delete `("emacs" ,emacs) > (package-inputs emacs-exwm)))))) Maybe a bit better: (inputs `(("emacs" ,emacs-next) ,@(alist-delete "emacs" (package-inputs emacs-exwm)))))) >> --8<---------------cut here---------------end------------->8--- > >>> + (arguments >>> + `(#:emacs ,emacs >> >> Shouldn't this be `emacs-next` as well? > I have to admit that I do not understand that part. If I change it to > emacs-next, the build fails with the error >> --8<---------------cut here---------------start------------->8--- > phase `install' succeeded after 0.0 seconds > starting phase `make-autoloads' > Wrong type argument: stringp, nil > command "/gnu/store/1z520fgx6fiq426yf2174kal2q63a9q7-emacs-next-27.0.50-0= .36abf68/bin/emacs" "--quick" "--batch" "--eval=3D(let ((backup-inhibited t= ) (generated-autoload-file \"/gnu/store/nnjcqc448yj79dxaj11fnq7s9a8zpc1z-em= acs-exwm-next-test-0.23/share/emacs/site-lisp/exwm-next-test-autoloads.el\"= )) (update-directory-autoloads \"/gnu/store/nnjcqc448yj79dxaj11fnq7s9a8zpc1= z-emacs-exwm-next-test-0.23/share/emacs/site-lisp\"))" failed with status 2= 55 >> --8<---------------cut here---------------end------------->8--- > It is a bit difficult for me to understand what is going on here, > because, like I said, I do not really understand this part of the > package definition in the first place - sorry. However, without > modifying the arguments, everything seems to work. The `#:emacs` field tells the build system which Emacs package to use to build this package. There may be something that not compatible between our current build system and emacs-next. I've CC'ed Maxim and Leo, they might know more than me. > The following patch seems to work (do I need to send it on its own? I am > new to this type of workflow.) Attaching to this email is fine. Better is to use `git send-email` like so: =2D-8<---------------cut here---------------start------------->8--- git send-email --to=3D39804@debbugs.gnu.org --in-reply-to=3D 00= 01-your.patch =2D-8<---------------cut here---------------end--------------->8--- with being the message ID of the email you are replying to. You can get this message ID in various ways: one way that always works is to look up the "message-id" header of the raw email. Also when you generate the patch with git, set the subject prefix to [PATCH v2] for the second iteration, PATCH v3 for the third, etc. Thanks! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl5Y0BsACgkQm9z0l6S7 zH95mggAocyhL3wVt7SWN4QJupqaEXIwjSPuM0rzMPU9rLeDd9MKfZJEHgXIubDC +G3nK2Hy5nUmlQ8tFvzt6GsAOAcMYGcy+Mfv2FglfAPI3+uxy39C7F+i403q3C3P SrRXJV0tnMzk/3suiQQXjQScqcPwL+Q0LMd7Kq9mXNaS7Sk5D79oYCap70nyW8wE 5ne6f9Ee3+NDyfUYhu/jsPbOlMKwDLxAW16smi2m0yd6FJ7dM3ckg8x1ua7sv6jL 9jtXbtxw3+0K7bAcbPCZVfyQQjzwOfRmWywBJukKLvEL21R8PDnZZjA/v+PLtZFr txzcS1bOQKsXdS6SKd9XGeHrOA7DOg== =h9ax -----END PGP SIGNATURE----- --=-=-=--