From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:59579)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jL9uF-0005Bc-PF
 for guix-patches@gnu.org; Sun, 05 Apr 2020 14:22:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jL9uE-0001Xz-TP
 for guix-patches@gnu.org; Sun, 05 Apr 2020 14:22:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:35026)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jL9uE-0001Xu-QT
 for guix-patches@gnu.org; Sun, 05 Apr 2020 14:22:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jL9uE-00065T-MV
 for guix-patches@gnu.org; Sun, 05 Apr 2020 14:22:02 -0400
Subject: bug#40445: gnu: gsm: Update to 1.0.19.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.40445.D40445.158611087723251.done@debbugs.gnu.org>
From: maxim.cournoyer@gmail.com
References: <87d08ms22w.fsf@gmail.com>
 <9fde0f2d6cf97a9368ae132a717cf18a@disroot.org>
 <06e6a1cfe8a54f80493a4e9f2820399b@disroot.org>
 <87blo53k9r.fsf@hurd.i-did-not-set--mail-host-address--so-tickle-me>
Date: Sun, 05 Apr 2020 14:20:56 -0400
In-Reply-To: <87blo53k9r.fsf@hurd.i-did-not-set--mail-host-address--so-tickle-me>
 (maxim cournoyer's message of "Sun, 05 Apr 2020 13:38:40 -0400")
Message-ID: <878sj93ibb.fsf@hurd.i-did-not-set--mail-host-address--so-tickle-me>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: maxim.cournoyer@gmail.com
Cc: Raghav Gururajan <raghavgururajan@disroot.org>, Mathieu Othacehe <m.othacehe@gmail.com>, 40445-done@debbugs.gnu.org

Hi all,

maxim.cournoyer@gmail.com writes:

> Hello,
>
> "Raghav Gururajan" <raghavgururajan@disroot.org> writes:
>
>> Hi Mathieu!
>>
>>>> + #:make-flags
>>>> + (list
>>>> + ;; Added -fPIC with other default options.
>>>> + "CCFLAGS=-fPIC -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment")
>>> 
>>> I wonder if we need all those options, the package seems to build fine
>>> without them. Could you have a look?
>>
>> Yes, Maxim and I, updated these options, to use libgsm in mediastreamer, as a part of linphone packaging. :-)
>>
>> Btw, currently the gsm package is in unusable state, after the commit "74c7f367daa554cedeb5f02a00d1cd02acf1584b".
>>
>> Regards,
>> RG.
>
> Ooops.  Sorry about that.  I meant:
>
> -       #:make-flags '("INSTALL_ROOT=%output"
> -                      "CCFLAGS=-fPIC \
> +       #:make-flags (list (string-append "INSTALL_ROOT=" %output)
> +                          "CCFLAGS=-fPIC \
>
> But I'll take into accounts comments from Mathieu, which make sense.
>
> Maxim

I've fixed the breakage I caused with commit
5b05f8e9654ea722270c45c0fd0eead369bc0daf, and committed the update to
gsm 1.0.19 from Raghav on top as
5e16e4401f854d39f5fbebaf247750e554bd4a09.

Closing.

Thanks for the ideas!

Maxim