From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:37589) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOQuh-0007X4-0p for guix-patches@gnu.org; Tue, 14 Apr 2020 15:08:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOQug-0006Nf-42 for guix-patches@gnu.org; Tue, 14 Apr 2020 15:08:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOQug-0006NU-0h for guix-patches@gnu.org; Tue, 14 Apr 2020 15:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jOQuf-0002tX-TG for guix-patches@gnu.org; Tue, 14 Apr 2020 15:08:01 -0400 Subject: [bug#40537] [PATCH] gnu: Add bchoppr. Resent-Message-ID: References: From: Christopher Baines In-reply-to: Date: Tue, 14 Apr 2020 20:06:54 +0100 Message-ID: <878six7upd.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alexandros Theodotou Cc: 40537@debbugs.gnu.org --=-=-= Content-Type: text/plain Alexandros Theodotou writes: > These patches add 3 new LV2 plugins by the same author as bsequencer: > bchoppr > bshapr > bjumblr I've got a couple of comments. It looks to me like it would be clearer to not have the packages inherit from bsequencer. Some copying in the package definitions is fine if there are similarities between packages. The second thing is that I'd try to avoid adding package definitions at the end of files, just because it can lead to more merge conflicts. Would you be able to send some updated patches? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6WCc5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xc5TBAAtAoQlq740ohHRz/dvpVAbq4HlLzcR1/kLgjOHQE3w54ka/2ZHOVwAl0O wBtGggOgvzFwV2Pd6T9OyMDSCtVaQVoB7VjNRxvuqXH/FWIjcK1JfpnU1i7Akyuc 7gAUAv8wukfVb2iXjAUbQMTivEUQWunDUMsN6Pz7QyAd9YZYCxjzVh3N+EgOhrwQ iwNhz+ZANfY+hAcT3TQNSGsj96mnrpquC4Dx94few4ZwwmB5rImmy25sKtY3gXOy q4RssTFPLxw+3M18PmJR++uGK8Khk/H2XZjDIVoy+R5dtpt7yqh7dIULPU921BQF TmSPLSBzjROKEkU9L9QEE2hs0NZNC6WQrSsrZMtjiBbbqg1kisBotbzxvntwrFsP EHChJaEjULPfw+eM2LUVgf8j2gj+oci5QJx0DLY3IMHlwNQwZ6sith2PG2Zh7Jj3 Zh6+1GjiBE7tBGUgbwJ31/saO/fDdEsF72GmZhRdg+tSDiksC65473JWB4fY0gBF M98u1lR2kjQNZygwr6rWAOozwmSOzQHDsMDdi38StdBh0YDr7RfE9WhrcOlIejOl 6TEf1UOezK87stS5zUGBwwxQgMkkXGrWPEUghY6zClBm5daAQdsUqJdO0cz/oW1n 46+Dbh+1sMqv6W3yssuokqxJ/xWz+V0B/gmpjvQ7K8DNTkIPoTc= =Yuxs -----END PGP SIGNATURE----- --=-=-=--