From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6OJ3IWt2217VdwAA0tVLHw (envelope-from ) for ; Sat, 06 Jun 2020 10:56:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sEdeHWt2214sCQAA1q6Kng (envelope-from ) for ; Sat, 06 Jun 2020 10:56:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BE0B89404E2 for ; Sat, 6 Jun 2020 10:56:42 +0000 (UTC) Received: from localhost ([::1]:42634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhWVE-0002eq-A5 for larch@yhetil.org; Sat, 06 Jun 2020 06:56:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhWUc-0002Of-7r for guix-patches@gnu.org; Sat, 06 Jun 2020 06:56:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39309) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhWUb-0001gS-QD for guix-patches@gnu.org; Sat, 06 Jun 2020 06:56:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhWUb-0006Cb-Od for guix-patches@gnu.org; Sat, 06 Jun 2020 06:56:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41541] [PATCH 3/8] system: Add 'multiboot-modules' field to . Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 Jun 2020 10:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41541 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Mathieu Othacehe Cc: 41541@debbugs.gnu.org, "Jan \(janneke\) Nieuwenhuizen" Received: via spool by 41541-submit@debbugs.gnu.org id=B41541.159144095323824 (code B ref 41541); Sat, 06 Jun 2020 10:56:01 +0000 Received: (at 41541) by debbugs.gnu.org; 6 Jun 2020 10:55:53 +0000 Received: from localhost ([127.0.0.1]:50855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhWUT-0006CB-5V for submit@debbugs.gnu.org; Sat, 06 Jun 2020 06:55:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhWUC-0006Bh-Jp for 41541@debbugs.gnu.org; Sat, 06 Jun 2020 06:55:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58986) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhWU7-0001Yw-AM; Sat, 06 Jun 2020 06:55:31 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=51550 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jhWU6-0002Ax-0R; Sat, 06 Jun 2020 06:55:30 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200604135914.4499-1-janneke@gnu.org> <20200604135914.4499-4-janneke@gnu.org> <87eeqsmyxy.fsf@gnu.org> Date: Sat, 06 Jun 2020 12:55:28 +0200 In-Reply-To: <87eeqsmyxy.fsf@gnu.org> (Mathieu Othacehe's message of "Sat, 06 Jun 2020 09:32:41 +0200") Message-ID: <878sh0wjj3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: JA7I71QZ6GNR Hi, Mathieu Othacehe skribis: >> + (mach (if (%current-target-system) >> + ;; A cross-built GNUmach does not work >> + (with-parameters ((%current-system "i686-linux") >> + (%current-target-system #f)) >> + mach) > > Maybe it would make more sense to check if we are on a Hurd system, > rather than just checking for %current-target-system to be set, don't > know. If this hack is still needed, can we move it away to hurd-os.tmpl, or to the =E2=80=98gnumach=E2=80=99 package itself or something? I think it=E2=80=99s best to keep (gnu system) free of any such assumptions. >> + (libc (if target >> + (with-parameters ((%current-target-system #f)) >> + (cross-libc target)) >> + glibc)) > > In the future, it would be nice to make this think transparent. Anyway, > for now this is the best we can do I think. Yeah, perhaps add a FIXME. >> "--x-xattr-translator-records" Do we need this yet? If it can wait for later, that=E2=80=99s even nicer I= MO as it would allow us to separate concerns. Ludo=E2=80=99.