From: Mark H Weaver <mhw@netris.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org, Amin Bandali <bandali@gnu.org>
Subject: Re: [bug#42738] [PATCH v4] gnu: emacs: Update to 27.1.
Date: Sat, 29 Aug 2020 17:53:06 -0400 [thread overview]
Message-ID: <878sdxm84i.fsf@netris.org> (raw)
In-Reply-To: <87sgc5lpzc.fsf@gnu.org>
Hi Ludovic,
Ludovic Courtès <ludo@gnu.org> wrote:
> Mark H Weaver <mhw@netris.org> skribis:
>
>> (define-public emacs-next
>> (let ((commit "c36c5a3dedbb2e0349be1b6c3b7567ea7b594f1c")
>> (revision "0")
>> (emacs-version "27.0.91"))
>> (package
>> (inherit emacs)
>> (name "emacs-next")
>> (version (git-version emacs-version revision commit))
>> (source
>> (origin
>> (inherit (package-source emacs))
>> (method git-fetch)
>> (uri (git-reference
>> (url "https://git.savannah.gnu.org/git/emacs.git")
>> (commit commit)))
>
> This can be handled with ‘--with-git-url’.
I think that wouldn't work in this case, because we also need to
preserve the existing 'patches' and 'snippet' fields, which I arranged
to inherit above via (inherit (package-source emacs)). That probably
deserves a comment, since it's easily overlooked.
>> (sha256
>> (base32 "0mlrg2npy1r79laahkgzhxd1qassfcdz8qk1cpw7mqgf6y5x505h"))
>> (file-name (git-file-name name version))))
>> (native-inputs
>> `(("autoconf" ,autoconf) ; needed when building from trunk
>> ,@(package-native-inputs emacs)))
>
> For this, we’d need a new ‘--with-extra-input’ package transformation
> option or similar. That way, we wouldn’t even need an ‘emacs-next’
> package: people would just run
>
> guix install emacs --with-git-url=… --with-extra-input=autoconf
There's also the 'native-search-paths' field, which cannot simply be
inherited because of the version number embedded within EMACSLOADPATH.
This particular issue could be avoided if the 'native-search-paths'
field were a function of the version number, but that raises migration
issues and I'm not sure it's worth it.
What do you think?
Best regards,
Mark
next prev parent reply other threads:[~2020-08-29 21:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 3:21 [bug#42738] [Work in progress] gnu: emacs: update to 27.1 Jack Hill
2020-08-07 3:23 ` [bug#42738] [PATCH] gnu: emacs: Update to 27.1-rc1 Jack Hill
2020-08-18 6:23 ` [bug#42738] [Work in progress] gnu: emacs: update to 27.1 Jack Hill
2020-08-18 6:26 ` [bug#42738] [PATCH v2] gnu: emacs: Update " Jack Hill
2020-08-18 8:57 ` Alexey Abramov
2020-08-18 13:04 ` [bug#42738] [Work in progress] gnu: emacs: update " Michael Rohleder
2020-08-19 4:08 ` Jack Hill
2020-08-19 4:09 ` [bug#42738] [PATCH v3] gnu: emacs: Update " Jack Hill
2020-08-27 21:59 ` [bug#42738] [PATCH v4] " Morgan.J.Smith
2020-08-28 5:35 ` Jack Hill
2020-08-28 14:18 ` Ludovic Courtès
2020-08-28 14:38 ` Pierre Neidhardt
2020-08-28 17:00 ` [bug#42738] " Brett Gilio
2020-08-28 17:08 ` Jack Hill
2020-08-28 17:34 ` Amin Bandali
2020-08-28 20:04 ` Mark H Weaver
2020-08-29 10:13 ` Ludovic Courtès
2020-08-29 21:53 ` Mark H Weaver [this message]
2020-09-07 9:00 ` Ludovic Courtès
2020-08-28 18:57 ` Mark H Weaver
2020-08-28 21:10 ` Morgan Smith
2020-08-28 21:10 ` [bug#42738] " Morgan Smith
2020-08-29 20:35 ` Mark H Weaver
2020-08-30 1:50 ` [bug#42738] " Brett Gilio
2020-08-29 17:19 ` Giovanni Biscuolo
2020-09-04 9:03 ` Pierre Neidhardt
2020-09-04 9:16 ` [bug#42738] " Pierre Neidhardt
2020-09-04 10:20 ` Giovanni Biscuolo
2020-09-07 9:44 ` Pierre Neidhardt
2020-08-19 8:22 ` [bug#42738] [Work in progress] gnu: emacs: update " Diego Nicola Barbato
2020-08-19 13:53 ` Michael Rohleder
2020-08-19 2:53 ` [bug#42738] [PATCH v2] gnu: emacs: Update to 27.1. (fwd) Jack Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sdxm84i.fsf@netris.org \
--to=mhw@netris.org \
--cc=bandali@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.