From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6H22AVu7wl/EDAAA0tVLHw (envelope-from ) for ; Sat, 28 Nov 2020 21:04:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QEMbOVq7wl+idgAA1q6Kng (envelope-from ) for ; Sat, 28 Nov 2020 21:04:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6C68B940483 for ; Sat, 28 Nov 2020 21:04:26 +0000 (UTC) Received: from localhost ([::1]:59300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kj7OL-0005Gj-9T for larch@yhetil.org; Sat, 28 Nov 2020 16:04:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kj7Ny-0005GY-ET for guix-patches@gnu.org; Sat, 28 Nov 2020 16:04:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37672) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kj7Ny-0000uT-6h for guix-patches@gnu.org; Sat, 28 Nov 2020 16:04:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kj7Ny-0003p7-0r for guix-patches@gnu.org; Sat, 28 Nov 2020 16:04:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44926] [WIP] Add dart-2.8.4 Resent-From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 28 Nov 2020 21:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44926 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Julien Lepiller Cc: 44926@debbugs.gnu.org Received: via spool by 44926-submit@debbugs.gnu.org id=B44926.160659738714633 (code B ref 44926); Sat, 28 Nov 2020 21:04:01 +0000 Received: (at 44926) by debbugs.gnu.org; 28 Nov 2020 21:03:07 +0000 Received: from localhost ([127.0.0.1]:49218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj7N5-0003nx-0K for submit@debbugs.gnu.org; Sat, 28 Nov 2020 16:03:07 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:35639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj7N2-0003nS-Ml for 44926@debbugs.gnu.org; Sat, 28 Nov 2020 16:03:05 -0500 Received: by mail-wr1-f52.google.com with SMTP id r3so9573834wrt.2 for <44926@debbugs.gnu.org>; Sat, 28 Nov 2020 13:03:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=6jwarxDnBvi5aKNRLRa1Smb8yGlX4mUw0dwsZ6O6BE8=; b=p3V3i9wOJ1g7eZr35TVDptZHnMdafG501KGew2biJG8gR4iRcC1b30B7QBCWh9WDHS Zh4u6dVo3b78o/+D+SrtPn7UqPfQskt8Zs79/mBN2Mf/jclK/RPlt5Nkpqq1BcKkVhRr vo69UONPlzToWle1Z+sEyqgc6Rtk+tLbAGJlb3DPjUO1TSFeEZNqX+aWAtYnO7f6PuqA dconza6ckwvdVvDqe+P1T7gr9bPG2z7D17h59bGsEY7PNUPTOMkzR+ch5aJUBTbsxY/g e8QnRdaDAM2/cEUgtMwSi/ePMFdmeXdKp1ZKRFKEoAz25EUGCaFqa6yDBahdmUHoP5z7 Izhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=6jwarxDnBvi5aKNRLRa1Smb8yGlX4mUw0dwsZ6O6BE8=; b=Hu43eedD2FORufnlUH4FkK2qIdnd9tSwlkWemi5lqNmwrEZKQx4cY0Lj2T1YNsa0lK p5U1BtnONV6wAFNOUXwvhG1R337bKG39ESE95YeJU95Jr8UYy6Tdw1mE+OuRRQB+cjdm qtbU2vvptJtJzplpqsdnA3aWz0Xs7LjVAIyzmhA2wvvN0z1W0Bv1mr27HLiJKCvN5Lrr 0Ug6N3V2ZOBz2rJsFN5fgUdLPLwoHmyshXcus9PZ9VDuU39lwOKFLx9vsjBdxxR6mSU1 VB6U04Nd/Mge4pyqgJteCj0cZHFAT4Z/BLKLJUUOInoQbLpVtpT/TnEqHTJQrlBxo1D8 CQwg== X-Gm-Message-State: AOAM532Pgdwlmyo85sT4XdhCFmS5POmtCTrUZrj9m9Ga6r3mwGcXDYZ0 UBt/8D7KEC7pgFv5odX14mZCSpll01E= X-Google-Smtp-Source: ABdhPJwj93FsRwvMIWPLeh7U8ZFCU5JVJDotqsK+sLaF6yGcT2bDSp2gucj6hXTg/n5XuNAQaQ8YqA== X-Received: by 2002:adf:8b4a:: with SMTP id v10mr19582690wra.212.1606597378552; Sat, 28 Nov 2020 13:02:58 -0800 (PST) Received: from guixSD (host-79-54-131-134.retail.telecomitalia.it. [79.54.131.134]) by smtp.gmail.com with ESMTPSA id u203sm18128380wme.32.2020.11.28.13.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Nov 2020 13:02:57 -0800 (PST) From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti In-Reply-To: <20201128215020.39ddb709@tachikoma.lepiller.eu> References: <87lfelqrni.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <20201128215020.39ddb709@tachikoma.lepiller.eu> Date: Sat, 28 Nov 2020 22:02:56 +0100 Message-ID: <878salw5xb.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.17 X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=p3V3i9wO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-TUID: XaQBqS4+hfij Julien Lepiller writes: > Le Sat, 28 Nov 2020 19:10:09 +0100, > Nicol=C3=B2 Balzarotti a =C3=A9crit : > >> Hi Guix! >> As announced on guix-devel, I bootstrapped the dart compiler from >> source. >>=20 >> Following patches add dart 2.8.4 (latest release is 2.10, but I wanted >> to be sure that this work in progress is fine before continuing, as I >> fear that 4 other steps are required). >>=20 >> NOTE: I tagged this as WIP as I've not yet disabled analytics yet (I >> disabled it from the first added version, but I was wondering if I >> need to disable it in _each_ version or if just the latest one is >> fine. Patching all of them will require some time). >>=20 >> (Each build takes ~20min on my server and ~60min on my laptop, and >> there's a dozen of them) >>=20 >> Let me know if there are major problems or if I can go on with >> disabling analytics! >>=20 >> Thanks, Nicol=C3=B2 >>=20 > > Impressive :) > > I can see a few issues in terms of style in these patches, but looking > at the first dart version, it looks like it's going to work :) > > So, instead of using dart-zlib, dart-boringssl, ..., I'd recommend > changing dart-pkg to something like this: > > (define* (dart-pkg name tag hash #:optional > (url (string-append > "https://github.com/dart-lang/" > (string-replace-substring name "-" "_") > ".git"))) > (origin > (method git-fetch) > (uri (git-reference > (url url) > (commit tag))) > ...)) > Sure, I'll do this > That way, dart-zlib, ... also have a proper file name ;) > > I don't really like the fact that the build system simply bundles these > dependencies instead of link dynamically to them, but I guess it's hard > to do anything for that, and for bootstrap versions, I don't think it's > too much of an issue. Yeah I too don't like it, but I really never used (and don't like) the gn build system, so any change requires a lot of time. I know that we usually unbundle things, and if required I might try again. > > You should also make sure to clean up your patches: for instance patch > 8 modifies things you've added before (I think it's only because of > whitespace, but that's not clean). Ops, sorry! > > Thank you! Thank you Julien! I'll submit a v2 tomorrow.