all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#44663] [PATCH] ui: Launch $PAGER through the shell.
@ 2020-11-15 18:47 Tobias Geerinckx-Rice via Guix-patches via
  2020-11-15 19:46 ` Tobias Geerinckx-Rice via Guix-patches via
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Tobias Geerinckx-Rice via Guix-patches via @ 2020-11-15 18:47 UTC (permalink / raw)
  To: 44663

This is the convention elsewhere and sounds like the right thing to do.

* guix/ui.scm (call-with-paginated-output-port): Substitute OPEN-PIPE
for OPEN-PIPE*.

Reported by Daniel Brooks <db48x@db48x.net>.
---
 guix/ui.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/guix/ui.scm b/guix/ui.scm
index 4e686297e8..2b7d9dd64b 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -72,7 +72,7 @@
   #:use-module (ice-9 match)
   #:use-module (ice-9 format)
   #:use-module (ice-9 regex)
-  #:autoload   (ice-9 popen) (open-pipe* close-pipe)
+  #:autoload   (ice-9 popen) (open-pipe close-pipe)
   #:autoload   (system base compile) (compile-file)
   #:autoload   (system repl repl)  (start-repl)
   #:autoload   (system repl debug) (make-debug stack->vector)
@@ -1673,9 +1673,9 @@ zero means that PACKAGE does not match any of REGEXPS."
       ;; instead of 'r': this strips hyperlinks but allows 'less' to make a
       ;; good estimate of the line length.
       (let ((pager (with-environment-variables `(("LESS" ,less-options))
-                     (open-pipe* OPEN_WRITE
-                                 (or (getenv "GUIX_PAGER") (getenv "PAGER")
-                                     "less")))))
+                     (open-pipe (or (getenv "GUIX_PAGER") (getenv "PAGER")
+                                    "less")
+                                OPEN_WRITE))))
         (dynamic-wind
           (const #t)
           (lambda () (proc pager))
-- 
2.29.2





^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-08-03 20:04 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-15 18:47 [bug#44663] [PATCH] ui: Launch $PAGER through the shell Tobias Geerinckx-Rice via Guix-patches via
2020-11-15 19:46 ` Tobias Geerinckx-Rice via Guix-patches via
2020-11-15 20:46 ` Ludovic Courtès
2020-11-15 21:38   ` Daniel Brooks
2020-11-16  8:16     ` Ludovic Courtès
2020-11-29 16:43 ` [bug#44663] [PATCH v2] ui: Handle multiword and empty $PAGER values Tobias Geerinckx-Rice via Guix-patches via
2020-11-29 16:56   ` Tobias Geerinckx-Rice via Guix-patches via
2021-08-03 20:02   ` bug#44663: [PATCH] ui: Launch $PAGER through the shell Maxim Cournoyer
2020-11-29 16:52 ` [bug#44663] " Tobias Geerinckx-Rice via Guix-patches via

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.