From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4N/kHq4R+V8lHwAA0tVLHw (envelope-from ) for ; Sat, 09 Jan 2021 02:15:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id APayGq4R+V/eLQAA1q6Kng (envelope-from ) for ; Sat, 09 Jan 2021 02:15:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E1B1B9403C9 for ; Sat, 9 Jan 2021 02:15:09 +0000 (UTC) Received: from localhost ([::1]:41114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ky3mW-0007mz-QK for larch@yhetil.org; Fri, 08 Jan 2021 21:15:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ky3mQ-0007md-4Z for guix-patches@gnu.org; Fri, 08 Jan 2021 21:15:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ky3mP-0005DV-Rx for guix-patches@gnu.org; Fri, 08 Jan 2021 21:15:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ky3mP-0003GQ-NG for guix-patches@gnu.org; Fri, 08 Jan 2021 21:15:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45190] [PATCH 1/1] gnu: Add pinentry-rofi. Resent-From: Fredrik Salomonsson Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 09 Jan 2021 02:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45190 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 45190-submit@debbugs.gnu.org id=B45190.161015845312461 (code B ref 45190); Sat, 09 Jan 2021 02:15:01 +0000 Received: (at 45190) by debbugs.gnu.org; 9 Jan 2021 02:14:13 +0000 Received: from localhost ([127.0.0.1]:51037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ky3ld-0003Eu-1v for submit@debbugs.gnu.org; Fri, 08 Jan 2021 21:14:13 -0500 Received: from mout01.posteo.de ([185.67.36.65]:41179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ky3la-0003Eg-LE for 45190@debbugs.gnu.org; Fri, 08 Jan 2021 21:14:11 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 73B7E16005C for <45190@debbugs.gnu.org>; Sat, 9 Jan 2021 03:14:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1610158444; bh=/QcF6HBLJA6gLiHGLL9s/DEIPvId9eKKv3HXj1OGq78=; h=From:To:Cc:Subject:Date:From; b=Y9LjF697VY0xKZ3OBHQKTpzuNYY73LWEmSn3/ruvpjPLQk3JSV4feZuUKoqlq6i7S 1WnjE/qI1qw1WuqERIuoatCgT9xvA00gAV7ytg5/EFcWgERH0OlHT0iAdqTgpG9d2w Lj+yKYrQgM0DzavKzq2YM1qju+qPAsceL4ngn+D+Yn6NhbOpSZGsSxu+RXi1ixMBVx CQ0R0ZyTJowYy/zUvNoxdXO6+wiBlr64dy82+5F8E/BePPzJsYkWzJHFLHwh5D6hvS 8BkgHPSTLaMzIBOVtPcrNGvd6qfVsmpdnB5GvUrhwKqKWMKvxoKxYshLp3OMfgmgwd 9lE8TLDbyIbOQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DCNnR3Qwxz9rxM; Sat, 9 Jan 2021 03:14:03 +0100 (CET) From: Fredrik Salomonsson In-Reply-To: <87o8i5zpme.fsf@gnu.org> References: <20201212021954.78983-1-plattfot@posteo.net> <20201212023103.79992-1-plattfot@posteo.net> <87o8i5zpme.fsf@gnu.org> Date: Fri, 08 Jan 2021 18:14:01 -0800 Message-ID: <878s926emu.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45190@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.25 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=posteo.net header.s=2017 header.b=Y9LjF697; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E1B1B9403C9 X-Spam-Score: -1.25 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3H/ajdXe0NJ/ Hi Ludovic, Ludovic Court=C3=A8s writes: >> +(define-public pinentry-rofi >> + (package >> + (name "pinentry-rofi") > > Indentation is off here (should be offset by two). Fixed in v2. >> + (arguments >> + `(#:strip-binaries? #f ;; Has no binaries and the strip phase is fa= iling > > Hmm the =E2=80=98strip=E2=80=99 phase should not fail. Are you sure this= is necessary? It was failing with a warning as there are no binaries to strip. But it's not an error so I removed this in v2. >> + #:phases >> + (modify-phases >> + %standard-phases >> + (add-after >> + 'install >> + 'hall-wrap-binaries > > Nitpick: please indent as in other files. Fixed in v2. > Since I think you=E2=80=99re also upstream :-), how about adding somethin= g like > that at the top of the installed executable: > > (eval-when (load expand eval) > (set! %load-path (cons "@moddir@" %load-path)) > (set! %laod-compiled-path (cons "@godir@" %load-compiled-path))) > > ? Yup, I'm upstream as well. I don't mind adding that, just need to know what it solves :). I'm guessing that it removes the need to wrap the executable, is that correct? And are the "@moddir@" and "@godir@" expected to be expanded by automake? I tested to just add it in the source code and automake did nothing with them. For now I left it out in v2 as I'm a bit unsure of it. >> + (propagated-inputs `(("rofi" ,rofi))) > It=E2=80=99s best to avoid propagating. Perhaps you can replace the =E2= =80=9Crofi=E2=80=9D > string in =E2=80=98pinentry-rofi=E2=80=99 by =E2=80=9C/gnu/store/=E2=80= =A6/bin/rofi=E2=80=9D in a post-install > phase? Is there a rule of thumb or something to know when to use propagating inputs? I'm a bit confused when to use is it. Is it just when dealing with libraries? What are the downsides of using propagating inputs? Apologize if this is already mentioned in the manual. Only sections I could find that mentions propagated inputs are section 5.2 and 8.2.1. Anyway this is fixed in v2, I added the rofi's binary path to PATH for the wrapper of pinentry-rofi.=20 >> + (synopsis "Rofi GUI for GnuPG's passphrase input") >> + (description "Simple pinentry GUI using rofi that allows users to ent= er a >> +passphrase when required by @code{gpg} or other software.") > > Please make it a full sentence. Also, to give context, perhaps replace > =E2=80=9Crofi=E2=80=9D by =E2=80=9Cthe Rofi application launcher=E2=80=9D. I fleshed out the description in v2, let me know if it sounds better. > Could you send an updated patch? All updates should be in PATCH v2 > Thanks in advance and sorry for the delay! Thank you for reviewing my patch and no worries about the delay. --=20 s/Fred[re]+i[ck]+/Fredrik/g