From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id usBfNmBBFGGHqwAAgWs5BA (envelope-from ) for ; Wed, 11 Aug 2021 23:30:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kAVhMWBBFGG+IAAA1q6Kng (envelope-from ) for ; Wed, 11 Aug 2021 21:30:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 50FA224C10 for ; Wed, 11 Aug 2021 23:30:08 +0200 (CEST) Received: from localhost ([::1]:51474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDvnb-0002Kv-6a for larch@yhetil.org; Wed, 11 Aug 2021 17:30:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDvnW-0002KX-Gj for guix-patches@gnu.org; Wed, 11 Aug 2021 17:30:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mDvnW-0005EX-A8 for guix-patches@gnu.org; Wed, 11 Aug 2021 17:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mDvnW-00084D-0Y for guix-patches@gnu.org; Wed, 11 Aug 2021 17:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49880] [PATCH 1/2] gnu: gmp-boot: Fix build on powerpc64le-linux Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 11 Aug 2021 21:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49880 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Thiago Jung Bauermann Cc: 49880@debbugs.gnu.org Received: via spool by 49880-submit@debbugs.gnu.org id=B49880.162871737630942 (code B ref 49880); Wed, 11 Aug 2021 21:30:01 +0000 Received: (at 49880) by debbugs.gnu.org; 11 Aug 2021 21:29:36 +0000 Received: from localhost ([127.0.0.1]:36794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDvn6-00082y-Ck for submit@debbugs.gnu.org; Wed, 11 Aug 2021 17:29:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDvn4-00082k-Gq for 49880@debbugs.gnu.org; Wed, 11 Aug 2021 17:29:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46878) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDvmy-0004pK-Q4; Wed, 11 Aug 2021 17:29:28 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48774 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDvmy-0006OF-H2; Wed, 11 Aug 2021 17:29:28 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210804183454.153783-1-bauermann@kolabnow.com> Date: Wed, 11 Aug 2021 23:29:26 +0200 In-Reply-To: <20210804183454.153783-1-bauermann@kolabnow.com> (Thiago Jung Bauermann's message of "Wed, 4 Aug 2021 15:34:54 -0300") Message-ID: <878s17k6vd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628717408; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=4fTqfmPVGSyFnC8k1JytV91prmgX42TB59biKb1RHGU=; b=ftO+/ftGocZjjkP+R8h353YxUgEPLKgCtCknDGVCHOQXCH8Q21EH4iDO7gBtyQWpH9yGGa kbgSjmVg5GoquW7rwkdP16ge5N8tkqjyzxzrQMJe3eKKKJGfLcsk59qIn1JEeaGC6QQVAp Adxi2ewSgyBUzdsswKdkI/OYKh6iHIGlz4V4gdIdRQzT2N5/puNXbFxhZPLZoDoT/T7R7l LrH0duXnFAIL+4gdVOfSw6LiK+9EeEVgRIRLUgKQK4lLsBXsdwBdqAYPU4xJH3l04lfI2q KmARyzhHwARsq6OgxHjaYCZYVTUrR2czSQFPU7cIVyFyzPcwYzfWlRRRL9G9Rg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628717408; a=rsa-sha256; cv=none; b=RTs6F92qeFOXX5qQStPZpK4sW3//jqNFkeDVUZYKwYBQL6YQyVaBBPKOCEjkZ9Ct4N4UGb 2iRcDnMtEknMnaeYbT0/YocRA2F3nVWXdTVAjR7EbL47xKv/zGF+TPZUNCegNflb2qC+s2 b0thyXDFGg0VrId2atumRiPG121gyYdfxL84uQbOkuvHzJSxzGaXLyeJz0YpInc7ktRk2R yUVQbPDRXZFbIl9CjJCfR8Ltr6ijdFr9myur70MrIoEt4gO7zsFGUApxL58cgMRK6egX5v ReG2zjiRUlg/fNKfC5seInE+pMjUXOROaQtrwUFLIxUl2N4ygLtPIvOKmYODaw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 50FA224C10 X-Spam-Score: -2.91 X-Migadu-Scanner: scn1.migadu.com X-TUID: mUIE/vCEWZG3 Hi! Thiago Jung Bauermann skribis: > Linux on powerpc64 used to run in big-endian mode only. When support for > little-endian mode was added around 2014, they took the opportunity to > update the ELF ABI. The new ABI is known as ELF ABI v2, and the old one > retroactively called ELF ABI v1. > > GMP 4.3.2 was released in 2010, so its hand-optimized assembly code for > powerpc64 only support ELF ABI v1. This causes a build failure on > powerpc64le-linux, which can be fixed by passing a host triplet with the > =E2=80=9Cnone=E2=80=9D CPU type. This tells the configure script to use = generic C code for > the build. > > * gnu/packages/commencement.scm (gmp-boot)[arguments]{#:configure-flags}:= Add > =E2=80=9C--host=3Dnone-unknown-linux-gnu=E2=80=9D for powerpc64le targets. [...] > + (substitute-keyword-arguments (package-arguments gmp) > + ((#:configure-flags gmp-configure-flags) > + `(cons* ,@(if (string-prefix? "powerpc64le-" (or (%current-targe= t-system) > + (%current-syste= m))) > + ;; The powerpc64 assembly code in this version of = GMP > + ;; only supports the ELF ABI v1 but powerpc64le us= es ELF > + ;; ABI v2, so use the generic C code instead. Thi= s is > + ;; done by specifying the CPU type as =E2=80=9Cnon= e=E2=80=9D. > + ;; > + ;; According to the manual, =E2=80=9Cthis will run= quite slowly, > + ;; but it should be portable and should at least m= ake it > + ;; possible to get something running if all else f= ails.=E2=80=9D > + '("--host=3Dnone-unknown-linux-gnu") > + '()) > + ,gmp-configure-flags)))))) The patch LGTM. However, could you tweak it so we can apply it on =E2=80=98core-updates-frozen=E2=80=99 while not triggering a rebuild on oth= er arches? Something like: (if (string-prefix? =E2=80=A6) `(cons =E2=80=A6 ,gmp-configure-flags) gmp-configure-flags) TIA! Ludo=E2=80=99.