From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id o/m9Di7aUGFQCwEAgWs5BA (envelope-from ) for ; Sun, 26 Sep 2021 22:38:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uKDkAy7aUGGvJgAAB5/wlQ (envelope-from ) for ; Sun, 26 Sep 2021 20:38:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B9A6C3004D for ; Sun, 26 Sep 2021 22:38:05 +0200 (CEST) Received: from localhost ([::1]:56130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUauS-0005rW-Ty for larch@yhetil.org; Sun, 26 Sep 2021 16:38:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUatS-0005lM-9Z for guix-patches@gnu.org; Sun, 26 Sep 2021 16:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55512) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUatS-00066q-0D for guix-patches@gnu.org; Sun, 26 Sep 2021 16:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUatR-0000GD-Lu for guix-patches@gnu.org; Sun, 26 Sep 2021 16:37:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50722] [PATCH] gnu: Update amsynth to 1.12.2 Resent-From: Thomas Albers Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Sep 2021 20:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50722 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 50722@debbugs.gnu.org Received: via spool by 50722-submit@debbugs.gnu.org id=B50722.1632688588960 (code B ref 50722); Sun, 26 Sep 2021 20:37:01 +0000 Received: (at 50722) by debbugs.gnu.org; 26 Sep 2021 20:36:28 +0000 Received: from localhost ([127.0.0.1]:38825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUasm-0000FI-Le for submit@debbugs.gnu.org; Sun, 26 Sep 2021 16:36:28 -0400 Received: from vmd69031.contaboserver.net ([161.97.172.214]:41382 helo=mail.thomaslabs.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUasj-0000F8-JV for 50722@debbugs.gnu.org; Sun, 26 Sep 2021 16:36:18 -0400 Received: from laptop.thomaslabs.org (unknown [37.5.252.227]) by mail.thomaslabs.org (Postfix) with ESMTPSA id 007C09C002E; Sun, 26 Sep 2021 22:36:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thomaslabs.org; s=mail; t=1632688576; bh=cOG3pBe2lW4oZ+WJOMF84/mWTbodec1cT6mlGogn4Wg=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=4EKUUTf5ohdJua/EEoxF0bnejNRNPIKD6Pdb+79NBl0U5Foc/Dm09afUnx/zYjC0C d1Vgu8N4PhgTnM6r1HjT/PMk9fCuNrZuzEt+uD0iy7B5gNBJ6mgxEd9OEmJYABQTWe 3G1iYwZA2YiDXudHTKzDz4q4ytIxDoU5pwpFH3Xtd5KOZnT2uKZXquzFa7NdS2ReRQ X5kgDvgwVilcxlE88EmLwt0XDX9x26lNLQx1H5t/T7+avLkCaY3/PXlZZbmEoz/bSS ClqKk0y4d80mZK8JxXCtHlzEvjb5WRVPHVgcyoNsa1ItXHQE35VRaR76hP3osLnZmf zSc195xz1zKpw== References: <20210921141701.6928-1-thomas@thomaslabs.org> User-agent: mu4e 1.6.5; emacs 27.2 Date: Sun, 26 Sep 2021 22:17:18 +0200 In-reply-to: Message-ID: <878rzjdqh8.fsf@thomaslabs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Thomas Albers X-ACL-Warn: , Thomas Albers via Guix-patches From: Thomas Albers via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632688685; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4p1ngpRjpwGeM4oGgqbOPZJM2DaNop6MY+5CbHfbobU=; b=frQQyT6N2eFHUn+Zw25ZgYni0tK5ZCu3lPmueFR9rCiU5i3oFu23IEcAn8Sb2Jr347oUMg 3lFbZaotKCNrhpes0YDuXTBOT35mDT54ZpV6QU46VBXSN4QW/1Hi3EY8UXZC9cUz7f7A57 UcB9WGjejqpOIBMSNJ5BpABr597zisT3adlBS5q3x6edBvblzFNrLSQH6CZTNaOoFrVv9C UKHlX5OjFdDGvn0LnW9xMlb5o9fliXO7h1dtzJy9EWNuk/7ufAVhUyelc9Reog22+IIltU 41CkDXZrFa6DoZWUHI3TMKlOhKI67CJMqa5vYLYghsKWFOS9KPEnw8LR5waOug== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632688685; a=rsa-sha256; cv=none; b=LAzgWvs3BaYCVIXztEJneJDV8bqW8JKPUIlNxD5NAVWGUowpwbVXwMMsOhfecwxswex6S0 xvWfD3fISt5oGZWYSWQnmWMWHT10UTztGBjPCrPRMXRJSUWrPxZuyu9q/HpGzKg2rVxOuj bX/a1DtDBr9POWbiFl/q/uZqc6hcxzsR+lhIIYzCm9ki3cXiQAUMi/IC1xTAFkECq9YsJ9 sI/SYEF8UGzG4K7GQc4AiS7PrwmaoqbMDRQhrxlvIaEo6V/bQIquZMiC+hFITIH8m1oKL2 OzCA+w46mf4lUZTSu6tKqMZcpICVIwrhuwo90nCZ2CXvVntLwE99kl8YUpnQMA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=thomaslabs.org header.s=mail header.b=4EKUUTf5; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.89 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=thomaslabs.org header.s=mail header.b=4EKUUTf5; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B9A6C3004D X-Spam-Score: -2.89 X-Migadu-Scanner: scn0.migadu.com X-TUID: +Zu3G5i/jlxf Hello Efraim, thank you for your comments. Yes `gsettings-desktop-schemas' is actually needed to avoid a running time error on systems that do not include the package inside the profile in which amsynth is installed. It is also important for it to be a `propagated-input'. That way guix updates the GLib schema cache. For example, I run a desktop environment without login manager (dwm lanched with a custom startx script). As such the following runtime error is generated: GLib-GIO-ERROR **: 22:14:48.344: Settings schema 'org.gnome.desktop.interface' is not installed This error is most likely generated inside the function `get_scaling_factor ()' at line 293 from editor_pane.c About you other comment. I failed to notice the LASH problem. Mainly because the program still works. I'll look into it. > [[PGP Signed Part:Undecided]] > Couple of comments about the patch: > > gsettings-desktop-schemas don't seem to be needed at build time, and it > launched fine for me when I removed it from the build entirely. > > When I launuched it from the command line I got errors about not being > able to connect to lash. > > Is the lash bit a regression from the currently packaged version? Are > you sure gsettings-desktop-schemas is actually needed? > > Thanks. > > > On Tue, Sep 21, 2021 at 04:17:01PM +0200, Thomas Albers via Guix-patches = via wrote: >> --- >> gnu/packages/music.scm | 12 +++++++----- >> 1 file changed, 7 insertions(+), 5 deletions(-) >> >> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm >> index ff1330d228..fe64b2af1b 100644 >> --- a/gnu/packages/music.scm >> +++ b/gnu/packages/music.scm >> @@ -43,6 +43,7 @@ >> ;;; Copyright =C2=A9 2021 Felix Gruber >> ;;; Copyright =C2=A9 2021 Simon Streit >> ;;; Copyright =C2=A9 2021 Xinglu Chen >> +;;; Copyright =C2=A9 2021 Thomas Albers Raviola >> ;;; >> ;;; This file is part of GNU Guix. >> ;;; >> @@ -2354,16 +2355,16 @@ special variant of additive synthesis.") >> (define-public amsynth >> (package >> (name "amsynth") >> - (version "1.7.1") >> + (version "1.12.2") >> (source >> (origin >> (method url-fetch) >> (uri (string-append "https://github.com/amsynth/amsynth/releases= /" >> "download/release-" version >> - "/amsynth-" version ".tar.bz2")) >> + "/amsynth-" version ".tar.gz")) >> (sha256 >> (base32 >> - "1882pfcmf3rqg3vd4qflzkppcv158d748i603spqjbxqi8z7x7w0")))) >> + "0lhp7fymm2fids02y43cy422jzmdiraszll1mk3gzlbfwg33ds1i")))) >> (build-system gnu-build-system) >> (arguments >> `(#:phases >> @@ -2372,13 +2373,12 @@ special variant of additive synthesis.") >> (lambda _ >> (substitute* "src/GUI/editor_pane.c" >> (("/usr/bin/unzip") (which "unzip"))) >> - (substitute* "src/GUI/GUI.cc" >> + (substitute* "src/GUI/MainMenu.cpp" >> (("/usr/bin/which") (which "which"))) >> #t))))) >> (inputs >> `(("alsa-lib" ,alsa-lib) >> ("gtk+" ,gtk+-2) >> - ("gtkmm" ,gtkmm-2) >> ("jack" ,jack-1) >> ("lash" ,lash) >> ("libsndfile" ,libsndfile) >> @@ -2386,6 +2386,8 @@ special variant of additive synthesis.") >> ;; External commands invoked at run time. >> ("unzip" ,unzip) >> ("which" ,which))) >> + (propagated-inputs >> + `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas))) >> (native-inputs >> `(("intltool" ,intltool) >> ("pkg-config" ,pkg-config))) >> -- >> 2.33.0 >> >> >> >>