From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QxdzG2DE12GWhwAAgWs5BA (envelope-from ) for ; Fri, 07 Jan 2022 05:41:04 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id xKAbGGDE12FKigAA9RJhRA (envelope-from ) for ; Fri, 07 Jan 2022 05:41:04 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E1E743B1B3 for ; Fri, 7 Jan 2022 05:41:03 +0100 (CET) Received: from localhost ([::1]:57152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5h3l-0006LD-5g for larch@yhetil.org; Thu, 06 Jan 2022 23:41:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5h2p-0006K9-2o for guix-patches@gnu.org; Thu, 06 Jan 2022 23:40:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49879) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5h2o-0007sI-Nw for guix-patches@gnu.org; Thu, 06 Jan 2022 23:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5h2o-0001Pc-FC for guix-patches@gnu.org; Thu, 06 Jan 2022 23:40:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53057] [PATCH] gnu: Add stress-ng. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Jan 2022 04:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53057 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 53057@debbugs.gnu.org Received: via spool by 53057-submit@debbugs.gnu.org id=B53057.16415303615371 (code B ref 53057); Fri, 07 Jan 2022 04:40:02 +0000 Received: (at 53057) by debbugs.gnu.org; 7 Jan 2022 04:39:21 +0000 Received: from localhost ([127.0.0.1]:42782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5h28-0001OW-RE for submit@debbugs.gnu.org; Thu, 06 Jan 2022 23:39:21 -0500 Received: from mail-qt1-f173.google.com ([209.85.160.173]:46896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5h24-0001OF-HO for 53057@debbugs.gnu.org; Thu, 06 Jan 2022 23:39:19 -0500 Received: by mail-qt1-f173.google.com with SMTP id v7so1167396qtw.13 for <53057@debbugs.gnu.org>; Thu, 06 Jan 2022 20:39:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iexnTeXU63E4fv0AVdVV4w4IPGmmqre1OunR2Vdhbe4=; b=NgqQ4QSN663WlLS1cm+0nq3YLtv7ZOfSaTKWSRuNkTDHPU3+g+xWelLFyp1rTh9KXx QFakfq2uKZUd73/Nw0CL/EPrRP3jVaYR/afhg11hGrw/1opwniKRYGZb9NDwJ6VmszR2 xcK5Qw2BuU3rGcXNjbgzDb3+MxxXn6ClWivRVERTmntdTMH75MDSGJjeGC2JLnva5od6 KOSC5Vq06Lxu09j5Oj37Czd88JZ5RN2e/K92Nho2e8jy/qyx6UhYhwvcV7nI1tlKzvIG 3vb6Fv8rp2EbuxCsBmjnw027XrU8mESoDL1e7v71ehzxUsYTv68Q1ePsjqrCCxONu9vG 6GIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=iexnTeXU63E4fv0AVdVV4w4IPGmmqre1OunR2Vdhbe4=; b=ONIy59Y7qAIPmK5L/+gEUfWSLB4iZItQ2pOED1supbCP+IUeXyDGP1yFvTczqXTP0O fIYRH5JNMlaphHf5sKoKICIrKWHzaMMG4olTKTymPFsCZvpwl2YTnJKZiqCbFdUCPX1m +Hmevwa8878uEo+INHzK39jO8GvEq2APYCPyKPRu/i9V2n6Rso6+bOO1U8hbGq2jBH3N ImdTAh147gVvnV2WRBrSkuRrCgPPKQgd3KMOseUp0s0i4bnSTW26bQENUs95v6F5HUUl d3WxtuNgdPpsdNqE0BlFYK3t9d/6gdF8swgLhfCu/Q2dquzTOWFEY82bXswHoRo54rXT bC2w== X-Gm-Message-State: AOAM530mDkBdSh4XK6aP61Z3/wyYS2h/HPEXAwClcpl43Z3GQ6JnjxA7 yvlK1jfzH6oXEsYcw/QE0gWh08G8jsDUnA== X-Google-Smtp-Source: ABdhPJwWBAf6C9UNUIENlFDvdUonY4bTWwVA/pv6bOunLs2s3jN/h+IUbYoILvsaC+PzgU27yxlF8A== X-Received: by 2002:a05:622a:281:: with SMTP id z1mr53665895qtw.247.1641530350770; Thu, 06 Jan 2022 20:39:10 -0800 (PST) Received: from hurd (dsl-10-146-199.b2b2c.ca. [72.10.146.199]) by smtp.gmail.com with ESMTPSA id n11sm2796290qtk.44.2022.01.06.20.39.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 20:39:10 -0800 (PST) From: Maxim Cournoyer References: <20220106180636.31164-1-me@tobias.gr> Date: Thu, 06 Jan 2022 23:39:09 -0500 In-Reply-To: <20220106180636.31164-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Thu, 6 Jan 2022 19:06:36 +0100") Message-ID: <878rvsqhw2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641530464; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=iexnTeXU63E4fv0AVdVV4w4IPGmmqre1OunR2Vdhbe4=; b=dUGcbNxi4jr9R2hWCeI85Z2NIsi24Exs6UksWgdNIJpMkLTi0w7AFWO7az7P1yq/CwYXDj 5WcMeFX6yutruXYUKzylTxId5ThZc4i27AQsjChmmqjoweiEOXI6ARGxXRfRMGspFSlY57 Bj6TE6TZOGpOGETTGdbKDjJv9tDHRoicBIjBc/BRwFhikd1gY7WyO9Ke5SlzZL2d+mIgyw F9YR+3HNbEZWK37cSwxKaxxBfha2QaUq1F5Algu4ndDzPbvSQvaxuNTMnsDANP7PlDCZo0 cH1rNkQbMk7MQIUEWehlPr3mf+GM/ci1jKEoQmSURVTkexD0qoxCQ8CPg38VuQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641530464; a=rsa-sha256; cv=none; b=IEM25cn0OrxjynwLV4iCup+LgucVnQCHsZEaApsu3kTuEN0QNpjdYBY0CLAjIwpogdlW0f QTjK5PT5BhOvI1VtUjaiBnxfdkaMfjBFjaW3aJ27VRwXGRY3BjedufrqsZt+Co2iHIViP9 04OVTCsX++BkjkcvKB05VRVt5inhdAdoJx3id3XU8SuQI59raRidJ4EakgIFNtojJ8WrjY crkI7fAhI4nIMgw/epI7b51mSM0PoHc6OruMctZaJ6WXzJKQsdXnmouHYQ4CJIBfodtrxf ydZxx4SYuk5aQf/+5KzLXJPHjso6wxb/mVhOSkg5lWOx2z4B9rcypZ+CSrTlvQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=NgqQ4QSN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=NgqQ4QSN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E1E743B1B3 X-Spam-Score: -2.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: bqcRi9cKAonZ Hi Tobias, How timely! :-) Tobias Geerinckx-Rice writes: > * gnu/packages/admin.scm (stress-ng): New public variable. > --- > gnu/packages/admin.scm | 67 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > > diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm > index d45857150f..6e180ec80a 100644 > --- a/gnu/packages/admin.scm > +++ b/gnu/packages/admin.scm > @@ -2260,6 +2260,73 @@ (define-public stress > system is under heavy load.") > (license license:gpl2+))) > > +(define-public stress-ng > + (package > + (name "stress-ng") > + (version "0.13.10") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/ColinIanKing/stress-ng") > + (commit (string-append "V" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "1z9vjn2131iv3pwrh04z6r5ygi1qgad5bi3jhghcvc3v1b4k5ran")))) > + (build-system gnu-build-system) > + (arguments > + (list #:make-flags > + #~(list (string-append "CC=" #$(cc-for-target)) > + (string-append "BINDIR=" #$output "/bin") > + (string-append "MANDIR=" #$output "/share/man") > + (string-append "JOBDIR=" #$output > + "/share/stress-ng/example-jobs") > + (string-append "BASHDIR=" #$output > + "/share/bash-completion/completions")) > + #:test-target "lite-test" > + #:phases > + #~(modify-phases %standard-phases > + (delete 'configure) ; no configure script > + (add-after 'check 'check-a-little-harder > + ;; XXX Guix supports only one #:test-target. Run more tests. > + (lambda* (#:key tests? #:allow-other-keys) > + (when tests? > + (substitute* "debian/tests/fast-test-all" > + (("EXCLUDE=\"" exclude=) > + (string-append exclude= > + ;; Fails if host kernel denies ptracing. > + "ptrace "))) > + (invoke "make" "fast-test-all" > + "-j" (number->string (parallel-job-count))))))))) This looks good and works good too! My only comment is that this should honor parallel-tests?. Reusing the check phase but overriding the test-target argument should do it: modified gnu/packages/admin.scm @@ -2289,15 +2289,15 @@ (define-public stress-ng (delete 'configure) ; no configure script (add-after 'check 'check-a-little-harder ;; XXX Guix supports only one #:test-target. Run more tests. - (lambda* (#:key tests? #:allow-other-keys) + (lambda* (#:key tests? #:allow-other-keys #:rest args) (when tests? (substitute* "debian/tests/fast-test-all" (("EXCLUDE=\"" exclude=) (string-append exclude= ;; Fails if host kernel denies ptracing. - "ptrace "))) - (invoke "make" "fast-test-all" - "-j" (number->string (parallel-job-count))))))))) + "ptrace ")))) + (apply (assoc-ref %standard-phases 'check) + `(,@args #:test-target "fast-test-all"))))))) (inputs (list keyutils kmod Otherwise, LGTM! Feel free to push with such adjustment. Thank you! Maxim