From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4LQTB1NH32EpnQAAgWs5BA (envelope-from ) for ; Wed, 12 Jan 2022 22:25:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mCOBO1JH32GNOAEAG6o9tA (envelope-from ) for ; Wed, 12 Jan 2022 22:25:38 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 922E93791C for ; Wed, 12 Jan 2022 22:25:38 +0100 (CET) Received: from localhost ([::1]:48186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7l7h-0001jp-FV for larch@yhetil.org; Wed, 12 Jan 2022 16:25:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7l5D-0000NY-2K for bug-guix@gnu.org; Wed, 12 Jan 2022 16:23:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38150) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7l5C-0002pR-Od for bug-guix@gnu.org; Wed, 12 Jan 2022 16:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7l5C-00072l-Hr; Wed, 12 Jan 2022 16:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#53005: [PATCH 1/1] gnu: glibc: Preserve "__pthread_key_create" symbol. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 12 Jan 2022 21:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53005 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Leo Famulari Received: via spool by 53005-submit@debbugs.gnu.org id=B53005.164202255427017 (code B ref 53005); Wed, 12 Jan 2022 21:23:02 +0000 Received: (at 53005) by debbugs.gnu.org; 12 Jan 2022 21:22:34 +0000 Received: from localhost ([127.0.0.1]:59285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7l4k-00071g-5V for submit@debbugs.gnu.org; Wed, 12 Jan 2022 16:22:34 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:48496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7l4i-00071D-Ee for 53005@debbugs.gnu.org; Wed, 12 Jan 2022 16:22:32 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 8BB4E6EEB5; Wed, 12 Jan 2022 21:22:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo05-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo05-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G_cGWc6vNEZk; Wed, 12 Jan 2022 21:22:26 +0000 (UTC) Received: from laptop (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 375E76DA55; Wed, 12 Jan 2022 21:22:26 +0000 (UTC) From: Simon South References: <7e85b4a230a68240759120e8440ea77cf1d6e927.1641856285.git.simon@simonsouth.net> Date: Wed, 12 Jan 2022 16:22:27 -0500 In-Reply-To: (Leo Famulari's message of "Wed, 12 Jan 2022 14:21:55 -0500") Message-ID: <878rvkodik.fsf@simonsouth.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 53005@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642022738; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=EUKnw1rDTKupgxBXOxvw6DQycKpP/9QHKPRv5wD1ms4=; b=gea43s/NO0VUqYR/hbmE3WKPjJYw7OJhXK7gRLQZ/q9prWr2Ijj26cUhj3r4Ud65gXvfA3 FW3lEXIgnoRpe1dmRrQmNr/gcx6UZ6S40e1a3aQLiZowWajDnr9543nswU2GSJwT+gFSku JeHlABPcOz5hnJj3oxbrDz0/FSww63qJB9rpeYww1WWSYArTLvFkuEXTdONlnRRTbEUiDv 2JAIl2++/MkF1i6ZpgHSTDTAmxkfGbkltwsfoCqZGfrIzMY18LxNS+BTJ/bolfetncxShF KGxVX8/+QAjgSD9WVZTkMB24ckCly3K3BVXyGT5GTBCwIaBvLJ/ntEV8SWFigg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642022738; a=rsa-sha256; cv=none; b=dwR+QIaT1a4aliF3P0sxdSCpDwUqxdHY0F8PMuGwwLaePG+59ANNxoK8bJp0RjWAMJ1eiS 7LRRbz+AWM+WjSXsHoj08bILSFNkgSKxDqsDILsjTpvrD08Q5ggto2PKcCTBYI646X1yyi QbkqxVkBAACVTx32qqe0Nw34plc6y2uvwWiu2mQr87O//uIprr6jcQtYTwum3rNAz6vkR/ IDD+cI5Za56kEh1alDcKO9SzaiferyxuKPu8AelM5Yb85VRByV0QxR/FbO/b7Zl4aQq6eW ODbeyGXerwZaB5xWfjJZKQMXZiMjHyxK2RWcwNE/Ex+/vjD2udIVXF+y6D90mA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.32 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 922E93791C X-Spam-Score: -3.32 X-Migadu-Scanner: scn1.migadu.com X-TUID: p6lXWeMb40jv Leo Famulari writes: > First, how was the LUKS2 volume created? Was it created by Guix > System? No, this would've been a volume I created myself; I expect only users who are partitioning their drives manually or replacing an existing system would encounter this. The Guix manual actually instructs users to select a different PBKDF algorithm[0] for compatibility with GRUB, one that by coincidence does not appear to be affected[1]. However, remember this problem potentially affects _all_ packages that use threads in C or C++. It appears that dynamically-linked executables (i.e. the vast majority) generally sidestep the problem by avoiding any "dangerous" methods in libgcc, but there could still be crashing bugs elsewhere waiting to be discovered. > Is Guix doing something wrong that requires the workaround? This is all a consequence of stripping libraries with the "--strip-unneeded" option instead of "--strip-debug"[2], in the interest of reducing store sizes. The man page for "strip" describes it like this: --strip-unneeded Remove all symbols that are not needed for relocation processing. My personal opinion is that this option makes sense for executables but is too aggressive to use on libraries. - Unlike executables, we generally want to do more with a library than just relocate it. - Providing a rich set of symbols is normally a desirable feature of a library and not a bug. - Only at link time is it possible to say which of a library's symbols are truly relevant; therefore, the selection of symbols to retain should logically be performed by the linker, not an automated step during the library's packaging (outside of any link context). Specifically, it's impossible for us to predict cases like this one, where a symbol not obviously needed to use a library is nonetheless relied on by an application. However, Guix's gnu-build-system provides only a single "#:strip-flags" argument that is applied to all of a package's binaries. So, as an alternative solution, we could either extend that mechanism to allow different sets of flags to be applied to different types of binaries, or revert the changes (commits f32a6055a5 and e0f31baacc) altogether. I didn't expect either of those options would be popular, and truthfully, everything does appear to work okay (for now) with only this one change to glibc. [0] https://guix.gnu.org/en/manual/devel/en/html_node/Keyboard-Layout-and-Networking-and-Partitioning.html#Disk-Partitioning [1] But then, neither GRUB nor the Guix installer are commonly used on non-Intel systems. [2] Originally proposed in https://issues.guix.gnu.org/42555 -- Simon South simon@simonsouth.net