From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cNtEC4WZkGIiXQAAbAwnHQ (envelope-from ) for ; Fri, 27 May 2022 11:27:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4IgsC4WZkGJM2AAAauVa8A (envelope-from ) for ; Fri, 27 May 2022 11:27:33 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 06E4A11747 for ; Fri, 27 May 2022 11:27:32 +0200 (CEST) Received: from localhost ([::1]:50268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuWFn-0006Lv-4m for larch@yhetil.org; Fri, 27 May 2022 05:27:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuWDO-00069o-Uy for guix-patches@gnu.org; Fri, 27 May 2022 05:25:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38797) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuWDO-0003Aq-KR for guix-patches@gnu.org; Fri, 27 May 2022 05:25:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuWDO-00045S-HF for guix-patches@gnu.org; Fri, 27 May 2022 05:25:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55637] [PATCH] gnu: Add python-canopen. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 May 2022 09:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55637 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: peter@polidoro.io Cc: 55637@debbugs.gnu.org Received: via spool by 55637-submit@debbugs.gnu.org id=B55637.165364349015689 (code B ref 55637); Fri, 27 May 2022 09:25:02 +0000 Received: (at 55637) by debbugs.gnu.org; 27 May 2022 09:24:50 +0000 Received: from localhost ([127.0.0.1]:60927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuWDC-00044y-KB for submit@debbugs.gnu.org; Fri, 27 May 2022 05:24:50 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuWD9-00044p-ET for 55637@debbugs.gnu.org; Fri, 27 May 2022 05:24:49 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 55F3D27BBE9; Fri, 27 May 2022 10:24:46 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 1d52c7be; Fri, 27 May 2022 09:24:45 +0000 (UTC) References: <865yltftp9.fsf@polidoro.io> <5fbd41490624bfb900d276f616be21edaadf724a.1653498609.git.peter@polidoro.io> User-agent: mu4e 1.6.10; emacs 27.2 From: Christopher Baines Date: Fri, 27 May 2022 10:22:08 +0100 In-reply-to: <5fbd41490624bfb900d276f616be21edaadf724a.1653498609.git.peter@polidoro.io> Message-ID: <878rqntjj8.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653643652; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=hz0R9lC4rH+1vsZFCEY8vsVbE2tPlIwVJH6lNvcfQSI=; b=RbgzT9ERgOb0J33fwmE5qm7KSMruLeFumc9fvwG9dx/hV1/csSr3MwLNMp44ShK9ODge3I 3vcphEwd7u8oc41RkbqCccppPpaIgQ2lwH4Ctu+iaiB7d6/ftO2KvBjfA4dYMJfUwNApSu vhIapiVeLOJWOEqpggoP+GCH50oWOVNmoyrosiM4udTX5eSzR5VA5OIY6FGufDSl8sF/sH bA7NrJPHsb8eQU/zjFybNvuNoVC31D9MkYGbFC8MpsXeOC1OpuPt81nkNJtkehBaarTHHw t9fszrxUJvggdmy/FIYcsMZsjh20hjs6WQhVw7v4ujyWe1C3u9+0Fy2A+f5MPQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653643652; a=rsa-sha256; cv=none; b=nifUmCDJVMhSGoh2MvODzvbe8ABp1nI7N2FP9dEB70SRwSOZjOCLo4ps/zQihwPxx8eupf /dzZ8TD0csPIuyrzcu6HGo9q/JLdFMH7kbagjQxjjX0byv31wWARgyWl/t4CFGu69beOjW AynEwzHF8jhIY8Rt1hv9c4HmJtueP/ZlVk1S2DnrwK88iQONW7BgSD/o/RwiUxSFg6uK59 VJazlGcDZgMfNrj60qaHai5zwol6UGa0e8kVtQ4Zk6hleBhaiKCaRG+DeQnwu6Twm335KA oHwQJzeEJlOMRdOnLBhhA2zEyCrNJjLuAhpXdm+swlLetB+Q6oKWsp5Ck7/3Sg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.44 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 06E4A11747 X-Spam-Score: -6.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: joOLT6/iuaB+ --=-=-= Content-Type: text/plain peter@polidoro.io writes: > From: Peter Polidoro > > * gnu/packages/python-xyz.scm (python-canopen): New variable. > --- > gnu/packages/python-xyz.scm | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm > index 6ca759e2e2..35a2009f69 100644 > --- a/gnu/packages/python-xyz.scm > +++ b/gnu/packages/python-xyz.scm > @@ -31743,3 +31743,24 @@ (define-public python-preshed > "Simple but high performance Cython hash table mapping pre-randomized keys > to void* values.") > (license license:expat))) > + > +(define-public python-canopen > + (package > + (name "python-canopen") > + (version "2.0.0") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "canopen" version)) > + (sha256 > + (base32 "1nb543wb37kj95v6bhh272lm5gkpi41q3pnsl1fxlyizm2gamj5w")))) > + (build-system python-build-system) > + (native-inputs (list python-packaging)) > + (propagated-inputs (list python-can)) > + (home-page "") > + (synopsis "CANopen stack implementation") > + (description "A Python implementation of the CANopen standard. The aim of > +the project is to support the most common parts of the CiA 301 standard in a > +simple Pythonic interface. It is mainly targeted for testing and automation > +tasks rather than a standard compliant master implementation.") > + (license license:expat))) The linter picks up a couple of issues: gnu/packages/python-xyz.scm:31761:17: python-canopen@2.0.0: sentences in description should be followed by two spaces; possible infractions at 47, 162 gnu/packages/python-xyz.scm:31759:15: python-canopen@2.0.0: invalid home page URL: "" Plus, I'd avoid adding packages to the end of modules. If everyone does this, it means lots of git conflicts. Instead, try and slot the new package definition in somewhere close to related packages, or alphabetically, or randomly even if neither of those approaches apply. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmKQmNtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xf4jQ//dnww1oUrCcXgEhLVggVsyFtwgRAs/44w 56DjszKnp47w2kVhBcYXLZ366ppkxkokNylj8C6rSLJaj4fejvYIkxPXbEHt14qU Fqhn37H4upvQwvuhiE0vyQmQ1Tf7YPZgj0YH0sGGc/972y3xkipqxc7j/lxmChEj dmAxB+vJNFFcqqnUtWW7FLXrAjUg3lhESUTX13VGAyD1LAYynKwVUF6MJQ6tSU/Y wgUUaqpC9Huv9l4k1c7omNm7wHfZdiZ8Khyz5ZEw+kH+KMFG5QwJO1mY9CPRwkhQ cxPDcgdMfcWZzkxPChvQ23TMNTJoT8UvaQ7wqY6xkGOD0hyyZXfuV3FgMH5Zwmp2 brpJvGdDMtenWLnsAlIQ1LK5/zyX9Mo5GtAv0fYiVxzU7+0og/9/NYuSOMv3MqJz o8FrY05H/9HkMgjHZxdY0Q/wpBVw/lOcHggg3ycU2QK2LP9thbdO0s7GXwb79EUp M7qv+DUz0ZKDL4zOX4VmDkQF4LB2hOo4OjPN1jQaoffo1QSdqT5kUFCgtKzqkJgr Pv9rl2a9mdGhdlf/yrfyHhFfYz5DmGc93B8l6pvxGpt4n/Zw6U7Q9Y1hp0ifM7r/ td7jKP6ZoYErYGaGJ0BbtgIdaFFoXkTxz8aQ8oGHPtLBApdp5BrJ7RmyJQtyKsen 1Q8dId+YuxI= =3SvW -----END PGP SIGNATURE----- --=-=-=--