From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MKxSF35fymL+twAAbAwnHQ (envelope-from ) for ; Sun, 10 Jul 2022 07:11:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uBJgFn5fymIXYgEAG6o9tA (envelope-from ) for ; Sun, 10 Jul 2022 07:11:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 036E319803 for ; Sun, 10 Jul 2022 07:11:25 +0200 (CEST) Received: from localhost ([::1]:44634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAPE4-00088t-Va for larch@yhetil.org; Sun, 10 Jul 2022 01:11:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAPDv-00088V-Q6 for bug-guix@gnu.org; Sun, 10 Jul 2022 01:11:15 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42256) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAPDi-0001LU-1g for bug-guix@gnu.org; Sun, 10 Jul 2022 01:11:14 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oAPDh-0005Db-RP for bug-guix@gnu.org; Sun, 10 Jul 2022 01:11:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#55936: [PATCH] services: docker: Fix race condition. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 10 Jul 2022 05:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55936 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Oleg Pykhalov Cc: 55936@debbugs.gnu.org Received: via spool by 55936-submit@debbugs.gnu.org id=B55936.165742984719996 (code B ref 55936); Sun, 10 Jul 2022 05:11:01 +0000 Received: (at 55936) by debbugs.gnu.org; 10 Jul 2022 05:10:47 +0000 Received: from localhost ([127.0.0.1]:36153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAPDS-0005CS-M7 for submit@debbugs.gnu.org; Sun, 10 Jul 2022 01:10:46 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:40485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAPDQ-0005CE-MX for 55936@debbugs.gnu.org; Sun, 10 Jul 2022 01:10:45 -0400 Received: by mail-qk1-f172.google.com with SMTP id y22so692008qki.7 for <55936@debbugs.gnu.org>; Sat, 09 Jul 2022 22:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=NGwVSoPP9E7JR+lnurOQwFSron90E4Gttq5jRRrwncQ=; b=DP12/AU6WQy04gQqmewKdbgwZi65LRKF3DFGcFFmWJnTRrLebe9mClzdXBx82OBa72 D7hFI91MaGabxaSZ7H5yKhCMiNcmq29mI41BMliEHBQkv3CGPxmpYJvj+Tw15SfZEp2P 7raUDUtUJ/jYlXqxme9i7eq50kdmg7Y71NEq4NdNmYv7MvPGuY1ZyLneDpAzBbMvTF+O pdnnAjqGgnIZF8rc729rJlOTEJCI1blXGSA4OPOrxERAUJt3MGnITEhieOzlX4wgYZLP lCh9Azo94SbM9Jv/tRKQdkVoofWMn+7MwvOgxQsMGmqXBeL9okl2bMbs3YtRPLEBuSqB Fn3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=NGwVSoPP9E7JR+lnurOQwFSron90E4Gttq5jRRrwncQ=; b=1sG/z0m8AGdL28ZdNdKnGYrxXNe9doW7LEPsje52Qie2U0MHl4DXuZvrvPZruIAsvB ZvW8DI7BKdr4jtqyzXykksB65NUGSJnyS4MX3/2xdOkiIPQzkEh0SwD5ya4o3CyBRN85 CTk/jE9ayOqDNPPnvVXz6wNwunkBuyAlcaeE9JVAlDo8voB9IgNoZS8Aeao2XDnd4gyb bFBvnK6/eLyq4N5Ibob6J+O/URqfym5hhXSbUyTKlrMyBKigkqTnKStgqQH58GqkHhJR NeFEk1oO5l5hTvV7ZW+GMCNdsi0ApuUwmbJ7FJWaAXVyWVjfKXeqbMBc3btcmkF9OT+X f2Ew== X-Gm-Message-State: AJIora9a2R+hH7IXEw2Yiv5CI6No6w0I0M3sITCCJaSBhh04sARlmCTk kdVW05ES4R/S0kUiHk+Ed6CWNvxP1FgtPQ== X-Google-Smtp-Source: AGRyM1uRvrLE9i/jk5J/I4a1+4dpdebk78uaeMXuVK8ep+LgV8jPtCmwrTdEP/0ZRTqSTB31W/zpGw== X-Received: by 2002:a37:64a:0:b0:6b5:652f:10ac with SMTP id 71-20020a37064a000000b006b5652f10acmr6769698qkg.241.1657429838966; Sat, 09 Jul 2022 22:10:38 -0700 (PDT) Received: from hurd (dsl-10-135-142.b2b2c.ca. [72.10.135.142]) by smtp.gmail.com with ESMTPSA id o21-20020a05622a009500b0031d4044c464sm2889657qtw.46.2022.07.09.22.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 22:10:38 -0700 (PDT) From: Maxim Cournoyer References: <20220702104106.16997-1-go.wigust@gmail.com> Date: Sun, 10 Jul 2022 01:10:37 -0400 In-Reply-To: <20220702104106.16997-1-go.wigust@gmail.com> (Oleg Pykhalov's message of "Sat, 2 Jul 2022 13:41:06 +0300") Message-ID: <878rp1ft82.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657429886; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=NGwVSoPP9E7JR+lnurOQwFSron90E4Gttq5jRRrwncQ=; b=Xkd7tHvePJWr7EfdJRCX2M5sx34C2UFAVBdTdrgmr8hxKLqgsvocW7ZCUnX9E1FaqoGMFE o55Z/xdyT0z7s0uHNSRPAQUyOj0FsA4wyHqikTsVvyUrl1vhNahGrvMP/8A8JNoO6LQgy0 SbLZSNl000CwTZkVxfTfHWkMH2is4+kSaWAV7iHT3JBPSi2vAFxtHTHFmxFUx0QdS2I4i0 xA/DVW35AOXzoc5HL7m/QZIVu/CABQNCvZrMaSzYATCGa5eD2ngDufKYYG5gJY9swJx3Cv iVMx99YAFTiY6zymxg4SHTiZmEhXSMD1mb0WryNrfxBt3Gf7aBoSllrBmQgpBg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657429886; a=rsa-sha256; cv=none; b=oHOJ3uyo+oLXmb6Az/muktODRJSWgHUvSd/p5dyJoJwtf6iceT0nrr1IvsVufEFgHeGvYN V+n8IglkNVX6LWJOArl7RvyCXvJYry8JTUw99UJMYNOu2rXfH9e0WP73JR7fHTaztRx9gF dKdkpwJnY+QXh993ZNuLxcYmjXE6OMWqhROM0Nhy4nBgcb5oKOsTcncIvDPvESbqqKRKRO a8UJ7Ag4S4rxZyBIx6NTg1tFzpCEie4LxK6ouXqJpl1YdjD4lv7uKGNI7EbZ6NkEsOdXHX 6i1J5efhsm2gsPT60tS7+b9ct/g5bava28QY1fyYu4ZMHYXY+urv3W/Jv4cajw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="DP12/AU6"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.75 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="DP12/AU6"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 036E319803 X-Spam-Score: 5.75 X-Migadu-Scanner: scn0.migadu.com X-TUID: tFLzQrn6mrht Hi Oleg, Oleg Pykhalov writes: > Fixes . > > * gnu/packages/patches/containerd-create-pid-file.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add this. > * gnu/packages/docker.scm (containerd)[source]: Add this patch. > * gnu/services/docker.scm > (containerd-shepherd-service): Add #:pid-file and #:pid-file-timeout. > * gnu/services/docker.scm (docker-shepherd-service): Add --containerd flag. Thanks for this, it looks promising! Before we go forward though, had you consider using a 'make-systemd-constructor' as now available in Shepherd 0.9+ ? I remember Docker supports systemd socket activation for synchronizing its services; it could be a simpler, no-code solution. Would you like to give it a try? Thanks, Maxim