bug#57827: Shepherd 0.9.2 possible regressions

[Mathieu Othacehe <othacehe@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]


Hey,

> This is fixed by 6abdcef4a68e98f538ab69fde096adc5f5ca4ff4; the log
> contains extra details.

Thanks for fixing it! Turns out we still have an issue on all four
installer tests.

The error messages look like:

--8<---------------cut here---------------start------------->8---
Sep 22 09:49:19 localhost installer[252]: running command ("guix" "system" "init" "--fallback" "--no-grafts" "--no-substitutes" "/mnt/etc/config.scm" "/mnt") 

Sep 22 09:49:21 localhost installer[252]: guix system: error: read error while loading '/mnt/etc/config.scm': /mnt/etc/config.scm:63:51: unexpected ")" 
--8<---------------cut here---------------end--------------->8---

Having a look at the configuration file (attached), it seems that the
problem comes from the edit-configuration-file function. As the
rewritten configuration is shorter than the initial because the comments
are stripped by the pretty-print function, we have some leftovers from
the initial config.

I do not really understand why because call-with-output-file is supposed
to use the O_TRUNC flag and remove the existing content of the
configuration file. Plus, calling edit-configuration-file from a guix
repl does the right thing.

Anyways, I pushed fe4663ae2476cb527d4f1f49ff8fa077d43f7251 which fixes
the issue by removing the file before rewriting it.

Mathieu

[-- Attachment #2: configuration_before.scm --]
[-- Type: application/octet-stream, Size: 2583 bytes --]

;; This is an operating system configuration generated
;; by the graphical installer.
;;
;; Once installation is complete, you can learn and modify
;; this file to tweak the system configuration, and pass it
;; to the 'guix system reconfigure' command to effect your
;; changes.


;; Indicate which modules to import to access the variables
;; used in this configuration.
(use-modules (gnu))
(use-service-modules cups desktop networking ssh xorg)

(operating-system
  (locale "en_HK.utf8")
  (timezone "Europe/Zagreb")
  (keyboard-layout (keyboard-layout "us" "altgr-intl"))
  (host-name "liberigilo")

  ;; The list of user accounts ('root' is implicit).
  (users (cons* (user-account
                  (name "alice")
                  (comment "Alice")
                  (group "users")
                  (home-directory "/home/alice")
                  (supplementary-groups '("wheel" "netdev" "audio" "video")))
                (user-account
                  (name "bob")
                  (comment "Bob")
                  (group "users")
                  (home-directory "/home/bob")
                  (supplementary-groups '("wheel" "netdev" "audio" "video")))
                %base-user-accounts))

  ;; Below is the list of system services.  To search for available
  ;; services, run 'guix system search KEYWORD' in a terminal.
  (services
   (append (list (service dhcp-client-service-type)
                 (service ntp-service-type))

           ;; This is the default list of services we
           ;; are appending to.
           %base-services))
  (bootloader (bootloader-configuration
                (bootloader grub-efi-bootloader)
                (targets (list "/boot/efi"))
                (keyboard-layout keyboard-layout)))
  (swap-devices (list (swap-space
                        (target (uuid
                                 "11111111-2222-3333-4444-123456789abc")))))

  ;; The list of file systems that get "mounted".  The unique
  ;; file system identifiers there ("UUIDs") can be obtained
  ;; by running 'blkid' in a terminal.
  (file-systems (cons* (file-system
                         (mount-point "/boot/efi")
                         (device (uuid "5126-4E82"
                                       'fat32))
                         (type "vfat"))
                       (file-system
                         (mount-point "/")
                         (device (uuid
                                  "4638dd3d-a2bb-47a6-9dd3-59fc29621c2f"
                                  'ext4))
                         (type "ext4")) %base-file-systems)))

[-- Attachment #3: configuration_after.scm --]
[-- Type: application/octet-stream, Size: 2583 bytes --]

;; Operating system configuration edited for automated testing.

(use-modules (gnu tests))
(use-modules (gnu))

(use-service-modules
  cups
  desktop
  networking
  ssh
  xorg)

(marionette-operating-system
  (operating-system
    (locale "en_HK.utf8")
    (timezone "Europe/Zagreb")
    (keyboard-layout
      (keyboard-layout "us" "altgr-intl"))
    (host-name "liberigilo")
    (users (cons* (user-account
                    (name "alice")
                    (comment "Alice")
                    (group "users")
                    (home-directory "/home/alice")
                    (supplementary-groups
                      '("wheel" "netdev" "audio" "video")))
                  (user-account
                    (name "bob")
                    (comment "Bob")
                    (group "users")
                    (home-directory "/home/bob")
                    (supplementary-groups
                      '("wheel" "netdev" "audio" "video")))
                  %base-user-accounts))
    (services
      (append
        (list (service dhcp-client-service-type)
              (service ntp-service-type))
        %base-services))
    (bootloader
      (bootloader-configuration
        (bootloader grub-efi-bootloader)
        (targets (list "/boot/efi"))
        (keyboard-layout keyboard-layout)))
    (swap-devices
      (list (swap-space
              (target
                (uuid "11111111-2222-3333-4444-123456789abc")))))
    (file-systems
      (cons* (file-system
               (mount-point "/boot/efi")
               (device (uuid "5126-4E82" 'fat32))
               (type "vfat"))
             (file-system
               (mount-point "/")
               (device
                 (uuid "4638dd3d-a2bb-47a6-9dd3-59fc29621c2f"
                       'ext4))
               (type "ext4"))
             %base-file-systems)))
  #:imported-modules
  '((gnu services herd)
    (guix build utils)
    (guix combinators)))

unted".  The unique
  ;; file system identifiers there ("UUIDs") can be obtained
  ;; by running 'blkid' in a terminal.
  (file-systems (cons* (file-system
                         (mount-point "/boot/efi")
                         (device (uuid "5126-4E82"
                                       'fat32))
                         (type "vfat"))
                       (file-system
                         (mount-point "/")
                         (device (uuid
                                  "4638dd3d-a2bb-47a6-9dd3-59fc29621c2f"
                                  'ext4))
                         (type "ext4")) %base-file-systems)))