From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eKyeCh/212O3kwAAbAwnHQ (envelope-from ) for ; Mon, 30 Jan 2023 17:53:51 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cIOyCR/212NbSAEAG6o9tA (envelope-from ) for ; Mon, 30 Jan 2023 17:53:51 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D96998C3D for ; Mon, 30 Jan 2023 17:53:50 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMXPB-0008Ab-OO; Mon, 30 Jan 2023 11:53:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMXPA-0008AS-G0 for guix-devel@gnu.org; Mon, 30 Jan 2023 11:53:16 -0500 Received: from mail-il1-x12a.google.com ([2607:f8b0:4864:20::12a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMXP8-0007DZ-Hd for guix-devel@gnu.org; Mon, 30 Jan 2023 11:53:16 -0500 Received: by mail-il1-x12a.google.com with SMTP id i6so1496384ilq.8 for ; Mon, 30 Jan 2023 08:53:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:to:from:from:to:cc:subject:date:message-id:reply-to; bh=WbXo3TFSVR4wF+hVElztRysd0+Dlvl/ig1bgj6TiCMw=; b=qyP0FkWd+H2AOonLgg4YkRTsAtMB2RYKv/yA8VAWyKpjBnSHwECGZK6BFwi1t5h7eL 6fFq+QwHBmqjfHZPGoPU2gzypc1cCgfzBj4pIY2NOr8n7NAM91H3F/5xyl6p+4ukY17g P8MT4chBssBC3rFQA9QZSPuc/PyAMh2ZLJlySLwksf15kQq3P+xyA3Yybe+zOX8KzvCR XfZ/ca9EE3BXlTX5n/xpUXmFfygZRSqXwhq7JvnRtvczHwvnBdZuvs0K1ady4r8xzYcw xDvTJzYkOL3KPTeA2qVX9EZTs63kb2SU8DO++Frzw7ipuhez4SfpvOq1cTaxe3dMKDzd FnmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WbXo3TFSVR4wF+hVElztRysd0+Dlvl/ig1bgj6TiCMw=; b=xyqVOh550SfPwdiG38MlBS56iimhVFacl/AsABDFzrCQ+vHZ48zVkra3RnV0l7+tJW c4eDV9VqktHw5mQ0zwE2UwKr6vPeiTe0537wfPMsG3ZKJG7X1Xw0cGqdsDNM8hrfcg/C IckrYrNZkZ533T3sqW/u53MLA6KggUBUFEOvaDX8LsvPrhKos1fr+X/9GWo62GRkzrsy GWKTV1v2YyhIwx4VhxeMoQ2gtCXzY3SkMpUXmQtjCvebTZMxvvFCLjWVOauloQSHwoZN /K4G5Kx7r1PGdbmys0VpHC66zQoFkLiDlTt/Gj1DSc4XEYW2qXo1FBYVQEVp6uKyTWMp 4V1Q== X-Gm-Message-State: AO0yUKUSsPi0AH+RiDWj+xes46j7nnIHGPUKSJAMaMnteEuss8VFgw9X ZB5a0IthXhAH58gGe/IoBuKQLoTXPvo= X-Google-Smtp-Source: AK7set9ZPyvVbr49WEQ05rUS/d1D44jZqN3pGk8Jvt+yqahYYZwwesjtcRN06RKkrqzVNuD+o5HQcw== X-Received: by 2002:a05:6e02:17c6:b0:310:bab8:34cf with SMTP id z6-20020a056e0217c600b00310bab834cfmr14260575ilu.19.1675097591505; Mon, 30 Jan 2023 08:53:11 -0800 (PST) Received: from washu-v4 (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id k4-20020a056e02156400b0030f3441de17sm4108393ilu.59.2023.01.30.08.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 08:53:10 -0800 (PST) From: Katherine Cox-Buday To: 60899@debbugs.gnu.org, Guix Devel Subject: Request for review of: [bug#60899] [PATCH 00/25] gnu: golang: Add gopls References: <20230118014510.19320-1-cox.katherine.e@gmail.com> Date: Mon, 30 Jan 2023 09:53:09 -0700 In-Reply-To: <20230118014510.19320-1-cox.katherine.e@gmail.com> (Katherine Cox-Buday's message of "Tue, 17 Jan 2023 18:44:45 -0700") Message-ID: <878rhkyney.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::12a; envelope-from=cox.katherine.e@gmail.com; helo=mail-il1-x12a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675097630; a=rsa-sha256; cv=none; b=ZeaPw7tX5I7Y/y9zYSqtxHYzxOPziNUg3m4WPfE87vS0CElkLH+81MGekrlcU33PCoVnNW sWfW1qwXPKsPh3y3BM+xWUS5OCmQDQL6eMCzb+i+lAjME9jVgMiCTXnC1nWlzACvPYQ+Yu /QomSy48wXvs5ldjaOZBjFPE4zUXQuk4oHR4r/TiJw0hnFVUMUpmrfYjDo0vcEj13FKrWK 5SEg2CREF4YPkQQW8Wnpegm1jd00t4jHrwWU/PGQ6b6T6WnYV2aMjiNYGGmQ3Hqyyviyos PoIjDEQXcVxqeCw1iVrGcikJ60B92pne/6xWXVi64xPM7GtGhn5GrJ6fL52Tww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qyP0FkWd; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675097630; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WbXo3TFSVR4wF+hVElztRysd0+Dlvl/ig1bgj6TiCMw=; b=GjtV4JuOwFwGu8l1JHrk9YgQeNDkBQwT6pqLn9mLAyVsB+BJWE4jVwaxxM/vINpXUJYI9Z xJ9kscOLqWUhn2KS+omTuzEiPmRT7yOyZBCK/x2+OUACi+jumn2rSx5EZuHigGLKtwT5yk X6o2YXeElbcSMo+dGxA7gYZ2+OlmxzGwKAEqczqBNgPevWfYkSqkYJWIB8ydp2KIBiKCFR rFIVFAvb0ddKu+9JtjalyM56VnvikpIZmbACUQ3FOGxI/a8bZP3Sg5DFGVH8NBlECTdEyR xFouJPJzl/mHreo1x1mWO1XtOs3HH2GTxS4afqyE+3x9vmX3cGlCVpUfjWHvyw== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qyP0FkWd; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.76 X-Spam-Score: -4.76 X-Migadu-Queue-Id: D96998C3D X-TUID: mt23TZgvZeNw Katherine Cox-Buday writes: > This is a patch series to add the gopls package. > > I haven't contributed to many projects which use the e-mail flow, so > hopefully I'm doing this correctly. Please feel free to make > suggestions if not! > > Some of the diffs are a little busier than I'd like for version bumps. > This is due to running `guix style` over everything. > > For all of the packages I have: > > . Run guix style > . Run guix lint > . Built 2x > . Checked that the change is in the correct branch > . Built all dependencies > . Built the repository > > Katherine Cox-Buday (25): > gnu: go-golang-org-x-sync: Update to 0.1.0-1.8fcdb60. > gnu: go-golang-org-x-mod: Update to 0.7.0. > gnu: Add go-golang-org-x-exp. > gnu: Add go-github-com-jba-printsrc. > gnu: Add go-github-com-google-safehtml. > gnu: Add go-github-com-jba-templatecheck. > gnu: go-github-com-google-go-cmp-cmp: Update to 0.5.9. > gnu: go-github-com-pkg-diff: Update to > 0.0.0-20210226163009-20ebb0f2a09e. > gnu: go-github-com-rogpeppe-go-internal: Update to 1.9.0. > gnu: gopkg-in-errgo-fmt-errors: Rename package to > go-gopkg-in-errgo-fmt-errors. > gnu: go-golang-org-x-tools: Update to 0.5.0. > gnu: Add xurls. > gnu: Add go-mvdan-cc-xurls. > gnu: Add misspell. > gnu: Add go-github-com-client9-misspell. > gnu: Add go-github-com-google-go-cmdtest. > gnu: Add unparam. > gnu: Add go-mvdan-cc-unparam. > gnu: Add govulncheck. > gnu: Add go-golang-org-x-vuln. > gnu: go-github-com-burntsushi-toml: Update to 1.2.1. > gnu: go-honnef-co-go-tools: Update to 0.3.3. > gnu: Add gofumpt. > gnu: Add go-mvdan-cc-gofumpt. > gnu: Add gopls. > > gnu/packages/configuration-management.scm | 2 +- > gnu/packages/golang.scm | 695 ++++++++++++++++++---- > 2 files changed, 578 insertions(+), 119 deletions(-) > > > base-commit: 5c921977179489caef4a9e54ada6696fc86d2f0b Hello Guix! Acknowledging that everyone are volunteers, and busy (guilty myself), this is a humble request for a review of this patch-series I made two weeks ago so that it doesn't bit-rot. I have a `gopls` home service[1] waiting to be proposed after this patch-series is merged. Thank you very much! [1] https://github.com/kat-co/guix-channels/blob/upstream-staging/upstream/home/services/gopls.scm P.S. I think I am following etiquette for review reminders (i.e. waiting long enough, bringing this over to guix-devel), but I was having trouble finding examples. If I haven't waited long enough, or have reminded in the wrong way, please give me feedback. -- Katherine