From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GN7ICZ1K7mMOtgAAbAwnHQ (envelope-from ) for ; Thu, 16 Feb 2023 16:24:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IKK2CZ1K7mOUbQEA9RJhRA (envelope-from ) for ; Thu, 16 Feb 2023 16:24:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CDD0C1496D for ; Thu, 16 Feb 2023 16:24:12 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSg7C-0004sE-5G; Thu, 16 Feb 2023 10:24:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSg78-0004qU-PF for guix-patches@gnu.org; Thu, 16 Feb 2023 10:24:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSg78-0004Z5-GL for guix-patches@gnu.org; Thu, 16 Feb 2023 10:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSg78-0006yD-CV for guix-patches@gnu.org; Thu, 16 Feb 2023 10:24:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61255] [PATCH 0/5] Add support for the RPM format to "guix pack" Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Feb 2023 15:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61255 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 61255@debbugs.gnu.org Received: via spool by 61255-submit@debbugs.gnu.org id=B61255.167656098826729 (code B ref 61255); Thu, 16 Feb 2023 15:24:02 +0000 Received: (at 61255) by debbugs.gnu.org; 16 Feb 2023 15:23:08 +0000 Received: from localhost ([127.0.0.1]:37314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSg6F-0006x3-VR for submit@debbugs.gnu.org; Thu, 16 Feb 2023 10:23:08 -0500 Received: from mail-qt1-f173.google.com ([209.85.160.173]:45934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSg6E-0006wM-4D for 61255@debbugs.gnu.org; Thu, 16 Feb 2023 10:23:06 -0500 Received: by mail-qt1-f173.google.com with SMTP id h24so2436695qta.12 for <61255@debbugs.gnu.org>; Thu, 16 Feb 2023 07:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=8OtE0PF+azT8eiWPfFpkBfwA67RManM63QL7zfenerQ=; b=ceQhhZc6hgkWs5xFytMGthKEQXJxEO/gTYvyaBjbqNxHLoSnIrPpmgnflutyhrxPeN 1fQFFBnTKnfFGaNAdEgNFWm62l3SSiAzHe6Kj+4l7CLu6cCQbTZUxLCwmr1nwzJvNjD2 W5fui6xEVVpSSCW09iqWKeSzItCSOkxckCyOywI5mn7OYj/OA9L3aqgZIIlCvojlZlKl bnOULfAxJZULsJ02q2EuDAeLJhjaJlV+F326d6PILkCB8mtSMpY7FS3lsUrYYp623nvt vrrsf1YwOLKTX9As8s+aVYB6LT9lwdTOpJ/tNcGQft5PX+ChUcbxg95+AQ/MXvVcO/iN M/Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8OtE0PF+azT8eiWPfFpkBfwA67RManM63QL7zfenerQ=; b=wMVjcEKNygvEeRkP0GfM874wt9vLdOlYIkqQ8Tvr0L0p1YJUeYBGwrcnb848izsEtK SJ1VcA9nG6djWXPy+rl6Yg7oPM4Nhljx20fC6/L58EYz4yyyaSDgKLaOEdbdERGqGa+R GV/FDADPZAAo2GtwkUhfi3tISxqy0Of/w0KDy2sMrm+E2oqyrld79hwJep8hwe5ei7QN IGcnaH+1PAW0uojnTnHIcmtLN836pDrMygEGNRvizV9QhITudBj1HwDxjomxIoKJ+AjO cx3jfKLFgZOCzXmKZO+ZHfyedx6zwLmXAwn4Z4Z4IeytUokkYGmKRKP0pkzwroUEYs/R IhMA== X-Gm-Message-State: AO0yUKWUfFu6wM/f97F5lgFaPvgcJpTGkUje/apfe0TkubFnEyIMTSea 6aFPEm/x2Mn89ySkHGq/NTBZGQFlNVkE6PBz X-Google-Smtp-Source: AK7set+n1HqHsZAUzkIUerMcRcnqT1cL7aKtnM0rIy9EZcTCWuFcL3BhsA+zcyZEZOIdwMcjMPb0eQ== X-Received: by 2002:a05:622a:1011:b0:3b9:b98b:3c56 with SMTP id d17-20020a05622a101100b003b9b98b3c56mr9960478qte.68.1676560980224; Thu, 16 Feb 2023 07:23:00 -0800 (PST) Received: from hurd (dsl-152-188.b2b2c.ca. [66.158.152.188]) by smtp.gmail.com with ESMTPSA id o7-20020a05622a008700b003b62e8b77e7sm1406453qtw.68.2023.02.16.07.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 07:22:59 -0800 (PST) From: Maxim Cournoyer References: <20230203221409.15886-2-maxim.cournoyer@gmail.com> <20230203221409.15886-5-maxim.cournoyer@gmail.com> <87357alp9n.fsf_-_@gnu.org> Date: Thu, 16 Feb 2023 10:22:58 -0500 In-Reply-To: <87357alp9n.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 12 Feb 2023 19:20:04 +0100") Message-ID: <878rgxws6l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676561052; a=rsa-sha256; cv=none; b=ODEJ/pBAf/U4CaowFuHheLAJP/1Khiee2C4MU6Ux4VUVBM0DlkA6BjE/G0FdtwFggKPGsR 9e7i/km8NhKnH/2uIEEWv3WqQpn+0PaLJKC8aWnIPaOfo9PFfIQl+e6/jJQjTX72uQeIoT tU3taVXbV1HfpWFA8/j0N9ntugaKJObfgz2IMgZSCQZpinGumZ4UawsfSaLDcxTqPd16J3 Mh275yuct2ecdvZEQ/ysJua10oND5rBGBjsYkqGAQSTJqXGKYVTK2QxYz5OqzLLejFN3y6 jfFx6D8qUvtfFRbDzqySwhZQLZl8EPdGdlEK03Jw7ZH28rIJex2w7nP2UQ4gPw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=ceQhhZc6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676561052; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=8OtE0PF+azT8eiWPfFpkBfwA67RManM63QL7zfenerQ=; b=ddQiyzKdj92U+RjxSbdMJOVTAtS+N4qArT4fzRTzy0amVHc3PG4p3jCQRsj1aBkBDHPO/M 0wjHxv3IdD/LK1KS0oPdhqjCPDyaaAJ2VhGsIxy0bcZa10RXeFoKkGtd7a2TULXH9GbsP9 cEnNLTfjWXRrzE+Ax3vuoo3hWuYj0Tltyfpc0U5i4R5USobrYaPipdLBbYRE+wt4FW5Zot O0tCM6qEOR+GaCFcAMp0EnZWFAXUh6c76KgJCsQtNzcwkMy6qHTk49zvNoGq9D0e6Xb6AS TxhARMa/TZNsWv01KWg6PdjzTKg00SbaSSkS24Iwp6XUWSoZ+TR5pTMqP8JdQw== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=ceQhhZc6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: -0.52 X-Spam-Score: -0.52 X-Migadu-Queue-Id: CDD0C1496D X-Migadu-Scanner: scn1.migadu.com X-TUID: 1N+tB1GfBrwV Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> * tests/pack.scm: Fix indentation. > > [...] > >> (check (gexp->derivation >> - "check-tarball" >> - (with-imported-modules '((guix build utils)) > > [...] > >> + "check-tarball" >> + (with-imported-modules '((guix build utils)) > > I=E2=80=99m not convinced by the indentation rule for =E2=80=98gexp->deri= vation=E2=80=99 added > in 82daab42811a2e3c7684ebdf12af75ff0fa67b99: there=E2=80=99s no reason to= treat > =E2=80=98gexp->derivation=E2=80=99 differently from other procedures. The benefit I saw was that writing --8<---------------cut here---------------start------------->8--- (gexp->derivation the-name #~(begin (the (multi-line (gexp))))) --8<---------------cut here---------------end--------------->8--- Seemed most readable/natural. I saw some code in our code base was already indented that way, but Emacs wasn't happy about it then. > What about removing that rule from =E2=80=98.dir-locals.el=E2=80=99 and k= eeping > =E2=80=98tests/pack.scm=E2=80=99 unchanged? I don't feel too strongly about it, but I thought being able to indent as above was neater than having to drop the-name on the second like, or have it indented like under: --8<---------------cut here---------------start------------->8--- (gexp->derivation the-name #~(begin (the (multi-line (gexp))))) --8<---------------cut here---------------end--------------->8--- > (Also not sure about the =E2=80=98computed-file=E2=80=99 rule. For all t= hese things, > we=E2=80=99ll want to keep Emacs and (guix read-print) in sync, too.) Ah! Thanks for pointing that out. I can address this separately. It'd be nice if (guix read-print) understood the rules under .dir-locals.el :-). --=20 Thanks, Maxim