* [bug#61560] [Guix Data Service] Comparing package derivations: Fix inconsistent verbage.
@ 2023-02-16 22:26 Leo Famulari
2023-02-17 17:11 ` bug#61560: " Christopher Baines
0 siblings, 1 reply; 2+ messages in thread
From: Leo Famulari @ 2023-02-16 22:26 UTC (permalink / raw)
To: 61560
Harmonize "Build change" options between the selection menu and the documentation
I don't have a preference about which phrase is chosen. Please use your
judgement in fixing this to ensure consistency throughout the user interface.
* guix-data-service/web/compare/html.scm (compare/package-derivations): Replace
"Still broken" with "Still failing" in the "Build change" help text.
---
guix-data-service/web/compare/html.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guix-data-service/web/compare/html.scm b/guix-data-service/web/compare/html.scm
index 58fb514..44acb81 100644
--- a/guix-data-service/web/compare/html.scm
+++ b/guix-data-service/web/compare/html.scm
@@ -797,7 +797,7 @@ derivation")
(dd
"At least one successful build for both the base
and target derivations")
- (dt "Still broken")
+ (dt "Still failing")
(dd
"No successful builds and at least one failed builds for both the base and target derivations")
(dt "Unknown")
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#61560: [Guix Data Service] Comparing package derivations: Fix inconsistent verbage.
2023-02-16 22:26 [bug#61560] [Guix Data Service] Comparing package derivations: Fix inconsistent verbage Leo Famulari
@ 2023-02-17 17:11 ` Christopher Baines
0 siblings, 0 replies; 2+ messages in thread
From: Christopher Baines @ 2023-02-17 17:11 UTC (permalink / raw)
To: Leo Famulari; +Cc: 61560-done, guix-patches
[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]
Leo Famulari <leo@famulari.name> writes:
> Harmonize "Build change" options between the selection menu and the documentation
>
> I don't have a preference about which phrase is chosen. Please use your
> judgement in fixing this to ensure consistency throughout the user interface.
>
> * guix-data-service/web/compare/html.scm (compare/package-derivations): Replace
> "Still broken" with "Still failing" in the "Build change" help text.
> ---
> guix-data-service/web/compare/html.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix-data-service/web/compare/html.scm b/guix-data-service/web/compare/html.scm
> index 58fb514..44acb81 100644
> --- a/guix-data-service/web/compare/html.scm
> +++ b/guix-data-service/web/compare/html.scm
> @@ -797,7 +797,7 @@ derivation")
> (dd
> "At least one successful build for both the base
> and target derivations")
> - (dt "Still broken")
> + (dt "Still failing")
> (dd
> "No successful builds and at least one failed builds for both the base and target derivations")
> (dt "Unknown")
Looks good to me, I've pushed this now.
Thanks,
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-17 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-16 22:26 [bug#61560] [Guix Data Service] Comparing package derivations: Fix inconsistent verbage Leo Famulari
2023-02-17 17:11 ` bug#61560: " Christopher Baines
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.