From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +BGVFYoPBmQSegAASxT56A (envelope-from ) for ; Mon, 06 Mar 2023 17:06:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oDGgFYoPBmQQRwEAauVa8A (envelope-from ) for ; Mon, 06 Mar 2023 17:06:34 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 29C4A3ECD0 for ; Mon, 6 Mar 2023 17:06:34 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZDLz-0004Xa-DJ; Mon, 06 Mar 2023 11:06:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZDLe-0004PM-AB for guix-patches@gnu.org; Mon, 06 Mar 2023 11:06:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZDLd-0008A1-Sc for guix-patches@gnu.org; Mon, 06 Mar 2023 11:06:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZDLd-0004bC-OE for guix-patches@gnu.org; Mon, 06 Mar 2023 11:06:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61789] =?UTF-8?Q?=E2=80=98tor-hidden-service=E2=80=99?= deprecation Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Mar 2023 16:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61789 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 61789@debbugs.gnu.org Received: via spool by 61789-submit@debbugs.gnu.org id=B61789.167811871517604 (code B ref 61789); Mon, 06 Mar 2023 16:06:01 +0000 Received: (at 61789) by debbugs.gnu.org; 6 Mar 2023 16:05:15 +0000 Received: from localhost ([127.0.0.1]:43417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZDKs-0004Zr-Ne for submit@debbugs.gnu.org; Mon, 06 Mar 2023 11:05:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZDKr-0004ZX-Km for 61789@debbugs.gnu.org; Mon, 06 Mar 2023 11:05:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZDKl-0007zB-22; Mon, 06 Mar 2023 11:05:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=/BA866rcb9sdYPkVPmxYM7F2PDGl6amoW+DzESS70Z0=; b=FYS8rJDjtCqsN+QXNGqP SaJQyiGyDBN2ctKIJioTFI7EVi4/VNgz38eFAulk+AqfqeWobWoYSzGYMhRXmwwmKuCx2cxpC4Dn3 8fMFbu2EgRq0bU3f1HtZYA/hebbYoIpevINR9j7ZcUgUwVZ+FdFrxY24Y3DIGAknEVvcm06A8unDh ocbkzFmnMVdsgbFOwaJQUJHQxa6LRQSZwW+H6/oR4/7QwaYSZFV64jlSEXosXgOxLzL574L20cQtA 1lS/U447QCw49VWhN4m+BaJ2OzHZT9iB14jlCPhVQbl7rvHtVYC0sSH66G2t0yApSHPjOl2bqTYQp pVowgiXaF99IJw==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZDKk-0006gi-Hv; Mon, 06 Mar 2023 11:05:06 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <55d9d97eabbb72cf59713b31015e654d028d8623.1677350249.git.mirai@makinata.eu> <87mt4tvl9i.fsf_-_@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Sextidi 16 =?UTF-8?Q?Vent=C3=B4se?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour de =?UTF-8?Q?l'=C3=89pinard?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 06 Mar 2023 17:05:04 +0100 In-Reply-To: (Bruno Victal's message of "Sun, 5 Mar 2023 17:51:04 +0000") Message-ID: <878rg9amrz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-TUID: /LQapcM/P2r9 HI, Bruno Victal skribis: > I think it's difficult to split this one into meaningful patches, reason = being that > 'tor-hidden-service-type' can't be used alone since the record constructo= r for a > Tor hidden service (hidden-service, which is IMO a "collision prone" name= ) is not exported. > > The fact that it isn't exported also means that the 'hidden-services fiel= d from > was impossible to configure. Extending 'tor-service-type' was also imposs= ible save for the > (to be deprecated) 'tor-hidden-service' procedure which provisions a 'tor= -hidden-service-type' > that is simply a service extension for 'tor-service-type'. > > The 'tor-hidden-service' and 'tor-hidden-service-type' are extremely misl= eading to what will > happen behind the scenes should more than one hidden-service be provision= ed (with 'tor-hidden-service'). > Since it does so via a 'tor-hidden-service-type' which has its own name, = only one of the hidden-services > will get configured, which one =3D dice roll. > > IMO this 'tor-hidden-service-type' shouldn't exist at all and tor-hidden-= service can safely be > converted into a simple-service that extends tor-service-type. Hmm, can we still open a separate issue for it? :-) I can=E2=80=99t really make up my mind right now. I think =E2=80=98tor-hidden-service-type=E2=80=99 brings a bit of clarity compared = to =E2=80=98simple-service=E2=80=99, for instance when looking at =E2=80=98gui= x system extension-graph=E2=80=99. Then there=E2=80=99s the other issue that upstream calls this =E2=80=9Conio= n services=E2=80=9D these days, so we should also change that. Thanks, Ludo=E2=80=99.