Re: 09/09: lint: Append "/info/refs" to git-reference-url.

Re: 09/09: lint: Append "/info/refs" to git-reference-url.

[Maxim Cournoyer]

Hello,

guix-commits@gnu.org writes:

> civodul pushed a commit to branch master
> in repository guix.
>
> commit c9af27d4ca733b20f09019f1465d3e5fdc1ec724
> Author: Felix Lechner <felix.lechner@lease-up.com>
> AuthorDate: Mon Mar 20 21:25:41 2023 -0700
>
>     lint: Append "/info/refs" to git-reference-url.
>     
>     For the atftp package added in the preceeding commit, lint produced this
>     warning:

After this fix, I'm now seeing warnings from Github, e.g.:

--8<---------------cut here---------------start------------->8---
gnu/packages/rails.scm:675:2: ruby-activejob@7.0.4.3: scheduled Software Heritage archival
gnu/packages/rails.scm:282:2: ruby-activemodel@7.0.4.3: URI https://github.com/rails/rails/info/refs not reachable: 403 ("Forbidden")
gnu/packages/rails.scm:282:2: ruby-activemodel@7.0.4.3: scheduled Software Heritage archival
gnu/packages/rails.scm:309:2: ruby-activerecord@7.0.4.3: URI https://github.com/rails/rails/info/refs not reachable: 403 ("Forbidden")
gnu/packages/rails.scm:309:2: ruby-activerecord@7.0.4.3: Software Heritage rate limit reached; try again later
gnu/packages/rails.scm:714:2: ruby-activestorage@7.0.4.3: URI https://github.com/rails/rails/info/refs not reachable: 403 ("Forbidden")
gnu/packages/rails.scm:52:2: ruby-activesupport@7.0.4.3: URI https://github.com/rails/rails/info/refs not reachable: 403 ("Forbidden")
gnu/packages/rails.scm:837:2: ruby-ammeter@1.1.5: source not archived on Software Heritage and missing from the Disarchive database
gnu/packages/ruby.scm:6134:12: ruby-arr-pm@0.0.12: source not archived on Software Heritage and missing from the Disarchive database
gnu/packages/ruby.scm:9336:12: ruby-aruba@2.1.0: URI https://github.com/cucumber/aruba/info/refs not reachable: 403 ("Forbidden")
gnu/packages/rails.scm:235:12: ruby-autoprefixer-rails@10.4.13.0: URI https://github.com/ai/autoprefixer-rails/info/refs not reachable: 403 ("Forbidden")
gnu/packages/ruby.scm:3995:12: ruby-bake@0.18.2: URI https://github.com/ioquatix/bake/info/refs not reachable: 403 ("Forbidden")
--8<---------------cut here---------------end--------------->8---

I've reverted it for now.

-- 
Thanks,
Maxim

Re: 09/09: lint: Append "/info/refs" to git-reference-url.

[Sergey Trofimov]

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hello,
>
> guix-commits@gnu.org writes:
>
>>     lint: Append "/info/refs" to git-reference-url.
>>
> After this fix, I'm now seeing warnings from Github, e.g.:
>
> gnu/packages/rails.scm:675:2: ruby-activejob@7.0.4.3: scheduled 
> Software Heritage archival
> gnu/packages/rails.scm:282:2: ruby-activemodel@7.0.4.3: URI 
> https://github.com/rails/rails/info/refs not reachable: 403 
> ("Forbidden")


It seems that the `service=git-upload-pack` is important as it 
switches the protocol to "smart-http".

--8<---------------cut here---------------start------------->8---
~/devel/ext λ curl 
'https://github.com/sarg/dotfiles/info/refs?service=git-upload-pack'
001e# service=git-upload-pack
Warning: Binary output can mess up your terminal. Use "--output -" 
to tell
Warning: curl to output it to your terminal anyway, or consider 
"--output
Warning: <FILE>" to save to a file.
0000

~/devel/ext λ curl 'https://github.com/sarg/dotfiles/info/refs'
Please upgrade your git client.
GitHub.com no longer supports git over dumb-http: 
https://github.com/blog/809-git-dumb-http-transport-to-be-turned-off-in-90-days
--8<---------------cut here---------------end--------------->8---

Maybe the linter should just use `git ls-remote` instead of 
guessing the url?
--8<---------------cut here---------------start------------->8---
~/devel/ext λ git ls-remote https://github.com/sarg/dotfiles
7707f77e8d9c11b5435c5901eca45be1a72d2054	HEAD
7707f77e8d9c11b5435c5901eca45be1a72d2054	refs/heads/master
--8<---------------cut here---------------end--------------->8---

Re: 09/09: lint: Append "/info/refs" to git-reference-url.

[Maxim Cournoyer]

Hi Sergey,

Sergey Trofimov <sarg@sarg.org.ru> writes:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> Hello,
>>
>> guix-commits@gnu.org writes:
>>
>>>     lint: Append "/info/refs" to git-reference-url.
>>>
>> After this fix, I'm now seeing warnings from Github, e.g.:
>>
>> gnu/packages/rails.scm:675:2: ruby-activejob@7.0.4.3: scheduled 
>> Software Heritage archival
>> gnu/packages/rails.scm:282:2: ruby-activemodel@7.0.4.3: URI 
>> https://github.com/rails/rails/info/refs not reachable: 403 
>> ("Forbidden")
>
>
> It seems that the `service=git-upload-pack` is important as it 
> switches the protocol to "smart-http".
>
> ~/devel/ext λ curl 
> 'https://github.com/sarg/dotfiles/info/refs?service=git-upload-pack'
> 001e# service=git-upload-pack
> Warning: Binary output can mess up your terminal. Use "--output -" 
> to tell
> Warning: curl to output it to your terminal anyway, or consider 
> "--output
> Warning: <FILE>" to save to a file.
> 0000
>
> ~/devel/ext λ curl 'https://github.com/sarg/dotfiles/info/refs'
> Please upgrade your git client.
> GitHub.com no longer supports git over dumb-http: 
> https://github.com/blog/809-git-dumb-http-transport-to-be-turned-off-in-90-days
>
>
> Maybe the linter should just use `git ls-remote` instead of 
> guessing the url?
>
> ~/devel/ext λ git ls-remote https://github.com/sarg/dotfiles
> 7707f77e8d9c11b5435c5901eca45be1a72d2054	HEAD
> 7707f77e8d9c11b5435c5901eca45be1a72d2054	refs/heads/master

That sounds like a better way to me!

-- 
Thanks,
Maxim