From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OOPJOIFLTWSfHQAASxT56A (envelope-from ) for ; Sat, 29 Apr 2023 18:53:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 8HK6N4FLTWT1tgAAG6o9tA (envelope-from ) for ; Sat, 29 Apr 2023 18:53:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7EA8F2F404 for ; Sat, 29 Apr 2023 18:53:21 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1psnom-0003mY-26; Sat, 29 Apr 2023 12:53:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psnol-0003lF-FO for bug-guix@gnu.org; Sat, 29 Apr 2023 12:53:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1psnol-0005xI-6d for bug-guix@gnu.org; Sat, 29 Apr 2023 12:53:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1psnok-0007ax-2T for bug-guix@gnu.org; Sat, 29 Apr 2023 12:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63082: [PATCH 09/17] services: mpd: Let Shepherd effect the user/group change. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 29 Apr 2023 16:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Bruno Victal Cc: 63082@debbugs.gnu.org Received: via spool by 63082-submit@debbugs.gnu.org id=B63082.168278713829142 (code B ref 63082); Sat, 29 Apr 2023 16:53:02 +0000 Received: (at 63082) by debbugs.gnu.org; 29 Apr 2023 16:52:18 +0000 Received: from localhost ([127.0.0.1]:36438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psno2-0007Zy-E4 for submit@debbugs.gnu.org; Sat, 29 Apr 2023 12:52:18 -0400 Received: from mail-qk1-f174.google.com ([209.85.222.174]:54478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psno0-0007Zh-7n for 63082@debbugs.gnu.org; Sat, 29 Apr 2023 12:52:17 -0400 Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-74da25049e0so83467985a.0 for <63082@debbugs.gnu.org>; Sat, 29 Apr 2023 09:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682787130; x=1685379130; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=sV/kZSpYRziYZwpOLrQ53rogXLYjkYAZ/8COzEIyzBc=; b=Xd5ycAJCn9bp8DZ/n0B23iyN4uLvwK84zv8I1ZucgdstqQQwfi+586OpfO9t4D4bTp IkxCl7tv9kAUM3cCTMEXrmoV7hkNUYAoUxMeZdJhzsFekPlD7OT3mnaTh+n0HcrZFa+0 6M4VnDxhdvW/2y5CLm3Kgf4RSitx0kFvPPyj5/wJuX1qdjQIh6AJOlWpYTav/NzbzoSP IA9mp9n8vOWcor4lWp5oClh/hsrbryPYuhNjvn4vAI3YOSRgC9aflwJ7Bek5rw/CBVFS Zea5jvbADVfi0+hX5skvRBvlEoonMY4ys/woJpQ3Wy5rGAUqdHHotO5VKHLPjlyBTx2H QalQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682787130; x=1685379130; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sV/kZSpYRziYZwpOLrQ53rogXLYjkYAZ/8COzEIyzBc=; b=G3hveGKOH6jRfkeJia0Fqu/laSwMShGSVIYku3bCkTgPVO7Xk6HXcNmU7v1S/o0q80 ueo/dP61IOpb/v0dbZ/aRZdVmwH+BdHxMdRVuewB9SxId2yL2dtysYHz7vDU+QDLwlxy RuJ6oUacDDAbmz4vlVImUIrXpFB2SCH0vFjg3yZVMJzRf5p7+ILNFXG0KElSbJCV2rKn VmjvRcYHpmAlbvoo6WbgZdDk71Tqg8xOC2SSU94fkkSExlELm/IwFlZoFrOT5TMPdpDU 5+6B2zBeGHEze8paZweAnczy+M8ZIZhbntvE5h4mpr81NEUsmG7WAffIy5W0KErqRdNV dd/A== X-Gm-Message-State: AC+VfDxk+Q08Cao0oReNTklwgyRD70NYMEjOWMKdUPOYwvmbnqCu/t+0 PUTI6N7vnEaPc6bFbBfANAs6BW2XL7I= X-Google-Smtp-Source: ACHHUZ4PWuCYP92T50cdvhVk5LEv8ukIYPwLzYJi0GjLApk+GsR1uoWXNg0DNsf2y5cEekz+xVXeVA== X-Received: by 2002:a05:6214:d4e:b0:5ef:56e4:f629 with SMTP id 14-20020a0562140d4e00b005ef56e4f629mr16091151qvr.38.1682787129850; Sat, 29 Apr 2023 09:52:09 -0700 (PDT) Received: from hurd (dsl-155-245.b2b2c.ca. [66.158.155.245]) by smtp.gmail.com with ESMTPSA id bq16-20020a05620a469000b0074e020ff0edsm7577641qkb.48.2023.04.29.09.52.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Apr 2023 09:52:09 -0700 (PDT) From: Maxim Cournoyer References: <70d3c80ef59f9519a69218c504e72c4c836a6ab1.1682690696.git.maxim.cournoyer@gmail.com> Date: Sat, 29 Apr 2023 12:52:08 -0400 In-Reply-To: (Bruno Victal's message of "Fri, 28 Apr 2023 23:11:27 +0100") Message-ID: <878reaaax3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682787201; a=rsa-sha256; cv=none; b=LTV6MeVUT/9qn72dFgirz9nr/qVyd3hUitj9sBt20V8S8VL0bHB4/YGAVqFKtoXln3V/+F OAb0+mfAxc04R9SbNzfazdoVAnnyRhr0N5D2GHM4hv/xh27R/oMdCCtxMdVm0we5Jw9jfZ 6dntToD1ONXwFoTUxJK7Od+gEgbAFUD/Y+6UpuzFjMtOpQyOuupSzZwn+X9C16u1wUl2pH vxurMl6dFs7wq9iLjupWOy7+sJSMs48Pch8GH1tk1Um5wHsEHbtwuGkuzmVtaTF51D4edM qKAuF9CHmh+DrIOKDloKgaK1jfQjGYFrdEhNON0cIZumJ0aqWgXRZhXB2Znzfw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=Xd5ycAJC; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682787201; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=sV/kZSpYRziYZwpOLrQ53rogXLYjkYAZ/8COzEIyzBc=; b=PB4NCW3oFjNyeBIJW+pmnsvrmoQK2px9oxNeAWkTX2bW9jSoolbL21ZXMzJxEHT7mqeN9a lcs6WR8oDNQEq5aIojF48LB49cuJ/n/r6hOnFNpjjVaCWrbi1eh9Bqo1L6Lf99k7uuXe9a pYMxLn6gnQGwUEh4D9eTwVnPh5CB6IYTT7Ki+chU8WxeC88mys+0BJN8id1SJHhkzqUoU8 xIMF/rmRNtgRIyPCP0V58d+Qs0KHUTZNyoiXvWozOFqUgiOg5G6NYMqDoCQv93IrdQ/p98 PsizrB2fbMTJQxlYlS/Hg0Pq7yS4fU8Hv4nScWGzztyR0BRwoa1Gch0Y/hnOGQ== X-Migadu-Spam-Score: -1.40 X-Spam-Score: -1.40 X-Migadu-Queue-Id: 7EA8F2F404 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=Xd5ycAJC; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: w1QRt1Qn2uhh Hi Bruno, Bruno Victal writes: [...] >> + ;; Note: The user and its group are not serialized, otherwise MPD would >> + ;; attempt to switch the user/group itself. The task of switching the >> + ;; user/group is left to Shepherd instead. >> (user >> (user-account %mpd-user) >> - "The user to run mpd as." >> - (sanitizer mpd-user-sanitizer)) >> + "The user to run @command{mpd} as." >> + (sanitizer mpd-user-sanitizer) >> + (serializer empty-serializer)) > > Simply write empty-serializer after sanitizer instead. Done, and for other commits too, though both works and the procedure version appeared more consistent/readable to my eyes. >> "--cachedir" #$cache-directory) >> #:environment-variables (list #$log-level*) >> - #:log-file #$(if (string? log-to) log-to #f)))) >> + #:log-file #$(if (string? log-to) log-to #f) > > Generic advice but how about this instead? > > #$@(if (string? log-to) `(#:log-file ,log-to) '()) > > It's cleaner to not explicitly set the keyword argument values when they're not used. They are used, but set to #f :-). I have a slight preference for the current version, which I find more readable. -- Thanks, Maxim