From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iLGWL0eV8mSDngAAG6o9tA:P1 (envelope-from ) for ; Sat, 02 Sep 2023 03:52:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iLGWL0eV8mSDngAAG6o9tA (envelope-from ) for ; Sat, 02 Sep 2023 03:52:07 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 791A66A640 for ; Sat, 2 Sep 2023 03:52:07 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=O0yODmj3; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693619527; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hs16p7bupR1AJy86tfC0VSjs0/3MtHJzvpOYmiRL0yE=; b=PVkaHX6YcFFcxrmWGKfMTUazYjQqVnho264i+vglP3r5E82RUQqSNp3nW7/Gp3NU0kKfBC XLyIT75qW3jqE+RPN29jRn1ZzeomT316Y2xJh+d7981ewckIWkIN5UREleOhIz0PsnuDSw 4SghdHutPNOFgbGtjQ8X5J9vJWgVRzQTNUQbMk8szg9RMr5P1bOzTgYoU36rfsbvpqx0Ym LW3WEY2aXvlxK36k6dsX48+ValA6ymKjqnDwl0ShT/n0NjD8rG5GnS+OD+3F2vcFPtUPiv 59XlKGBVTAVAjCZxD2I3betipVz8Mxu4jYqhWZCFKEAxgPp5vWFMPQ+TSnT/xg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=O0yODmj3; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693619527; a=rsa-sha256; cv=none; b=HRnVwthMqIw6R0gN85E7YT6Q19DNsnhaSTq2OhHjQDMm2pSCNn52/JQFsIE6DPOA/mk7Fw 8Q0tG18dfHm1qNUidLQirUjGrrJaswg1hVxEdDys5Rs9gVrPsr+ZBqVOrBOIcfqeFTHV+j PCs8Rw0fky3r5WlPtdobK51XDrvre2gZGMjupwiM5OltFD+Yr3hPd3Wuro60kKpM+31jXd ZLXC6kJ33el2J/FTif716bghlNyiUlnD8+pM40IavOFwdk7d20l5zIF7IA1+KUA0l2nGKX 8JE9Ju8Iz5lfWga6cGA7WgGoxY50iSg8wnAy2zo5DJT4ZUEvAA4L9CIouJfgRg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcFnm-0005ZE-EP; Fri, 01 Sep 2023 21:51:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcFnk-0005VY-Mx for guix-patches@gnu.org; Fri, 01 Sep 2023 21:51:52 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcFnk-0000FJ-Eq for guix-patches@gnu.org; Fri, 01 Sep 2023 21:51:52 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcFnt-0001QS-Sy for guix-patches@gnu.org; Fri, 01 Sep 2023 21:52:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65668] [PATCH] gnu: gst-plugins-bad: Remove the svt-hevc input. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 Sep 2023 01:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65668 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: Raghav Gururajan , 65668@debbugs.gnu.org Received: via spool by 65668-submit@debbugs.gnu.org id=B65668.16936194985437 (code B ref 65668); Sat, 02 Sep 2023 01:52:01 +0000 Received: (at 65668) by debbugs.gnu.org; 2 Sep 2023 01:51:38 +0000 Received: from localhost ([127.0.0.1]:34596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcFnV-0001PD-Gg for submit@debbugs.gnu.org; Fri, 01 Sep 2023 21:51:37 -0400 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]:41984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcFnF-0001OH-KF for 65668@debbugs.gnu.org; Fri, 01 Sep 2023 21:51:35 -0400 Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-76dbe263c68so28743085a.0 for <65668@debbugs.gnu.org>; Fri, 01 Sep 2023 18:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693619466; x=1694224266; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=hs16p7bupR1AJy86tfC0VSjs0/3MtHJzvpOYmiRL0yE=; b=O0yODmj3IDEbQpmrSRdhtRXWwRIGSplhEeDdecztNh4Og8bcbSdWJFu9Q67BNTIM4t canNDc+0+qZx2Lc8BXg0556wuimgvjlqzLeB+SnheU6bPi8anpKsrg78FMFpt6xxpBZa J6T920a5MQsZ8beKaA9JvNt3Lz85Qh+tubfRp+43e3nmnNDXdzvxdRCcHUOWVJe7wwEG KdVGDSF0eSLP/ZR2chA2XeEsPhD2sX6lDKdOG2K8vFPKCcx/fGJrmuvoUT+AZOHOx/qt DB12f/ykSnXUBFIC42HNkYYV5M3y8lpQvvJkpPE4VUHfklGKyBuSGfkWZrMHZ9Vbw5Jl 1LeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693619466; x=1694224266; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hs16p7bupR1AJy86tfC0VSjs0/3MtHJzvpOYmiRL0yE=; b=Nxa6VtH52EfOU+gM/XehGTAn7mjms9402RaSm0sqEZnrY9whkNoJHyfKyvpSxYZTx/ QTx58LOLD9lerLWhWY5zDqE30a21liX522Y+8GO1ojYf1sSLIh4z2j97yGaU564Ravyu gVV3HBZOmqqrI7Elzc/YRH511F3P/ZvU4nqxiJ+XjRZ+3AZGDztkVJXlvsIwteoA2K18 qBPr14fC/kA2M0/zX36md9nzuVKZX0/gx2UWOXExW80sfPuBRq+OkugzZ6pRtkCioxcr xFTYNIV+spAR75mOpGYyo8Ro8VwgJjKynnyxNXiCXTTLANfoSlE2ut3axbZezUl+FNH1 Dpmw== X-Gm-Message-State: AOJu0YydFM0baCnG+0Ulo9ovPcSDCik+jKDIY4txAJHp+iCuEdFIOSvN F/mbHjSuqjIq4h9fjl+gj/0= X-Google-Smtp-Source: AGHT+IHV2F9D8xtEwY6r0HvRg/JookjSKSSu4/B5GLl8jiFeRj+0cCr8IHbTdLJ+P9f6/oyvm4J1Ow== X-Received: by 2002:a05:620a:2911:b0:770:55f2:ec6c with SMTP id m17-20020a05620a291100b0077055f2ec6cmr4728217qkp.34.1693619466491; Fri, 01 Sep 2023 18:51:06 -0700 (PDT) Received: from hurd (dsl-154-228.b2b2c.ca. [66.158.154.228]) by smtp.gmail.com with ESMTPSA id j6-20020a05620a000600b0076f35d17d06sm1799632qki.69.2023.09.01.18.51.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Sep 2023 18:51:05 -0700 (PDT) From: Maxim Cournoyer References: <3e0b2b90b037404da7bf9be8932f9b0d69c1a39a.1693537692.git.maxim.cournoyer@gmail.com> <4fa4754ecb68e0e9d7bc72c44229bcc404a5525a.camel@gmail.com> Date: Fri, 01 Sep 2023 21:51:04 -0400 In-Reply-To: <4fa4754ecb68e0e9d7bc72c44229bcc404a5525a.camel@gmail.com> (Liliana Marie Prikler's message of "Fri, 01 Sep 2023 06:21:42 +0200") Message-ID: <878r9p1gxj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 4.27 X-Spam-Score: 4.27 X-Migadu-Queue-Id: 791A66A640 X-Migadu-Scanner: mx1.migadu.com X-TUID: 1ZX+F3KFHhFh Hi Liliana, Liliana Marie Prikler writes: > Am Donnerstag, dem 31.08.2023 um 23:08 -0400 schrieb Maxim Cournoyer: >> * gnu/packages/gstreamer.scm (gst-plugins-bad) >> [inputs]: Remove svt-hevc; add comment. >> --- >> =C2=A0gnu/packages/gstreamer.scm | 4 +++- >> =C2=A01 file changed, 3 insertions(+), 1 deletion(-) >>=20 >> diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm >> index 86886c025f..f38d2157bd 100644 >> --- a/gnu/packages/gstreamer.scm >> +++ b/gnu/packages/gstreamer.scm >> @@ -849,7 +849,9 @@ (define-public gst-plugins-bad >> =C2=A0=C2=A0=C2=A0=C2=A0 (inputs >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (append >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (if (target-x86?) (list mediasdk) '= ()) >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (if (target-x86-64?) (list svt-hevc) '()) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; Note: svt-hevc cannot be used, as it = would break the >> package for >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; older x86_64 CPUs such as Core 2 Duo = that lack AVX2 (see: >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; >> https://github.com/OpenVisualCloud/SVT-HEVC/issues/573#issuecomment-6806= 78144 >> ). >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (list bluez >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= bzip2 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= cairo > I think you should put that comment above the commented existing line > rather than deleting it outright. We should also look into building > svt-hevc without those CPU extensions; perhaps using tuning instead. It's not possible to build svt-hevc without those extensions: they are depended upon. Because it can't be used, I think it makes sense to not leave dead code (since it's not going to be resolved in the future and re-enabled). > The comment could itself be shortened to=C2=A0 > svt-hevc is broken on older x86_64 CPUs [such as=E2=80=A6] > see also > but you do you in terms of phrasing :) :-) I've moved things a bit. Is it a 'LGTM' from you? --=20 Thanks, Maxim