From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +F1BEyKDAWUrJAAAauVa8A:P1 (envelope-from ) for ; Wed, 13 Sep 2023 11:38:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id +F1BEyKDAWUrJAAAauVa8A (envelope-from ) for ; Wed, 13 Sep 2023 11:38:42 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1E8DC43222 for ; Wed, 13 Sep 2023 11:38:42 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694597922; a=rsa-sha256; cv=none; b=nRxLPmJkziIxsBKZGixPGaLECS3OuLKQFPFy4pJdMZQp1oJKHqbNpN2uCJ1oPIXWx9Onde hZZaauajTOMM9xGBVGDNsfIbYo+9suRRtop3Jwgk8wG0/xaHOnpQhbYxIGBemBgZ5FAbod QNZLOpfFFFW4m47HljzoKEbeP9ZD7XmevCb7v696mS3r12IkTsr32I+4PAoB8MaHXUSOJa dyFxE/7j8S283cGeeUmRXEqkJadbKzOZpvusdcUxNx1un6zEaYQKlIVRD0bv/4fL4FkbbN AG+wQQAnvD767Y5R4EhMAwTM81RjpNxWEKGPCp7z3s27j6LYijVu4seTvcfe9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694597922; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=QzZErz+c6NeWjtSJjy2BXVuF3zLjHKwByPpjoC+DvDk=; b=VVpsqzOjN7oXZ2k6iwXbfokm9GO91F/odBRD8ydWD93St9HfHVw0EcKw7/xXInAncLYC5n HRCHnRCEe68v7zhqYWeZ4GpsDttuXOw6P/pu3q3JEyM7iJa6zFeusGsQEs9nUcPvw4OKx4 2LtKqnq4AzBlZ16Mp9giAMpIWWHgQVO6BKGSVA2LWAHzMCoCxScExwev57eyo0yPg0wCdZ 7bhU7Ku9iSjZzvckl60d0GYkk5AKe/v+E+yD9FvUVhySBljgmnvjkLa6XwKt4EugqmNg2f j/tMy+pLiQMsXcfp1+omtx4EgPWLcjLRYuIPs5dG8Th64j0kxvrWPT6THIzOcg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgMJk-00068V-Jf; Wed, 13 Sep 2023 05:37:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgMJW-000640-LZ for guix-devel@gnu.org; Wed, 13 Sep 2023 05:37:38 -0400 Received: from ns13.heimat.it ([46.4.214.66]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgMJT-00054X-Lg; Wed, 13 Sep 2023 05:37:38 -0400 Received: from localhost (ip6-localhost [127.0.0.1]) by ns13.heimat.it (Postfix) with ESMTP id 81A4930098D; Wed, 13 Sep 2023 09:37:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at ns13.heimat.it Received: from ns13.heimat.it ([127.0.0.1]) by localhost (ns13.heimat.it [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zWTTtvmnCh07; Wed, 13 Sep 2023 09:37:29 +0000 (UTC) Received: from bourrache.mug.xelera.it (unknown [93.56.171.217]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ns13.heimat.it (Postfix) with ESMTPSA id 7E584300981; Wed, 13 Sep 2023 09:37:29 +0000 (UTC) Received: from roquette.mug.biscuolo.net (roquette [10.38.2.14]) by bourrache.mug.xelera.it (Postfix) with SMTP id 1FA8729BA7B7; Wed, 13 Sep 2023 11:37:29 +0200 (CEST) Received: (nullmailer pid 26935 invoked by uid 1000); Wed, 13 Sep 2023 09:37:28 -0000 From: Giovanni Biscuolo To: Liliana Marie Prikler , Maxim Cournoyer Cc: Vagrant Cascadian , guix-devel@gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [workflow] Automatically close bug report when a patch is committed In-Reply-To: <6929416953b2939445a5247b014142ea8bb521d9.camel@gmail.com> Organization: Xelera.eu References: <8734zrn1sc.fsf@xelera.eu> <87edjb5le5.fsf@gmail.com> <87jzt2feq6.fsf@xelera.eu> <87y1hikln6.fsf@wireframe> <2d93b48dfd381c55ff706394ff7226133f5e014a.camel@gmail.com> <87pm2pces0.fsf@xelera.eu> <87bke8wo96.fsf@gmail.com> <929b035f6f4aca0793d9f8a6454b673b2a7069c1.camel@gmail.com> <87zg1sv3vt.fsf@gmail.com> <6929416953b2939445a5247b014142ea8bb521d9.camel@gmail.com> Date: Wed, 13 Sep 2023 11:37:28 +0200 Message-ID: <878r9abehz.fsf@xelera.eu> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=46.4.214.66; envelope-from=g@xelera.eu; helo=ns13.heimat.it X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.32 X-Spam-Score: -6.32 X-Migadu-Queue-Id: 1E8DC43222 X-Migadu-Scanner: mx2.migadu.com X-TUID: 2Toxhesh79Ix --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Liliana and Maxim, Liliana Marie Prikler writes: [...] > The thing is, we're discussing the same basic workflow No, we are discussing two (complementary) workflows: 1. the one I suggested to add a "footer-metadata-field" named Fix/Fixes/Close/Closes/whatever that will allow people pushing to the Guix official repo to _add_ the information that the (already installed, to be enhanced) server side git post-receive hook should also close one or more bug reports; that "metadata-footer" should be "manually" added to the commit message before pushing, the commit must be _amended_ (git commit --amend). 2. the one suggested by Maxim (bringed by Gerrit) to _automatically_ add a "footer-metadata-field" named 'Change-Id' that will allow "a machinery" (IMO it should be the currently installed hook, enhanced) to _automaticcally_ close bug reports when all 'Change-Id's contained in a bug report have been pushed to the official Guix repo. This is my understanding of what we are discussing here: did I miss something? > (which you lay out below), just different kinds of metadata that we'd > have to attach to our commits. Thay are different because they serve different needs. > IIUC ChangeIds need to actually be carried around by the committers as > they e.g. rewrite patches (rebasing, squashing, what have you) Since 'Change-Id' is automaticcaly generated by a _local_ git hook upon committing and left unchanged if already present, the only precaution the committer should apply is to preserve it when rebasing in case the person needs to send a new version of the patch.=20 > and they're basically opaque hashes so I don't see the benefit to the > reader. The benefit are not for the reader but for "the machinery" to be able to compute when a patch set is completely pushed to the Guix official repo, this also means that the related bug repo (related to the patch set) can be happily automatically closed. No? > (I think you might be arguing that the benefit is uniqueness, but I'm > not sure if I ought to buy that.) The benefit is that 'Change-Id' is autogererated as unique, kept between rebases (with some pracaution by the _local_ committer) thus is useful to compute the completion of each patch contained in a bug repo (of class [PATCH]). Obviously all of this should be clearly documented, so everyone will understand how it works. [...] >> In case it couldn't close an issue, it could send a notification to >> the submitter: "hey, I've seen some commits of series NNNN landing to >> master, but not all of the commits appears to have been pushed, >> please check" > I'm not sure how common this case is Don't know the cardinality, but I guess is a /very/ useful usecase for people who have committ access to the official Guix repo... at least for Maxim :-) Anyway, I think the main use case for this _second_ way of automatically closing related bugs (the one based upon 'Change-Id') when all [PATCH]es are pushed is very useful for all people with commit access to the Guix repo, a sort of "push and (almost) forget". [...] Ciao, Gio'. =2D-=20 Giovanni Biscuolo Xelera IT Infrastructures --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJABAEBCgAqFiEERcxjuFJYydVfNLI5030Op87MORIFAmUBgtgMHGdAeGVsZXJh LmV1AAoJENN9DqfOzDkSCg0QAITNoo5/4PsHcXOen7X2ELoFSemkdLTGGlrLZ8kN OoF1Iz/UPbORJWV+9HJjNRdx7wgQsb2HWMmdJBd4DgS0DggDa2j796yYqGRwNPr0 s3+m6diyCq6J0jbvNIZKrMEvOYzAakeTFysGY0g3ugFNjn3CVyNXqqNhhxEnyEqE pViBitf/vsAAN3Ex7puNzQc6wUtopevX53EcywQRHKw56wl2OHdRrT+w7Xrsny3g KU8rSOfVK6PcfBDMNA4RSVOiApwe6CkKw7LLLIHqMjEbjuPob/f3YiWsqFz9hsVv VExbL936YmjtlrSiORlUAl5W9Jo8YWKhNop+OawS3jwopoRGNPa7syeylQ2T5uaM cepcHPH1ZKD79yQuw9pxlg2QjWOull+MbANpBioEZiZIvlwn2TtBI8JO+hsw1h1w D1jX1kedeqt7wQm2xhRc+0FYtaHCuF28FxHk06565QvhCl0iPSYfsbrp9Grpp+Zi ZIhCNkxqgvQ/ThBavq6KGvr0/FJ71YCbOaSGh5xd2D5JByjpLpI+D/r6cVhwo+gG bgJv0irGjM6HtHYPlIVluen0yFftHmOEkmpNi2iLBrEmhptivgGhhAfNwHWZqKWu 5NW4JkM4b3CJkf3FBQu8gPSi419lA+iuNDfcTyhExPg/d07l0cnTKYeDSJRhUtII KK8X =rZhH -----END PGP SIGNATURE----- --=-=-=--