From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id EPUGHLIvBGXcKwAA9RJhRA:P1 (envelope-from ) for ; Fri, 15 Sep 2023 12:19:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EPUGHLIvBGXcKwAA9RJhRA (envelope-from ) for ; Fri, 15 Sep 2023 12:19:30 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 06BA7476B4 for ; Fri, 15 Sep 2023 12:19:30 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Pgtrrp4o; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694773170; a=rsa-sha256; cv=none; b=JU+JJHpn51QvhNebHk5ph/dqFO9Uc/pLGRpcp6N25Ux5SMtxKnlrCMeggUwCIoL/lbHkgy tzcxxTSSSs6KhvDRHUfot3zjpcXVpBRDw1EB5/OunJcO6yMkRZkZS+GEMuDAjv6WG+QcNc 8F0M6NoIHqu4h4KFQRbBvpjzjHWW9g5hXho7eJWNSmc+Uoh5dUi/MECZivxBFhoGmFJFi+ FPHunNk7VXYmqdRgbxdnee+iAfymekANh6vIcvTbL0l4b1XVukw+uWNte6/g8Paeku2uvY N1FIq5gBctuTiXG4yfQzRfP4ORobFHpSO23phRGk76FvCRGxI+RdKKhNvA4VPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694773170; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=mjoW8gBt2hcrXbHOzlDH/CXAMGE9uleS/YMkT8QNmaM=; b=i79HtMCIDiPzU3+oehWEliIWhBLMMoji5KfltVIeuWtIb6Mh4Dqw52sr5qyXorLtu7UOWq eOdFsXV81Hpp9vcd431KeGCcAUIEnrUnIntux55KsghKWoe/dTRytFguNJatDnmMzmaa0P GKde+8GQPX0OsesLhcltsexPPM+BLb0YUrPpHapUMzpOeYe1ni1QzAz0Y3hVP+L5ZC0V/s vjy70XImvA/Y+Q4XltwdkeM60883DOtfyexCqloCIwd6PRMQUkZsG+6Oud8J8Bkx5u/jxA w19LdcI7s01bGP3iyGFIcA0a8tqCIgXW8hfDiEwHSXKumJCpCIdTZPEXIi0hYg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Pgtrrp4o; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qh5uP-0001e9-6j; Fri, 15 Sep 2023 06:18:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qh5uK-0001bc-9x for guix-devel@gnu.org; Fri, 15 Sep 2023 06:18:41 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qh5uI-0000u5-9I for guix-devel@gnu.org; Fri, 15 Sep 2023 06:18:40 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-40471c054f9so4627215e9.0 for ; Fri, 15 Sep 2023 03:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694773114; x=1695377914; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=mjoW8gBt2hcrXbHOzlDH/CXAMGE9uleS/YMkT8QNmaM=; b=Pgtrrp4oiy/26CUe0jW5DsiO/CWR1pUBoaA+VFYVQLT5INKN8YXtJEJ8kTSdKwm2O8 xMRFk7T+bIbqYhtD2pAWgSogZXRUcTvNfW4c08BPou7Kb850tWNxH3cM0ZQDPHcSzqA0 ik2SmsVrtdU5KiXHFLhVMv47lYo38zhexo0s+0iDX81oCr4jLDV3aBHCkfKI+BLtH4de zGLjOLQBKUxXlTrAqlP/DYb5R7OWZrrcDJlKZ4jJZNohoSrIN2P8sfIqivxM8G7CrlEF QI2rkfubo4ZTlhNWatzKX890GsVSV23I/PeU5zRnX7wKA2RTQnsnUx8yVvAEAUhTVMfe 1Rzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694773114; x=1695377914; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mjoW8gBt2hcrXbHOzlDH/CXAMGE9uleS/YMkT8QNmaM=; b=QiTY9A+ES0bYigFBWWxdokzjHz9f+kGWewYvplSoULU98xwwmeL3EwNJfR6IkoyCCg YB7f12oXGYjJH/NY14TBcLJIL0mvwOtVkqlbRq0iuRzK9m9na4PyHgwkJYJ2yKdvLmDQ W7L2JgLqHEyc/p9Mz2yt+MHiYvy94ObSjnrWZcgJR5AeGioAf0jxWwac0gdgu5WNkSps p69vtFyMkA6/0JtGzim7BDhLyovyisr84jzb1XK+XGj0YkW0ai0/SLnU0EGpd8sgEsqn tgdy0VVFv12QoH67dnmgNjcQguEZ2EQ6zMPOIaCFTI+UTmKZExSSEISvolsAPzDJrCIa JfLQ== X-Gm-Message-State: AOJu0YxcUqc0ghlhp6FnqEFF6E4c5ZzhPWolBBHum80icVAok8DYBm7v riZlOX+3srF3zYxweS4mUlED8BlSiec= X-Google-Smtp-Source: AGHT+IH42f10hjFHEi9Qrx3MwkJfLWvS/BBh2tSRRpvNTpMP19zUgolDxJy0ueCkeVKxfwIB8iAyFA== X-Received: by 2002:a05:6000:1047:b0:31f:a096:6e18 with SMTP id c7-20020a056000104700b0031fa0966e18mr980118wrx.6.1694773114230; Fri, 15 Sep 2023 03:18:34 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id a4-20020adffb84000000b0031c5e9c2ed7sm4023424wrr.92.2023.09.15.03.18.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 03:18:33 -0700 (PDT) From: Simon Tournier To: Giovanni Biscuolo Cc: guix-devel@gnu.org Subject: Re: [workflow] Automatically close bug report when a patch is committed In-Reply-To: <87h6nv9a8v.fsf@xelera.eu> References: <8734zrn1sc.fsf@xelera.eu> <87edjb5le5.fsf@gmail.com> <87jzt2feq6.fsf@xelera.eu> <87y1hikln6.fsf@wireframe> <2d93b48dfd381c55ff706394ff7226133f5e014a.camel@gmail.com> <87pm2pces0.fsf@xelera.eu> <87bke8wo96.fsf@gmail.com> <929b035f6f4aca0793d9f8a6454b673b2a7069c1.camel@gmail.com> <87zg1sv3vt.fsf@gmail.com> <6929416953b2939445a5247b014142ea8bb521d9.camel@gmail.com> <87h6nyw0su.fsf@gmail.com> <86zg1pwwmw.fsf@gmail.com> <87cyyl9hi7.fsf@xelera.eu> <877cotdjr2.fsf@gmail.com> <87h6nv9a8v.fsf@xelera.eu> Date: Fri, 15 Sep 2023 11:03:12 +0200 Message-ID: <878r97dd0v.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.55 X-Spam-Score: -9.55 X-Migadu-Queue-Id: 06BA7476B4 X-Migadu-Scanner: mx2.migadu.com X-TUID: ZVB7DSaTZRH8 Hi Giovanni, Before commenting, let me repeat. ;-) That=E2=80=99s said, I am not against the proposal. I just have mi= xed feelings and before deploying I strongly suggest to review if the proposal covers the intent. On Fri, 15 Sep 2023 at 09:16, Giovanni Biscuolo wrote: > Before commenting, just let me repeat that we are _copying_ the > 'Change-Id' idea (and related possible implementation issues) from > Gerrit: > > https://gerrit-review.googlesource.com/Documentation/user-changeid.html > > This means that Somewhere=E2=84=A2 in our documentation we should start > explaining that: > > --8<---------------cut here---------------start------------->8--- > > Our code review system needs to identify commits that belong to the same > review. For instance, when a proposed patch needs to be modified to > address the comments of code reviewers, a second version of that patch > can be sent to guix-patches@gnu.org. Our code review system allows > attaching those 2 commits to the same change, and relies upon a > Change-Id line at the bottom of a commit message to do so. With this > Change-Id, our code review system can automatically associate a new > version of a patch back to its original review, even across cherry-picks > and rebases. > > --8<---------------cut here---------------end--------------->8--- > > In other words, 'Change-Id' is /just/ metadata automatically added to > help in code review **tracking**, specificcally helping "across > cherry-picks and rebases" [1] > > Sorry if I'm repeating things probably already understood! All this does not address my concern. :-) >> 1. The hook must be installed. [...] > If this is stil not properly documented it will be fixed. Maybe=E2=80=A6 and it will be another item in the already very long list of steps to complete before contributing. This is one of my concern: add yet another thing to an already complicated process for contributing. >> 2. The hook must not be in conflict with user configuration. > > I guess you mean not in conflict with other locally installed git hooks: > since AFAIU we **already** have a locally installed git hook, this is > already a requirement and this is something the user (contributor) > should be aware of. AFAIK, we have a pre-push hook. This hook is only useful for the small set of people who push the code. And we can assume that this set of people is skilled and are able to invest if something is unexpected. Being Guix committer implies such commitment, IMHO. Here, we are speaking for a Git hook applied to all. That=E2=80=99s a diff= erent situation, IMHO. As an user and simple contributor, if I already have a global pre-commit hook and then when I want to contribute to Guix, I potentially hit some unexpected behaviour or even conflict, then as an user, either a. I give up, drop and move my interest to something else than Guix, either b. I spend some time for fixing this annoyance and that is pure friction (no value for me and no value for the project). > If this is stil not properly documented it will be fixed. Yes, yet another thing to an already complicated process for contributing. >> 3. The generated Change-Id string can be mangled by some user unexpected >> action. > > Contributors and committers should not delete or change and already > existing 'Change-Id', this will be documented. Yes, yet another thing to an already complicated process for contributing. >> Many things can rail out on user side. For an example, base-commit is >> almost appearing systematically in submitted patches almost 3 years >> later. > > I don't understand how this could impact the addition of the > patch-tracking metadata named 'Change-Id' > >> The patches of some submissions are badly formatted. Etc. > > I don't understand what is the problem of having a 'Change-Id' (in > commit messages) in badly formatted patch submissions. In these both example, I just pointed that we already have some potential frictions. And here, another one is added. What I know from my experience at work and from the small experience backed by my reading of help-guix or some bug reports is that: robustness is hard in an environment you do not control. More action we add in that uncontrolled environment and weaker the robustness becomes; and weak robustness means friction. Again, I am not saying the proposal is not worth =E2=80=93 I am following t= he discussion with interest. :-) I am just trying to ask if this proposal will really fix an concrete annoyance compared to the relative complexity it adds, and if it is the right balance between the part and the counter-part. Cheers, simon