From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id yPQCHVUcFGXQeAEAG6o9tA:P1 (envelope-from ) for ; Wed, 27 Sep 2023 14:13:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yPQCHVUcFGXQeAEAG6o9tA (envelope-from ) for ; Wed, 27 Sep 2023 14:13:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 34647A4FC for ; Wed, 27 Sep 2023 14:13:09 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695816789; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=zeMu5YG+qhJyWdzxOupF9S0FlVB8IzqW3cEema2jmZk=; b=S723wdg1hpa5L2dZkWx9joMSRrYRS9dhTAETlwaQXeeUHDEYMiKzS15aEkmfWoLY3bJtL/ 0IgXnPQWSrBzyH12rgTqcCKt81iayRapNREwKrnIIuj46hc5ugJ8zDxjHmyRPuwn6eEyO2 ArNr2l58l3xNGiH2QT02jskEdXlH9OIZb5YWyXAJS/xXM4fYQwHgIl5I9g23UM7PlhAJ2B PofRGJwaGcHfL38CUu7QMdST9Ldf1ZQb6eL1kHJ/DoyuxCyRceCYMnozPDCOH4JOIIpqgZ FlAwl5MfmvUSmrgdnqysBOU6fS3KrS8eeHz+Nw7Xbfq3n8DxNr3SY17B4CqfiA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695816789; a=rsa-sha256; cv=none; b=FWYcGWlr0L7efI8FaXSlgM8Z506GRgxu1Xs7jWDoU792Ak6sfsFyXhty+cNkdA7OWj4oKo Jr9DEQruqSWzm2wWbCvtIQm6a8dS5s23ezcLMr8hC38AAtO1sXtm3CIHWH6iMU2r2XCTm0 O8M+fRYNdCsKPd81sKcowwmBGMwKgS66gpyspglBljXcGbbvnPd5Tdpfd74yQOu01j6YG0 tPaM83URCDQClqbUagMhKV4axeuTjw/xQ8sS+OfIyEIp469xgHQCMJcI5quRyLcOxTj0LN qtJE2Y3GmLJma82Lvn9FePXrv4zg3/k+f8/0c+RIaVQbkbrJi5tC3qs6HPMWQw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qlTP9-0002oJ-4F; Wed, 27 Sep 2023 08:12:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlTP4-0002ll-Id for guix-devel@gnu.org; Wed, 27 Sep 2023 08:12:31 -0400 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qlTP1-0004CA-UH for guix-devel@gnu.org; Wed, 27 Sep 2023 08:12:29 -0400 Received: from localhost (unknown [217.155.61.229]) by mira.cbaines.net (Postfix) with ESMTPSA id 8586327BBE2 for ; Wed, 27 Sep 2023 13:12:26 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id cdb474d7 for ; Wed, 27 Sep 2023 12:12:26 +0000 (UTC) References: <87o7ifb66o.fsf@cbaines.net> User-agent: mu4e 1.10.5; emacs 28.2 From: Christopher Baines To: guix-devel@gnu.org Subject: Re: Process for reviewing patches as someone without commit access Date: Wed, 27 Sep 2023 12:58:19 +0100 In-reply-to: <87o7ifb66o.fsf@cbaines.net> Message-ID: <878r8rbys5.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -8.34 X-Spam-Score: -8.34 X-Migadu-Queue-Id: 34647A4FC X-TUID: vnLSyyLWfo6K --=-=-= Content-Type: text/plain Christopher Baines writes: > I've been reviewing the list of ideas on and around QA ([1]) recently, > and got thinking again about how to support people without commit access > reviewing patches. Obviously you don't need commit access to review > patches, but where I think we need some process is how to expedite > someone with commit access taking a look at the patches that have been > reviewed, and merging them if appropriate. > > 1: https://qa.guix.gnu.org/README > > Maybe we can use debbugs tags for this? It looks like this has already > been done in the past, I found some issues tagged with the usertag > "reviewed" for example [1]. Some were also tagged with > "reviewed-looks-good". I guess my primary concern is to have a tag (or > combination of tags) which indicate that a committer should have a look > at the issue as it's been reviewed by someone and should be ready to > merge. I don't really use debbugs much, but does anyone have any > opinions on appropriate tags? > > 1: https://debbugs.gnu.org/cgi-bin/pkgreport.cgi?tag=reviewed&users=guix > > Once we know what tags to use, I can have the QA frontpage do something > similar to the "Mark as moreinfo" links, so it's easy to just click a > button then send the email to change the state of a issue. I've gone ahead and implemented an initial version of this. On the page for an issue now there's a form to mark patches as reviewed. This replaces the previous review checklist and notes field. That form then takes you to a page to submit the review. This can be done through the mailto link, or by following the manual instructions. Of course people using other ways of interacting with debbugs can also just add the reviewed-looks-good usertag for the guix user. Once QA has picked up that the reviewed-looks-good usertag is present, it'll display a dark green status and the issue will appear at the top of the /patches page. My hope here is that people with commit access can prioritise merging patches that have been reviewed and should be ready to merge. The implementation is a bit iffy, Mumi doesn't have access to the usertags as far as I can tell, so I'm getting them from the debbugs soap interface (luckily Ricardo has already figured that out), but it gives you every issue tagged for every usertag for that user, which probably won't scale well if lots of people start reviewing patches. But if that happens we can always look at how to address it. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmUUHCpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xc90g//en64sscHhoW/xVbQTgUsk7LtW/sl4a8M OpO7HdtFw0PN2s4rwAAM/l5e+G1gVtOlFpWWgNvl2sSeT3gsM2O72F2Ua2Umo9a+ fONtm/Mra2JQGmn6txg0DIZZMNySVWgJTLsmB++CfZsmGBYoPoNY1m9PSXpKQT95 00pKALOGtx7bQ9QAwPMeeLogRfdj7OaRa9bAdYV4O3+mlzn/L6zESKCZWu05dFn1 CCFr5RCYvw22lj+Fty8xHWnhhxLiDHABPUK8MER97tbj0fYEv04J9SWbJCuKPWpA 64YKrhtzii6mjlH3aKYAHnTJ2aCo6x+uetc5FIDj3T5gdwU5iS4o8E6GV0/DSNzE XEzU6XTM/FFeNA1ROjc+afGlC45JEYaMUvZX6QpXd5rzWV2Nx2J2ZFbH06yEohqj rY4WoaqBPMRQicESwz8ajQUBOVKJnZGwmwQXhrhKy3X9DAz6KQIhML5fym0mJnZ3 iBAsRnxGjhi+e9tBjGTH91s3jXxIBYfHiPwPpw+bOdgAfBPKPuJmmwDKr1DusLPw mBKJW4ozcA2TJP4DaxhidYhEzyPHdYNRfEEsMZ37lrlhS2VQerMy6VbKgzhFqBy6 PKtsQjpAQ/gBl0HLUYU6uEEZh45iazAamyOmYlHEA8VhPOUiV2LNFDw+t09S4d95 DQh0jW6iOt0= =O5P9 -----END PGP SIGNATURE----- --=-=-=--