all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Hilton Chain via Guix-patches via <guix-patches@gnu.org>
To: Zheng Junjie <zhengjunjie@iscas.ac.cn>
Cc: 67365-done@debbugs.gnu.org
Subject: bug#67365: [PATCH core-updates] gnu: gitless: fix definition.
Date: Wed, 22 Nov 2023 20:17:48 +0800	[thread overview]
Message-ID: <878r6qm177.wl-hako@ultrarare.space> (raw)
In-Reply-To: <929310d537eaa3b455d69de00afaaeb14e84f66f.1700650817.git.zhengjunjie@iscas.ac.cn>

Hi,

On Wed, 22 Nov 2023 19:00:17 +0800,
Zheng Junjie wrote:
> 
> gnu/packages/version-control.scm(gitless)[arguments] move #~ to #:phases,
> disable test.
> 
> Change-Id: Ibe3cdbd24fc0b27a15a880a2a45cb0cd8cfde84d
> ---
>  gnu/packages/version-control.scm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
> index c366a41342..b687d184c2 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -50,6 +50,7 @@
>  ;;; Copyright © 2023 Nicolas Graves <ngraves@ngraves.fr>
>  ;;; Copyright © 2023 Bruno Victal <mirai@makinata.eu>
>  ;;; Copyright © 2023 Kjartan Oli Agustsson <kjartanoli@disroot.org>
> +;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -776,9 +777,10 @@ (define-public gitless
>         (file-name (git-file-name name version))))
>      (build-system python-build-system)
>      (arguments
> -     #~(list
> -        #:phases
> -        (modify-phases %standard-phases
> +     (list
> +      #:tests? #f ;; FIXME: fix test
> +      #:phases
> +      #~(modify-phases %standard-phases
>            (add-before 'build 'loosen-requirements
>              (lambda _
>                (substitute* "setup.py"
> 
> base-commit: 1bca46690c6240310befc6208fb24a044bd4b437
> -- 
> 2.41.0


Applied (without the #:tests? change, I'll address it later), thank you!




      reply	other threads:[~2023-11-22 12:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22 11:00 [bug#67365] [PATCH core-updates] gnu: gitless: fix definition Zheng Junjie
2023-11-22 12:17 ` Hilton Chain via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r6qm177.wl-hako@ultrarare.space \
    --to=guix-patches@gnu.org \
    --cc=67365-done@debbugs.gnu.org \
    --cc=hako@ultrarare.space \
    --cc=zhengjunjie@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.