all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 68180@debbugs.gnu.org,
	Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
	Andrew Tropin <andrew@trop.in>
Subject: [bug#68180] [PATCH v2 4/4] gnu: Add emacs-pde.
Date: Tue, 02 Jan 2024 14:41:08 -0500	[thread overview]
Message-ID: <878r57o757.fsf@gmail.com> (raw)
In-Reply-To: <c602aac4cbf706f78fbf550b7838a3b0bb28bc71.camel@gmail.com> (Liliana Marie Prikler's message of "Tue, 02 Jan 2024 06:22:27 +0100")

Hello,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:


[...]

>> +              (make-file-writable "lisp/perltidy.el")
>> +              (emacs-substitute-variables "lisp/perltidy.el"
>> +                ("perltidy-program"
>> +                 (search-input-file inputs "bin/perltidy")))
>> +              (substitute* "lisp/tools/perldoc-cache.pl"
>> +                (("`perldoc")
>> +                 (string-append
>> +                  "`" (search-input-file inputs "bin/perldoc"))))))
> I'd use for-each to make the files writable, possibly also a directory
> excursion.

Done, see v3.

Thanks for the review!

-- 
Maxim

  reply	other threads:[~2024-01-02 19:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-31 16:49 [bug#68180] [PATCH 0/4] Add emacs-pde Maxim Cournoyer
2024-01-02  1:58 ` [bug#68180] [PATCH v2 " Maxim Cournoyer
2024-01-02  1:58   ` [bug#68180] [PATCH v2 1/4] gnu: emacs: Patch awk, find, sed and sh commands Maxim Cournoyer
2024-01-02  7:07     ` Andrew Tropin via Guix-patches via
2024-01-02  1:58   ` [bug#68180] [PATCH v2 2/4] build: perl: Accept Gexps for #:module-build-flags Maxim Cournoyer
2024-01-02  1:58   ` [bug#68180] [PATCH v2 3/4] gnu: perl-b-keywords: Update to 1.26 Maxim Cournoyer
2024-01-02  1:58   ` [bug#68180] [PATCH v2 4/4] gnu: Add emacs-pde Maxim Cournoyer
2024-01-02  5:22     ` Liliana Marie Prikler
2024-01-02 19:41       ` Maxim Cournoyer [this message]
2024-01-02 19:39 ` [bug#68180] [PATCH v3 0/4] " Maxim Cournoyer
2024-01-02 19:39   ` [bug#68180] [PATCH v3 1/4] gnu: emacs: Patch awk, find, sed and sh commands Maxim Cournoyer
2024-01-02 19:39   ` [bug#68180] [PATCH v3 2/4] build: perl: Accept Gexps for #:module-build-flags Maxim Cournoyer
2024-01-02 19:39   ` [bug#68180] [PATCH v3 3/4] gnu: perl-b-keywords: Update to 1.26 Maxim Cournoyer
2024-01-02 19:39   ` [bug#68180] [PATCH v3 4/4] gnu: Add emacs-pde Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r57o757.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=68180@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.