From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id MCE9DUlZrWXfEwEA62LTzQ:P1 (envelope-from ) for ; Sun, 21 Jan 2024 18:50:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id MCE9DUlZrWXfEwEA62LTzQ (envelope-from ) for ; Sun, 21 Jan 2024 18:50:01 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Mc1Xkv0Y; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705859401; a=rsa-sha256; cv=none; b=K+RpFioun1sG2lUqpvI0yXJuXZ+gKtK0yoGK0hTQMbGi6GpouQddM7NgqUAdoOeeVzynAu c+XPjLNyMGwQatawxndMiXOUo3G+2NAldjC+ZYu7SeeFENZnti837Xnr+ISmgoeF88hnYG 1pF5C2BZqyiA0YkWJVN6rcRsnNSnXM34t3+khwkkulGKNL/q6+qN8ihxs9pXd9VaxNxkS/ YKYYmIrs0N0x47NjQdXMwqXeVpuSeBdGTSFfKRhQIPt5GtImm7W90sV2kIxtZJoUQINEsy C7LSCRPKRWF1S0UQ9TN5UfxZDsmcTK9PT5j2WHrJ8IIAeas5+bFYvFE+YaGvvw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Mc1Xkv0Y; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705859401; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5VDav7nufDzCGCdAfS4jETiIrb9oExX8dPtpcNQvBhc=; b=jZifPTiT5lwr36AHblcT42GC0g9fCfy9RfihrXOKL6gW8vUwY1oJ+RP9K9WcFAvH2jqmF9 NiKOEriPyGJvSKRAQ4iqOi/YPYLVT4USBmSxgpXUcEpsKRICijs4+9xFZjZHLUhS0r2P9G nqjFRD3qXsWXViqGiFJNHbfIX7d4wdyUod9gavleOSiiWRg2SE5bNEHqRQBl98G4I/d/kh FBo8+AiT4/V1bEsvERgJUZEH1Jg1jhoQHoBCd29uZbgA+Ol2rd0IYhdSfEnzu/NAiEt3Ux uAjPDk8j+Yn3L+LX6UcAhyK/OygntMt5K2ytBKwvvWhzXeCNlV27HfeQj5z6uQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2120A9A41 for ; Sun, 21 Jan 2024 18:50:00 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRbws-00032e-4x; Sun, 21 Jan 2024 12:49:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRbwr-00032W-JM for guix-devel@gnu.org; Sun, 21 Jan 2024 12:49:33 -0500 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rRbwq-00028V-4X; Sun, 21 Jan 2024 12:49:33 -0500 Received: by mail-ot1-x32c.google.com with SMTP id 46e09a7af769-6dc83674972so1315715a34.1; Sun, 21 Jan 2024 09:49:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705859369; x=1706464169; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=5VDav7nufDzCGCdAfS4jETiIrb9oExX8dPtpcNQvBhc=; b=Mc1Xkv0Yv2qvcKkqVFx8J+1eOVHKnUIp+LHcUx0R7trO0xNu66Qm3loametB9DgPcF MTwcaG5aJE/x/h5B3caXs/gc/uaz4gsHavlJYQBiBSrWNVxVfGTDVrtSAYYFTdhfWonc WMsP2/Ywmomwf3/kgJ+EW1LJBA1vWLltKdVY03H12JNaObCNJo+ohbz46M9Vb4/ozfcY 7EMofKARjtRv0abb0AcLXWjsKnvI/n6w56RQb6sV+Pm90F3EJaBBwR4GE+nuzPzTpw6J z+ctj9vKh5zQIqVyLuMBYEQUGsW4ix7txFTNH10M6KosEWur0lu9ek4MmOm0WZQoGCxI 8m7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705859369; x=1706464169; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5VDav7nufDzCGCdAfS4jETiIrb9oExX8dPtpcNQvBhc=; b=J6glp4b4wZKb8wpSeZ1WuEsYnwaXSsOvDzh70mY+ljG2tzw9bKdJARhymVlZ5Za/Xz XDkW+mJ64Uocf88GOd6LphzIeMMVqgaQdfu6Z+DZdmitnxwGtdaqWKyl0ryE0GbmsVMX 4ggxuwOg1n3iMv1euYH17eUS9/eJLEj15J3bb0syNdNpaVKldfE0roDSXZelDxQ6i57J lLcqwRpZY07UUIkBloUsYV2VD1vJAnefoDICz7GSYJJICZL/tk5GCL2AAAN3pPBgiJgu kD2ww2cX9oViklLW2W7jwlj+VrwyFt4h76AVPK5jYBKkqgEUqSZC7v0Brrfzz/WfwNmB d2dQ== X-Gm-Message-State: AOJu0YwvMw0QJonx018/Nvvry9Bi+YZlBaOjpEBTCWfbB5P1e+ZwSxQe 2L8bJtUcWBWOrgJZZx/wHwoBC7eH5MRgl/HjTAPmDxAdCkL+iDSZny0r/W+vSII= X-Google-Smtp-Source: AGHT+IE7WTri49Qq6GRV5bFSpHzxUNkmlHaSPwCnLX+rctfqYRfxK/iR1/v7KptD8i4W/a5NVRahcQ== X-Received: by 2002:a05:6358:248f:b0:175:8ff3:d613 with SMTP id m15-20020a056358248f00b001758ff3d613mr2044130rwc.43.1705859369184; Sun, 21 Jan 2024 09:49:29 -0800 (PST) Received: from hurd (dsl-10-128-232.b2b2c.ca. [72.10.128.232]) by smtp.gmail.com with ESMTPSA id ng3-20020a0562143bc300b006819bc7aeeesm1677896qvb.127.2024.01.21.09.49.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jan 2024 09:49:28 -0800 (PST) From: Maxim Cournoyer To: Attila Lendvai Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , guix-devel Subject: Re: [shepherd] several patches that i deem ready In-Reply-To: (Attila Lendvai's message of "Sun, 21 Jan 2024 09:38:40 +0000") References: Date: Sun, 21 Jan 2024 12:49:14 -0500 Message-ID: <878r4ia86d.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::32c; envelope-from=maxim.cournoyer@gmail.com; helo=mail-ot1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Spam-Score: -9.29 X-Migadu-Queue-Id: 2120A9A41 X-Migadu-Spam-Score: -9.29 X-TUID: I2fu0w6Kc70L Hi Attila, Attila Lendvai writes: >> - a lightweight logging infrastructure together with plenty of log >> lines throughout the codebase, and some hints in the README on how >> to turn log lines gray in emacs (i.e. easily ignorable). Are you using guile-lib's logging library for it? I've used it in guile-hall if you want to have an example. We should maximize its users, refine it and aim to have it builtin Guile at some point. > > a quick note on the log statements: they are essentially noise when it > comes to reading the code, hence the gray coloring i suggest in > emacs. (although they may often serve also as "executable" comments). > > i'd also like to propose to relax the 80 column limit for log lines > for the same reason that i've explained above. I don't think an exception is deserved here; the logging library from guile-lib for example concatenates message strings by default, which makes it easy to brake long messages on multiple lines. -- Thanks, Maxim