From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 2BQNH15ZHWZ+SQAAqHPOHw:P1 (envelope-from ) for ; Mon, 15 Apr 2024 18:44:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 2BQNH15ZHWZ+SQAAqHPOHw (envelope-from ) for ; Mon, 15 Apr 2024 18:44:14 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713199454; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=CDZou+cHeJJwNKIygeAE5NxlENXDFFyI/wiFcDSV2Yo=; b=EY8wnJinRBF1ohQahHo3/jcsKaZ409qhDqlmk8j6lZ31SCD9N/Ghb19Hva9QVv6DAEfoWP EcCVCPMwJf+AHvlbTaL4+PJZx66yKFJLXHlP9Aa5v2PgO/DrmMgY0fFfXUIjdKffm8mSpx lsB4t0D/CWWfJDAKqTNJfHe0MkaIQoPBaqwGGYYH4OkqAnnnWs/mvtMSn0etdN3pAmx5Gc n8ME4jfKgnscGIodYI/sJotgtjrFq573QNWxLgKSTCvqR0JsJl5QFSPsnTxlXERYw1A9+2 FbuObDlqZyVZkKiweXIPpZGLrMTOKvbJmBPOAa/s0oC/aHo4QtZvVR7tidirrA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713199454; a=rsa-sha256; cv=none; b=FCnGLpWy7Vb1twnzUkF0O8pnpqI1g4Yus5K5cDkHKvcGBOYCV1VLdMpFcPp6hxtCWkLZT0 vXf7h4+BJDIF30QadR0UMrkgBWDYGkISe4VEetlwiEpmr0gNRZfdbFIjfypt729pcdLjfS Ob7QpomWoaIiI43MHvwrqJWz1bOniVA7z7Rrmg6V2LfCDBUFvMTsCq0xfnsinZhcmFc0d3 Z1KYsstMN6Hi837XW/1G2JKosv88jNeDrwNO5T+gLT/ndWBM9MbfV4wjF18cn4fy7uCmb/ 3P4+nCqao0pAdd0a2cxyEA0z6HexG7lf8fx51Fqtiq3cnMvx61MhfP0izMIXhQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE8A9393F1 for ; Mon, 15 Apr 2024 18:44:12 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwPR2-00063N-Js; Mon, 15 Apr 2024 12:44:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwPR0-00063F-Dp for guix-patches@gnu.org; Mon, 15 Apr 2024 12:43:58 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwPR0-0004bE-5L for guix-patches@gnu.org; Mon, 15 Apr 2024 12:43:58 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rwPRB-0002v4-O5 for guix-patches@gnu.org; Mon, 15 Apr 2024 12:44:09 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70397] [PATCH] gnu: cppdap: Add cppdap to debug.scm. Resent-From: Zheng Junjie Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Apr 2024 16:44:09 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70397 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Daniel Ziltener , 70397@debbugs.gnu.org Received: via spool by 70397-submit@debbugs.gnu.org id=B70397.171319939810789 (code B ref 70397); Mon, 15 Apr 2024 16:44:09 +0000 Received: (at 70397) by debbugs.gnu.org; 15 Apr 2024 16:43:18 +0000 Received: from localhost ([127.0.0.1]:38276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwPQG-0002n8-Q5 for submit@debbugs.gnu.org; Mon, 15 Apr 2024 12:43:17 -0400 Received: from smtp81.cstnet.cn ([159.226.251.81]:60602 helo=cstnet.cn) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwPQ5-0002k2-PC for 70397@debbugs.gnu.org; Mon, 15 Apr 2024 12:43:09 -0400 Received: from m (unknown [111.0.51.68]) by APP-03 (Coremail) with SMTP id rQCowABXdyT8WB1mdKiuAw--.34115S2; Tue, 16 Apr 2024 00:42:38 +0800 (CST) From: Zheng Junjie In-Reply-To: <922b1372b2b1e8b1ea642fe85d33e9fd@lyrion.ch> (Daniel Ziltener via Guix-patches via's message of "Mon, 15 Apr 2024 16:23:09 +0200") References: <922b1372b2b1e8b1ea642fe85d33e9fd@lyrion.ch> User-Agent: mu4e 1.12.2; emacs 30.0.50 Date: Tue, 16 Apr 2024 00:42:33 +0800 Message-ID: <878r1e60hy.fsf@iscas.ac.cn> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-CM-TRANSID: rQCowABXdyT8WB1mdKiuAw--.34115S2 X-Coremail-Antispam: 1UD129KBjvJXoW7KFyfXw4xtr1fZF4DJF4UCFg_yoW8KFyDpw 4rGF4Ykw1rG347Jws3u3WIgr15W395Gry5X3y2kw18CF45ZFWkJrWIkFZIqrsrZr1fAa17 WayS93WkWF4DCFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUk2b7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4 vEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487M2AExVA0 xI801c8C04v7Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGw Av7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxAI w28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr 4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUXVWUAwCIc40Y0x0EwIxG rwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8Jw CI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2 z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUgg_TUUUUU X-Originating-IP: [111.0.51.68] X-CM-SenderInfo: x2kh0wxmxqyx3h6l2u1dvotugofq/ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.97 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -7.97 X-Migadu-Queue-Id: DE8A9393F1 X-TUID: LD1alyN2RJTt --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable hellow, i review this patch, and have some comment Daniel Ziltener via Guix-patches via writes: > --- > gnu/packages/debug.scm | 31 +++++++++++++++++++++++++++++++ Usually our message goes something like this: gnu: Add cppdap. * gnu/packages/debug.scm (cppdap): New variable. > 1 file changed, 31 insertions(+) > > diff --git a/gnu/packages/debug.scm b/gnu/packages/debug.scm > index 6d4567acc4..7865dc32f4 100644 > --- a/gnu/packages/debug.scm > +++ b/gnu/packages/debug.scm > @@ -185,6 +185,37 @@ (define-public c-reduce > tools that process C/C++ code.") > (license license:ncsa))) >=20=20 > +(define-public cppdap > + (package > + (name "cppdap") > + (version "1.58.0-a") > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/google/cppdap") > + (commit (string-append "dap-" version)))) usually we add (file-name (git-file-name name version)),=20 and it have a "third_party" directory, we need remove it. and see https://github.com/google/cppdap/pull/124 , it add a CPPDAP_USE_EXTERNAL_GTEST_PACKAGE option to use system gtest. so we can pick it. > + (sha256 > + (base32 > + "0fq2w35fw1lb5wya1nny45pk3a13b689k48calk1cmqmqpbcjn2b")))) > + (build-system cmake-build-system) > + (arguments > + (list > + #:configure-flags #~(list "-DCPPDAP_USE_EXTERNAL_NLOHMANN_JSON_PAC= KAGE=3DON") > + #:phases #~(modify-phases %standard-phases > + (delete 'check)))) if no test target, please use "#:tests? #f" and add commit about it. and it have CPPDAP_BUILD_TESTS, so we can enable it. > + (propagated-inputs > + (list nlohmann-json)) need add some commit about why propagate nlohmann-json. and need add (gnu packages cpp) module. > + (home-page "https://github.com/google/cppdap") > + (synopsis "C++ library for the Debug Adapter Protocol") > + (description > + "cppdap is a C++11 library (\"SDK\") implementation of the Debug Ad= apter Protocol, > +providing an API for implementing a DAP client or server. > +cppdap provides C++ type-safe structures for the full DAP specification,= and provides > + a simple way to add custom protocol messages.") It's a little over the line count > + (license license:expat))) > + > (define-public c-vise > (package > (name "c-vise") The end result should be similar https://issues.guix.gnu.org/70397#1 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmYdWPkACgkQO1qpk+Gi 3/BBhg/+NKZ4aD8iMDYlg5rjLYLxLAuBLKu13J+UUsiJyZE3QIhnu17W7teuU0JR 1Zn14mOLPoILPZzBPQtSxrh2yK7CV/bTU/PnN7cPqY823/dAme+O3NMZQwLx532q aVe+rCS1u3X2x9SrjCp9TrpX2LjlS0CsDzEXAsQzR6d7PyY1z7AlJkACJWqvsOcc hDgZTC/LIQQLqcfCywSiqfKv4w0wTAKufnq8NLK4lYUnxeNnFLAoYxN3bgCfMbXM DRzwc94g2drbxWDoADkPZnmVINpxlZj1kfFIBGkByVIw8WfLVDBRaOsJNdyQdEKN mAOkT98ckQ+M8btH+rFl9NHzFiquNIc9uXw6ogK6gYoRDJz3JhCX6uRQ2aYLdhXC KSg7kbs1QdzsRMuJ7ZcmamQhGzXA0N+Y8D9mFWhd2mUglGUF+6iSPbCR9tjlFmID r4yfzupGqc5UBtDLqlCyVy9ee63arwIVS8FSkk8lrIinL/yL9Z1Zw61W3Onrr5EB hvjcvUMr2jCDf2jD6lFAkRfo8Hj4DUrJMedUyf+7yxi3f1fOLRQjluiB1Qw6vWH9 +QiWhY+krDQ/f87E59rRPB1mMsw7KtsVb0+O8MbtC90u2guB+40mqTZsETV9Ao6Q UDrMsaLzHrQAWQaW0hsjxHVB1M9IJ3+JknsyNH5YtxCVevgus9I= =TtwT -----END PGP SIGNATURE----- --=-=-=--