From: Zheng Junjie <zhengjunjie@iscas.ac.cn>
To: Daniel Ziltener <dziltener@lyrion.ch>, 70397@debbugs.gnu.org
Subject: [bug#70397] [PATCH] gnu: cppdap: Add cppdap to debug.scm.
Date: Tue, 16 Apr 2024 00:42:33 +0800 [thread overview]
Message-ID: <878r1e60hy.fsf@iscas.ac.cn> (raw)
In-Reply-To: <922b1372b2b1e8b1ea642fe85d33e9fd@lyrion.ch> (Daniel Ziltener via Guix-patches via's message of "Mon, 15 Apr 2024 16:23:09 +0200")
[-- Attachment #1: Type: text/plain, Size: 2537 bytes --]
hellow, i review this patch, and have some comment
Daniel Ziltener via Guix-patches via <guix-patches@gnu.org> writes:
> ---
> gnu/packages/debug.scm | 31 +++++++++++++++++++++++++++++++
Usually our message goes something like this:
gnu: Add cppdap.
* gnu/packages/debug.scm (cppdap): New variable.
> 1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/debug.scm b/gnu/packages/debug.scm
> index 6d4567acc4..7865dc32f4 100644
> --- a/gnu/packages/debug.scm
> +++ b/gnu/packages/debug.scm
> @@ -185,6 +185,37 @@ (define-public c-reduce
> tools that process C/C++ code.")
> (license license:ncsa)))
>
> +(define-public cppdap
> + (package
> + (name "cppdap")
> + (version "1.58.0-a")
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/google/cppdap")
> + (commit (string-append "dap-" version))))
usually we add (file-name (git-file-name name version)),
and it have a "third_party" directory, we need remove it.
and see https://github.com/google/cppdap/pull/124 , it add a
CPPDAP_USE_EXTERNAL_GTEST_PACKAGE option to use system gtest. so we can
pick it.
> + (sha256
> + (base32
> + "0fq2w35fw1lb5wya1nny45pk3a13b689k48calk1cmqmqpbcjn2b"))))
> + (build-system cmake-build-system)
> + (arguments
> + (list
> + #:configure-flags #~(list "-DCPPDAP_USE_EXTERNAL_NLOHMANN_JSON_PACKAGE=ON")
> + #:phases #~(modify-phases %standard-phases
> + (delete 'check))))
if no test target, please use "#:tests? #f" and add commit about it.
and it have CPPDAP_BUILD_TESTS, so we can enable it.
> + (propagated-inputs
> + (list nlohmann-json))
need add some commit about why propagate nlohmann-json. and need add
(gnu packages cpp) module.
> + (home-page "https://github.com/google/cppdap")
> + (synopsis "C++ library for the Debug Adapter Protocol")
> + (description
> + "cppdap is a C++11 library (\"SDK\") implementation of the Debug Adapter Protocol,
> +providing an API for implementing a DAP client or server.
> +cppdap provides C++ type-safe structures for the full DAP specification, and provides
> + a simple way to add custom protocol messages.")
It's a little over the line count
> + (license license:expat)))
> +
> (define-public c-vise
> (package
> (name "c-vise")
The end result should be similar https://issues.guix.gnu.org/70397#1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2024-04-15 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 14:23 [bug#70397] [PATCH] gnu: cppdap: Add cppdap to debug.scm Daniel Ziltener via Guix-patches via
2024-04-15 16:26 ` [bug#70397] [PATCH] gnu: Add cppdap Zheng Junjie
2024-04-15 21:54 ` Daniel Ziltener via Guix-patches via
2024-04-15 21:54 ` Daniel Ziltener via Guix-patches via
2024-04-15 21:57 ` Daniel Ziltener via Guix-patches via
2024-04-15 21:57 ` Daniel Ziltener via Guix-patches via
2024-04-15 22:04 ` Daniel Ziltener via Guix-patches via
2024-04-23 8:57 ` bug#70397: " Z572
2024-04-15 16:42 ` Zheng Junjie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r1e60hy.fsf@iscas.ac.cn \
--to=zhengjunjie@iscas.ac.cn \
--cc=70397@debbugs.gnu.org \
--cc=dziltener@lyrion.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.