all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: 70400@debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus@gmail.com>,
	Munyoki Kilyungi <me@bonfacemunyoki.com>,
	Lars-Dominik Braun <lars@6xq.net>, jgart <jgart@dismail.de>,
	Marius Bakke <marius@gnu.org>,
	Tanguy Le Carrour <tanguy@bioneland.org>,
	Jonathan Pieper <jpieper@mailbox.org>
Subject: [bug#70400] [PATCH 3/7] gnu: python-lsp-jsonrpc: Update to 1.1.2.
Date: Sun, 16 Jun 2024 00:53:15 +0200	[thread overview]
Message-ID: <878qz53jj8.fsf@ngraves.fr> (raw)
In-Reply-To: <5563651b86d1e60edc8c173091918d87ba693831.1713203110.git.jpieper@mailbox.org>

On 2024-04-15 19:45, Jonathan Pieper via Guix-patches via wrote:

> * gnu/packages/python-xyz.scm (python-lsp-jsonrpc): Update to 1.1.2.
>   [build-system]: Change to pyproject-build-system.
>   [arguments]{set-version}: Set version explicitly to pass sanity-check.

I rather use "<#:phases>: Add phase 'set-version to pass sanity-check"
but I'm not sure that's a stabilized standard.

>   [native-inputs]: Add python-pytest-cov.
>
> Change-Id: I3ffaf75ced25bd95d8f7486294364fb52b86b08b
> ---
>  gnu/packages/python-xyz.scm | 21 +++++++++++++--------
>  1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 27107c3d8f..e0817e4c9d 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -7559,19 +7559,24 @@ (define-public python-feedgenerator
>  (define-public python-lsp-jsonrpc
>    (package
>      (name "python-lsp-jsonrpc")
> -    (version "1.0.0")
> +    (version "1.1.2")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (pypi-uri "python-lsp-jsonrpc" version))
>         (sha256
> -        (base32
> -         "1gb0fsamxndhplx25v8m0b3k7aknzy454fpa0qsqsqnv6c3igv3v"))))
> -    (build-system python-build-system)
> -    (native-inputs
> -     (list python-mock python-pytest))
> -    (propagated-inputs
> -     (list python-ujson))
> +        (base32 "04n95h0cqnsrdyh1gv0abh2i5ynyrq2wfqpppx9djp7mxr9y9226"))))
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'set-version
> +                    (lambda _
> +                      (substitute* "pyproject.toml"
> +                        (("dynamic = \\[\"version\"\\]")
> +                         (string-append "version = \""
> +                                        ,version "\""))))))))
> +    (build-system pyproject-build-system)

nitpick: arguments is clearer after build-system field.
Otherwise LGTM.
> +    (native-inputs (list python-mock python-pytest python-pytest-cov))
> +    (propagated-inputs (list python-ujson))
>      (home-page "https://github.com/python-lsp/python-lsp-jsonrpc")
>      (synopsis "JSON RPC 2.0 server library")
>      (description

-- 
Best regards,
Nicolas Graves




  reply	other threads:[~2024-06-15 22:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 17:34 [bug#70400] [PATCH] Update python-lsp-server Jonathan Pieper via Guix-patches via
2024-04-15 17:45 ` [bug#70400] [PATCH 1/7] gnu: Add python-docstring-to-markdown Jonathan Pieper via Guix-patches via
2024-04-15 17:45   ` [bug#70400] [PATCH 2/7] gnu: Add python-pytoolconfig Jonathan Pieper via Guix-patches via
2024-06-15 22:45     ` Nicolas Graves via Guix-patches via
2024-04-15 17:45   ` [bug#70400] [PATCH 3/7] gnu: python-lsp-jsonrpc: Update to 1.1.2 Jonathan Pieper via Guix-patches via
2024-06-15 22:53     ` Nicolas Graves via Guix-patches via [this message]
2024-04-15 17:45   ` [bug#70400] [PATCH 4/7] gnu: python-snowballstemmer: Update to 2.2.0 Jonathan Pieper via Guix-patches via
2024-04-15 17:45   ` [bug#70400] [PATCH 5/7] gnu: python-pydocstyle: Update to 6.3.0 Jonathan Pieper via Guix-patches via
2024-04-15 17:45   ` [bug#70400] [PATCH 6/7] gnu: python-rope: Update to 1.13.0 Jonathan Pieper via Guix-patches via
2024-04-15 17:45   ` [bug#70400] [PATCH 7/7] gnu: python-lsp-server: Update to 1.11.0 Jonathan Pieper via Guix-patches via
2024-06-15 23:10     ` Nicolas Graves via Guix-patches via
2024-06-15 22:29   ` [bug#70400] [PATCH 1/7] gnu: Add python-docstring-to-markdown Nicolas Graves via Guix-patches via
2024-06-15 22:23 ` [bug#70400] [PATCH] Update python-lsp-server Nicolas Graves via Guix-patches via
2024-06-18  8:49 ` jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qz53jj8.fsf@ngraves.fr \
    --to=guix-patches@gnu.org \
    --cc=70400@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=jpieper@mailbox.org \
    --cc=lars@6xq.net \
    --cc=marius@gnu.org \
    --cc=me@bonfacemunyoki.com \
    --cc=ngraves@ngraves.fr \
    --cc=sharlatanus@gmail.com \
    --cc=tanguy@bioneland.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.