From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 70936@debbugs.gnu.org, vivien@planete-kraus.eu
Subject: [bug#70936] [PATCH gnome-team 3/3] gnu: qemu: Disable more tests.
Date: Sun, 23 Jun 2024 23:14:55 -0400 [thread overview]
Message-ID: <878qyv3uc0.fsf@gmail.com> (raw)
In-Reply-To: <87ttizyhpp.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 14 May 2024 21:41:38 -0400")
Hello!
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>
>> * gnu/packages/virtualization.scm (qemu)[disable-unusable-tests]: Also disable
>> qtest/ahci-test and qemu-iotests/copy-before-write.
>> ---
>> gnu/packages/virtualization.scm | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
>> index 34cccd6550..5389af62f0 100644
>> --- a/gnu/packages/virtualization.scm
>> +++ b/gnu/packages/virtualization.scm
>> @@ -305,7 +305,12 @@ (define-public qemu
>> (substitute* "tests/qtest/meson.build"
>> ;; These tests fail to get the expected number of tests
>> ;; on arm platforms.
>> - (("'arm-cpu-features',") ""))))
>> + (("'arm-cpu-features',") "")
>> + ;; XXX: Why does this (sometimes) fail?
>
> Someone reported it already upstream:
> <https://gitlab.com/qemu-project/qemu/-/issues/2121>. Please add a
> reference to it.
>
>> + (("\\['ahci-test'\\]") "[]"))
>> + ;; This test appears to be missing permissions.
>> + ;; Very sus 🤔
>
> How can it be missing permissions if it is sometimes working? Perhaps
> more something racy where the file hasn't been created yet. I'd
> personally rather not see emojis or comments of dubious utility ("Very
> suspect") in the source. Perhaps add a short excerpt of the error for
> the next curious person.
>
>> + (delete-file "tests/qemu-iotests/tests/copy-before-write")))
>> #$@(if (target-riscv64?)
>> '((add-after 'unpack 'disable-some-tests
>> (lambda _
>
> Otherwise, LGTM, with the added reference to the upstream issue. Thanks
> for taking the time to address flaky tests! They are a real drag when
> left unchecked.
Ping, in case it had fallen in cracks :-).
--
Thanks,
Maxim
next prev parent reply other threads:[~2024-06-24 3:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 12:15 [bug#70936] [PATCH gnome-team 0/3] Fix some broken tests Liliana Marie Prikler
2024-05-14 7:27 ` [bug#70936] [PATCH gnome-team 1/3] gnu: gst-plugins-bad: Ignore elements_netsim test Liliana Marie Prikler
2024-05-15 1:29 ` Maxim Cournoyer
2024-05-14 7:39 ` [bug#70936] [PATCH gnome-team 2/3] gnu: qtbase: Ignore tst_qsqlthread Liliana Marie Prikler
2024-05-15 1:33 ` Maxim Cournoyer
2024-05-15 1:34 ` Maxim Cournoyer
2024-05-16 5:13 ` Liliana Marie Prikler
2024-05-16 12:44 ` Maxim Cournoyer
2024-05-16 13:15 ` Liliana Marie Prikler
2024-05-16 16:06 ` Maxim Cournoyer
2024-05-14 12:10 ` [bug#70936] [PATCH gnome-team 3/3] gnu: qemu: Disable more tests Liliana Marie Prikler
2024-05-15 1:40 ` Maxim Cournoyer
2024-05-15 1:41 ` Maxim Cournoyer
2024-06-24 3:14 ` Maxim Cournoyer [this message]
2024-06-24 4:11 ` bug#70936: " Liliana Marie Prikler
2024-06-24 4:50 ` [bug#70936] " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qyv3uc0.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=70936@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.