all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#72897] [PATCH] gnu: perl-critic: Make the perlcritic command available.
@ 2024-08-31  2:07 gemmaro
  2024-09-16  9:02 ` bug#72897: " Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: gemmaro @ 2024-08-31  2:07 UTC (permalink / raw)
  To: 72897; +Cc: gemmaro

* gnu/packages/perl.scm (perl-critic)[arguments]<#:phases>: Add phases to wrap
the perlcritic command and test it works.
[inputs]: Add bash-minimal for wrap-program.

Change-Id: I8c506e655fdf2b1c33e850579c6a5adcbbd37192
---
 gnu/packages/perl.scm | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 816aca2d59..b0c1451078 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -2301,7 +2301,22 @@ (define-public perl-critic
                (base32
                 "1nzxpn71mrpp85yxrxlraj52q2skvf9ja887ls11d57h6smg1vmz"))))
     (build-system perl-build-system)
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'install 'wrap-perlcritic
+                     (lambda _
+                       (wrap-program (string-append #$output "/bin/perlcritic")
+                         `("PERL5LIB" ":" prefix
+                           (,(getenv "PERL5LIB") ,(string-append #$output
+                                                   "/lib/perl5/site_perl"))))))
+                   (add-after 'wrap-perlcritic 'check-perlcritic
+                     (lambda* (#:key tests? #:allow-other-keys)
+                       (when tests?
+                         (invoke (string-append #$output "/bin/perlcritic")
+                                 "--version")))))))
     (native-inputs (list perl-module-build perl-test-deep))
+    (inputs (list bash-minimal))
     (propagated-inputs (list perltidy
                              perl-exception-class
                              perl-io-string

base-commit: df14cacca9b95d69fdd3b6191e42df36af266bcd
-- 
2.45.2





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#72897: [PATCH] gnu: perl-critic: Make the perlcritic command available.
  2024-08-31  2:07 [bug#72897] [PATCH] gnu: perl-critic: Make the perlcritic command available gemmaro
@ 2024-09-16  9:02 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2024-09-16  9:02 UTC (permalink / raw)
  To: gemmaro; +Cc: 72897-done

gemmaro <gemmaro.dev@gmail.com> skribis:

> * gnu/packages/perl.scm (perl-critic)[arguments]<#:phases>: Add phases to wrap
> the perlcritic command and test it works.
> [inputs]: Add bash-minimal for wrap-program.
>
> Change-Id: I8c506e655fdf2b1c33e850579c6a5adcbbd37192

Applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-16  9:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-31  2:07 [bug#72897] [PATCH] gnu: perl-critic: Make the perlcritic command available gemmaro
2024-09-16  9:02 ` bug#72897: " Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.