From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id qI0VHl5+LGcFFAEAe85BDQ:P1 (envelope-from ) for ; Thu, 07 Nov 2024 08:46:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id qI0VHl5+LGcFFAEAe85BDQ (envelope-from ) for ; Thu, 07 Nov 2024 09:46:22 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=TYwoSV2j; dkim=fail ("headers rsa verify failed") header.d=ngraves.fr header.s=ovhmo4487190-selector1 header.b=gSdVIu13; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730969182; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=EgQd/p83od4R43EiI89X9joLQ1hrY5ue89oQZ0Tn98M=; b=R2KqgNR46ij3G1OIw8ZxipZlIVJ7x9mIcvgC15QnsxGcStoSZBM/OL9P8W4BmvGrRGZsFc 7we0tTz9Lol/6m46F6A7Jxvy8KoymFM/mkctBK3bHzALtoSEWIJQDml0Z6+a6vU20dAGBg UTnFH9gCeIcWXrr5Conz0VOonO4CLcA0n9Cw5QB8sSQiMmLRqKtYhqJ4o71CywAxc4wG+V J8/M94ZQJH4ggoonLv89FvKHgQGOMPTkqkYdA/qouqQSpwpdKQza2jM/ECZq+ZaqgWvreA jjp19iDFIQAPOtG84gcPuKyjIrhHHJQ3ZkfUgyzZdNFGkbAkAwbHmI8UoXBVng== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=TYwoSV2j; dkim=fail ("headers rsa verify failed") header.d=ngraves.fr header.s=ovhmo4487190-selector1 header.b=gSdVIu13; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730969182; a=rsa-sha256; cv=none; b=KgJao++YMG04K5EIEFAYDqohWrSQ4A604FqRRq3qNS1V88mp5lpNp3e0C1AHPyRXtIOMyD F5I3mQCSj1la7dNFpIdJ3su8GcHYYW9AEPm8OJXVSDl/PoDfIWkQf8hx1If3K2miJlWCHb IVRBaccFE3nvHqN/pCctayvKe/XAy/NpA+b4vJtqdnjT7CA3ak1wjM0eZnkfSHI8kywHoo 0D3qaqhH4iBvvbU5BJbRiABFMqcaLyX3doJHn/kivU2P+/l5cKhf1Xho5yt9Rgo+k8SpsJ 3XqR5IJgXSMuNqpdpaN30+tkAABvSaTizGKaGPazT6zi5w4iwhhACUQ9MUAGdA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 13DDF47538 for ; Thu, 07 Nov 2024 09:46:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8y9T-0000bG-KX; Thu, 07 Nov 2024 03:46:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8y9S-0000WT-1X for guix-patches@gnu.org; Thu, 07 Nov 2024 03:46:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t8y9R-0000sq-Ob for guix-patches@gnu.org; Thu, 07 Nov 2024 03:46:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=EgQd/p83od4R43EiI89X9joLQ1hrY5ue89oQZ0Tn98M=; b=TYwoSV2j2sX3GgW843z2eMsCPIChMwPeMhOP41X/pjoQywS+8ot4eN7FDiqdyNGVfqh/Vp85DZrImoQ27LEqhaQP16W+OFxVW3aDHCxlrhrB9A5Ysj+otKK7osrV2nF/HcUIlVksnQSYsgNxp7kMq3VecXItTlSczMRMKTbFaEYq0HX9Wn8p05pVy0lnXTxiZqMahF7HSdGXsnSpqEWf/3PEikNio5wPVmyuwlQJq9LyNUx4OiSR3JkC30Y4gB4Evz2zdxwLujjdQ27O08+6nE4BTsskjkzxDmqjM+sghF4KPIDWPbbMKPO3FDLpahihYSTfBEBctWfFTKlXd9j9aQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t8y9R-0003jZ-Jb for guix-patches@gnu.org; Thu, 07 Nov 2024 03:46:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74034] [PATCH v2 01/16] guix: cve: Add cpe-vendor and lint-hidden-cpe-vendors properties. Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 07 Nov 2024 08:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74034 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 74034@debbugs.gnu.org Received: via spool by 74034-submit@debbugs.gnu.org id=B74034.173096912114306 (code B ref 74034); Thu, 07 Nov 2024 08:46:01 +0000 Received: (at 74034) by debbugs.gnu.org; 7 Nov 2024 08:45:21 +0000 Received: from localhost ([127.0.0.1]:47092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8y8n-0003ig-AQ for submit@debbugs.gnu.org; Thu, 07 Nov 2024 03:45:21 -0500 Received: from 5.mo561.mail-out.ovh.net ([87.98.178.36]:43405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8y8i-0003iV-Tx for 74034@debbugs.gnu.org; Thu, 07 Nov 2024 03:45:20 -0500 Received: from director4.ghost.mail-out.ovh.net (unknown [10.108.17.1]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 4XkbHb2Qykz1TmM for <74034@debbugs.gnu.org>; Thu, 7 Nov 2024 08:45:14 +0000 (UTC) Received: from ghost-submission-5b5ff79f4f-r5jng (unknown [10.108.42.28]) by director4.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 41D001FEA3; Thu, 7 Nov 2024 08:45:14 +0000 (UTC) Received: from ngraves.fr ([37.59.142.106]) by ghost-submission-5b5ff79f4f-r5jng with ESMTPSA id /a0FMRl+LGfIAAAAzdMH4g (envelope-from ); Thu, 07 Nov 2024 08:45:14 +0000 X-OVh-ClientIp: 80.214.23.161 In-Reply-To: <87h68kujfs.fsf@gnu.org> References: <20241026222934.25890-1-ngraves@ngraves.fr> <20241027182029.25707-1-ngraves@ngraves.fr> <87h68kujfs.fsf@gnu.org> Date: Thu, 07 Nov 2024 09:45:06 +0100 Message-ID: <878qtvv3e5.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Ovh-Tracer-Id: 9086575199291433725 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeefuddrtdefgdduvdegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghffffkgggtgfesthhqredttddtjeenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeffudelkeejveetleeuffejfefftefhhfffuedtteethfelueelveffjedvffdtffenucfkphepuddvjedrtddrtddruddpkedtrddvudegrddvfedrudeiuddpfeejrdehledrudegvddruddtieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepjeegtdefgeesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheeiudgmpdhmohguvgepshhmthhpohhuth DKIM-Signature: a=rsa-sha256; bh=EgQd/p83od4R43EiI89X9joLQ1hrY5ue89oQZ0Tn98M=; c=relaxed/relaxed; d=ngraves.fr; h=From; s=ovhmo4487190-selector1; t=1730969115; v=1; b=gSdVIu13kBb4QkFay7itj0h/rqI0g6malP/Sp/HNsz96z3/f6ILA90sToIfh8awiIa38m2Xb NSkavDMvtAIvUOJLCSq4jCtTAB82YbzI6GXCdDtFCbnbJX1elzurVOpiOKPLrvElrHJP7yAA5YO tK1AmRTuUdgxbsCplCEmIA5HAsmH320L+ZlisueHXDzrpQrr/Pbm22ltc/r8fJTkQrzoAOBikQe rSfw+lM8icjuNG2rVxcN7MZxpDgecHqLlMc+hW/QtteNaHhCuzFC3/SaGGruFNte31p4h0y8Tns AGHb5hYQYAwG0KBgZI3gSgnz7xsWvxjbNDsUMLLfxNL+Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches From: Nicolas Graves via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 0.06 X-Spam-Score: 0.06 X-Migadu-Queue-Id: 13DDF47538 X-TUID: TfT0bAYa9gfj On 2024-11-06 22:43, Ludovic Court=C3=A8s wrote: > Hi, > > Nicolas Graves skribis: > >> * guix/cve.scm: Exploit cpe vendors information. >> (cpe->package-name): Rename to cpe->package and use >> cpe_vendor:cpe_name in place or cpe_name. >> (filter-vendors): Add helper function. >> (vulnerabilities->lookup-proc): Extract cpe_name for table >> hashes. Add vendor and hidden-vendor arguments. Adapt condition to >> pass vulnerabilities to result in the fold. >> >> * guix/lint.scm (package-vulnerabilities): Use additional arguments >> from vulnerabilities->lookup-proc. >> >> * tests/cve.scm: Adapt tests. > > Nice! > > Please mention the names of tests being change in the commit log (see > =E2=80=98git log=E2=80=99 for examples). > >> -(define (cpe->package-name cpe) >> +(define (cpe->package cpe) > > Or =E2=80=98cpe->package-identifier=E2=80=99? > > It=E2=80=99s unpleasant that said identifier is an unparsed =E2=80=9Cvend= or:package=E2=80=9D > string. I wonder if we should instead leave =E2=80=98%cpe-package-rx=E2= =80=99 unchanged > and return three values: package, version, vendor. > > The downside is that it would lead to more changes down the road because > we=E2=80=99d have to carry the vendor bit along. > > Thoughts? I actually took this route first, then reverted back to editing the regexp. This was indeed for simplicity (rationale: make a first working version with minimal changes, then if necessary improve). Yes indeed doing this makes a lot of changes in the code, although not complex. I agree with the rest of the changes. I'll try to make a commit on top of that, possibly this weekend. --=20 Best regards, Nicolas Graves