Re: Enhanced 'warning'

[Nikita Karetnikov <nikita@karetnikov.org>]

[-- Attachment #1: Type: text/plain, Size: 1446 bytes --]

> You should reuse the body of the current ‘warning’ macro, though.

What's wrong with this macro?

(define-syntax define-diagnostic
  (syntax-rules ()
    ((define-diagnostic name prefix)
     (define-syntax name
       (lambda (x)
         (define (augmented-format-string fmt)
           (string-append "~:[~*~;guix ~a: ~]~a" (syntax->datum fmt)))

         (syntax-case x (N_ _)                    ; these are literals, yeah...
           ((name (_ fmt) args ...)
            (string? (syntax->datum #'fmt))
            (with-syntax ((fmt*   (augmented-format-string #'fmt))
                          (prefix (datum->syntax x prefix)))
              #'(format (guix-warning-port) (gettext fmt*)
                        (program-name) (program-name) prefix
                        args ...)))
           ((name (N_ singular plural n) args ...)
            (and (string? (syntax->datum #'singular))
                 (string? (syntax->datum #'plural)))
            (with-syntax ((s      (augmented-format-string #'singular))
                          (p      (augmented-format-string #'plural))
                          (prefix (datum->syntax x prefix)))
              #'(format (guix-warning-port)
                        (ngettext s p n %gettext-domain)
                        (program-name) (program-name) prefix
                        args ...)))))))))

I'm getting the "extra ellipsis in form" error.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]