From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu:add SLiM Date: Fri, 22 Nov 2013 13:22:03 +0100 Message-ID: <877gc0eidw.fsf@gnu.org> References: <960e002e21b1fefc3acaaa0fcdedbaef.squirrel@fulvetta.riseup.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjpkQ-00084y-Qb for guix-devel@gnu.org; Fri, 22 Nov 2013 07:22:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjpkK-0004NM-KO for guix-devel@gnu.org; Fri, 22 Nov 2013 07:22:10 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:29628) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjpkK-0004M8-Dl for guix-devel@gnu.org; Fri, 22 Nov 2013 07:22:04 -0500 In-Reply-To: <960e002e21b1fefc3acaaa0fcdedbaef.squirrel@fulvetta.riseup.net> (Guy Ze Grant's message of "Thu, 21 Nov 2013 18:50:34 -0800") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Guy Ze Grant Cc: guix-devel@gnu.org "Guy Ze Grant" skribis: > Finally, I think I'm finished with SLiM; Thanks again Civodul and anyone > else who threw their hat in to offer advice. Attatched is the patch -- any > questions and/or critques of course are welcome. :^) Nice! > From ccb1526ab9be70a3157435edc677d926b2bb024e Mon Sep 17 00:00:00 2001 > From: Guy Grant > Date: Thu, 21 Nov 2013 20:36:08 -0600 > Subject: [PATCH] Add SLiM to packages > > --- > gnu/packages/slim.scm | 78 +++++++++++++++++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 78 insertions(+) > create mode 100644 gnu/packages/slim.scm In the final version, please make sure to include a GNU ChangeLog-style commit log. You may want to run =E2=80=98git config --global user.email gzg@riseup.net= =E2=80=99 also. > diff --git a/gnu/packages/slim.scm b/gnu/packages/slim.scm > new file mode 100644 > index 0000000..3cd4a1f > --- /dev/null > +++ b/gnu/packages/slim.scm > @@ -0,0 +1,78 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright \302\251 2013 Guy Grant This doesn=E2=80=99t seem to be UTF-8, is it? > +(define-public slim > + (package > + (name "slim") > + (version "1.3.3") ;; This it the latest on the SF page, the one on t= he website is 1.3.6 ... but the binary isn't static. What does =E2=80=9Cthe binary isn=E2=80=99t static=E2=80=9D mean? Also, please wrap lines at 80 chars. > + (arguments '(#:phases (alist-cons-before > + 'configure 'set-etc-and-lib-location > + (lambda _ (substitute* "CMakeLists.txt"=20 Skip a line after =E2=80=98_=E2=80=99, and... > + (("/etc") (string-append ... after ("etc"). (See the other files for example, and =E2=80=9CCoding Style=E2=80=9D in HAC= KING.) > + #:configure-flags '("-DUSE_PAM=3Dyes" "-DUSE_C= ONSOLEKIT=3Dno") > + #:tests? #f))=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20 Should be aligned with #:phases. > + (license l:gpl2))) Can you confirm that it=E2=80=99s GPLv2-only, and that all the files appear= to be under that license or a compatible one? With those details fixed, it=E2=80=99s ready for inclusion. Thanks! Ludo=E2=80=99.