From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: base: Added macro for choosing glibc for target
	system
Date: Tue, 22 Apr 2014 13:58:42 +0200
Message-ID: <877g6hwp71.fsf@gnu.org>
References: <CAFtzXzOOxuK+NEDWT4kmqZ1TpV+MB1-nn+VpNxqXQuKQwFJw4g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38549)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WcZLj-0006OK-En
	for Guix-devel@gnu.org; Tue, 22 Apr 2014 07:59:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WcZLZ-0001CI-4f
	for Guix-devel@gnu.org; Tue, 22 Apr 2014 07:58:55 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:38611)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1WcZLY-0001C4-Tn
	for Guix-devel@gnu.org; Tue, 22 Apr 2014 07:58:45 -0400
In-Reply-To: <CAFtzXzOOxuK+NEDWT4kmqZ1TpV+MB1-nn+VpNxqXQuKQwFJw4g@mail.gmail.com>
	(Manolis Ragkousis's message of "Mon, 21 Apr 2014 20:39:15 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel@gnu.org

Manolis Ragkousis <manolis837@gmail.com> skribis:

> I spent some time to find out why the glibc macro patch couldn't work
> and it seems it just had to be defined before other packages tried to
> inherit glibc in base.scm. It seems to work now.

Yes, indeed (sorry I didn=E2=80=99t catch it before!).

The patch looks good to me, but it doesn=E2=80=99t apply on =E2=80=98master=
=E2=80=99 since it
depends on bits that haven=E2=80=99t been committed yet.

I think we should start working on the integration of your work.  A good
candidate for a first patch would be the =E2=80=98glibc-hurd-headers=E2=80=
=99 package, I
think.

Minor details:

> From 1f35b5a3d93811dadac33dbce1ff74a704760a21 Mon Sep 17 00:00:00 2001
> From: phant0mas <manolis837@gmail.com>

Should be your real name (or not?)?

> Date: Mon, 21 Apr 2014 20:13:52 +0300
> Subject: [PATCH] gnu: base: Added macro for choosing glibc for target sys=
tem
>
> * gnu/packages/base.scm (glibc/linux): Renamed glibc to glibc/linux
> * gnu/packages/base.scm (glibc-for-target): Choose which glibc to use
> * gnu/packages/base.scm (glibc): Added macro to choose glibc

No need to repeat the file name here (see the GNU Coding Standards or
the log for details.)

> +(define (glibc-for-target target)
> +  "Return the glibc for TARGET, glibc/linux for a linux host or
> +glibc/hurd for a hurd host"

Spelling: =E2=80=9CLinux=E2=80=9D and =E2=80=9CHurd=E2=80=9D.

> +(define-syntax glibc
> +  (identifier-syntax (glibc-for-target (or (%current-target-system) (%cu=
rrent-system)))))

Insert a newline to remain below 80 columns.

Thanks!

Ludo=E2=80=99.