Re: [PATCH] gnu: base: Added macro for choosing glibc for target system

[ludo@gnu.org (Ludovic Courtès)]

Manolis Ragkousis <manolis837@gmail.com> skribis:

> I spent some time to find out why the glibc macro patch couldn't work
> and it seems it just had to be defined before other packages tried to
> inherit glibc in base.scm. It seems to work now.

Yes, indeed (sorry I didn’t catch it before!).

The patch looks good to me, but it doesn’t apply on ‘master’ since it
depends on bits that haven’t been committed yet.

I think we should start working on the integration of your work.  A good
candidate for a first patch would be the ‘glibc-hurd-headers’ package, I
think.

Minor details:

> From 1f35b5a3d93811dadac33dbce1ff74a704760a21 Mon Sep 17 00:00:00 2001
> From: phant0mas <manolis837@gmail.com>

Should be your real name (or not?)?

> Date: Mon, 21 Apr 2014 20:13:52 +0300
> Subject: [PATCH] gnu: base: Added macro for choosing glibc for target system
>
> * gnu/packages/base.scm (glibc/linux): Renamed glibc to glibc/linux
> * gnu/packages/base.scm (glibc-for-target): Choose which glibc to use
> * gnu/packages/base.scm (glibc): Added macro to choose glibc

No need to repeat the file name here (see the GNU Coding Standards or
the log for details.)

> +(define (glibc-for-target target)
> +  "Return the glibc for TARGET, glibc/linux for a linux host or
> +glibc/hurd for a hurd host"

Spelling: “Linux” and “Hurd”.

> +(define-syntax glibc
> +  (identifier-syntax (glibc-for-target (or (%current-target-system) (%current-system)))))

Insert a newline to remain below 80 columns.

Thanks!

Ludo’.