From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Fwd: [PATCH] gnu: hurd: Add Hurd Minimal. Date: Mon, 26 May 2014 11:22:18 +0200 Message-ID: <877g58rj1x.fsf@gnu.org> References: <87y4xq4vr2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wor6x-00006I-Tf for Guix-devel@gnu.org; Mon, 26 May 2014 05:22:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wor6s-0006jd-Bw for Guix-devel@gnu.org; Mon, 26 May 2014 05:22:27 -0400 Received: from hera.aquilenet.fr ([2a01:474::1]:41706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wor6r-0006jF-TY for Guix-devel@gnu.org; Mon, 26 May 2014 05:22:22 -0400 In-Reply-To: (Manolis Ragkousis's message of "Mon, 26 May 2014 08:24:54 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Manolis Ragkousis Cc: Guix-devel@gnu.org Manolis Ragkousis skribis: >>> + (arguments >>> + `(#:out-of-source? #t >>> + #:phases (alist-replace >>> + 'install >>> + (lambda* (#:key outputs #:allow-other-keys) >>> + (let ((out (assoc-ref outputs "out"))) >>> + ;; We need to copy libihash.a to the output folde= r manually, >>> + ;; since there is no target for that in the makef= ile >>> + (copy-recursively "libihash" >>> + (string-append out "/libihash")) >> >> This creates >> /gnu/store/.../libihash/{libihash.a,Makefile,ihash.c,ihash.o,...}. Is >> it really what=E2=80=99d intended? >> >> I would expect that the intent is to create >> /gnu/store/.../{lib/libihash.a,include/ihash.h}, no? >> > I will create two folders, lib with libihash.a and include with > ihash.h. What do you think? Yes, that=E2=80=99s what I=E2=80=99d expect. Double-check to make sure iha= sh.h doesn=E2=80=99t include any other file that=E2=80=99d need to be installed. (Please use =E2=80=9Cdirectory=E2=80=9D rather than =E2=80=9Cfolder=E2=80= =9D in comments & co.) >>> ++if test "x$cross_compiling" =3D "xyes"; then >>> ++ # It may be that we don't have a working libc yet, for instance >>> ++ # because we're bootstrapping the cross-compilation tool chain. >>> ++ # Thus, use this undocumented Autoconf macro designed for this. >>> ++ AC_NO_EXECUTABLES >>> ++ echo done >>> ++fi >> >> I gather that this works as advertised, but could you confirm by >> replying to >> ? >> That would allow us to push the patch upstream. >> > > I had to put one more line after AC_NO_EXECUTABLES, otherwise it would fa= il with >> syntax error near unexpected token `fi'. Oh I see, this macro actually expands to nothing. > Other than that it works. I will confirm there. Thanks. >>> +-# Check for Sun RPC headers and library. >>> ++# Check only for Sun RPC headers. We do not need the library yet. >>> + AC_CHECK_HEADER([rpc/types.h], [HAVE_SUN_RPC=3Dyes], [HAVE_SUN_RPC=3D= no]) >>> +-AC_SEARCH_LIBS([clnt_create], [], [:], [HAVE_SUN_RPC=3Dno]) >>> ++# AC_SEARCH_LIBS([clnt_create], [], [:], [HAVE_SUN_RPC=3Dno]) >>> + AC_SUBST([HAVE_SUN_RPC]) >> >> What=E2=80=99s the problem that=E2=80=99s addressed here? > > It tries to link with a library in glibc (which at that point doesn't > yet exist ), > but it cant because of the AC_NO_EXECUTABLES flag saying that linking > is not allowed after this flag is passed. So I am just disabling the test= , to > get the job done. OK, I see. Make sure to mention it in the patch comment as well. Ludo=E2=80=99.