all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] import: Add PyPI importer.
Date: Mon, 29 Sep 2014 14:24:57 +0200	[thread overview]
Message-ID: <877g0mzk9y.fsf@gnu.org> (raw)
In-Reply-To: <87fvfazn4z.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> (David Thompson's message of "Mon, 29 Sep 2014 07:23:08 -0400")

David Thompson <dthompson2@worcester.edu> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> David Thompson <dthompson2@worcester.edu> skribis:
>>
>>> I should mention that the PyPI import requires the guile-json library.
>>> How should this be handled in our build scripts? 
>>
>> I think it’s fine to install it whether or not guile-json is available.
>> Now, when there are tests ;-), there’ll have to be an Automake
>> conditional to decide whether or not to run those tests that require
>> guile-json.
>
> Oh yeah, almost forgot about the Automake rule!  My autotools skills are
> weak so I'm not sure how to write this.  Could you point me in the right
> direction?

In configure.ac, do something like:

  GUILE_MODULE_AVAILABLE([have_guile_json], [(json)])
  AM_CONDITIONAL([HAVE_GUILE_JSON], [text "x$have_guile_json" = "xyes"])

and in Makefile.am:

  if HAVE_GUILE_JSON
  TESTS += tests/pypi.scm
  endif

Ludo’.

  reply	other threads:[~2014-09-29 12:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-27 21:15 [PATCH] import: Add PyPI importer David Thompson
2014-09-27 21:19 ` David Thompson
2014-09-27 21:35   ` Ludovic Courtès
2014-09-29 11:23     ` David Thompson
2014-09-29 12:24       ` Ludovic Courtès [this message]
2014-09-29 23:31         ` David Thompson
2014-09-30  5:49           ` Alex Kost
2014-09-30  7:13             ` Ludovic Courtès
2014-09-30 11:55             ` David Thompson
2014-09-27 21:49 ` Ludovic Courtès
2014-09-28 23:48   ` David Thompson
2014-09-29  7:04     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877g0mzk9y.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=dthompson2@worcester.edu \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.