From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH 11/15] gnu: Add xfce4-settings.
Date: Thu, 11 Dec 2014 21:37:14 -0500
Message-ID: <877fxx1tlx.fsf@netris.org>
References: <1418212956-1698-1-git-send-email-iyzsong@gmail.com>
	<1418212956-1698-11-git-send-email-iyzsong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47160)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1XzG6N-00024G-IZ
	for guix-devel@gnu.org; Thu, 11 Dec 2014 21:37:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1XzG6D-0004SU-5A
	for guix-devel@gnu.org; Thu, 11 Dec 2014 21:37:07 -0500
Received: from world.peace.net ([50.252.239.5]:34619)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1XzG6D-0004SI-0v
	for guix-devel@gnu.org; Thu, 11 Dec 2014 21:36:57 -0500
In-Reply-To: <1418212956-1698-11-git-send-email-iyzsong@gmail.com>
	(=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Wed, 10 Dec 2014 20:02:32 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (xfce4-settings): New variable.
> ---
>  gnu/packages/xfce.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 5f15594..c601852 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -310,3 +310,33 @@ your system in categories, so you can quickly find a=
nd launch them.")
>       "Session manager for Xfce, it will restores your session on startup=
 and
>  allows you to shutdown the computer from Xfce.")
>      (license gpl2+)))
> +
> +(define-public xfce4-sesttings

The variable name above has a typo:
  'xfce4-sesttings' ->
  'xfce4-settings'.

> +  (package
> +    (name "xfce4-settings")
> +    (version "4.10.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://archive.xfce.org/xfce/4.10/src=
/"
> +                                  name "-" version ".tar.bz2"))

Instead of putting "4.10" directly in the string above, how about this:

    (uri (string-append "http://archive.xfce.org/xfce/"
                        (version-major+minor version)
                        "/src/" name "-" version ".tar.bz2"))

This way, when the package is updated to a new version, there will be
one less thing to change.  The same change could be made to many of your
other xfce packages.

'version-major+minor' is in the (guix utils) module, so you'll need to
add that to the import list.

Thanks for working on this!

      Mark