From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add ninja.
Date: Sat, 10 Jan 2015 14:46:54 +0100
Message-ID: <877fwukasx.fsf@gnu.org>
References: <1420810817-23613-1-git-send-email-iyzsong@gmail.com>
	<87fvbk3tvy.fsf@gnu.org> <87387i99n2.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50474)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y9wNY-0001Am-0W
	for guix-devel@gnu.org; Sat, 10 Jan 2015 08:47:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y9wNU-0006cy-QV
	for guix-devel@gnu.org; Sat, 10 Jan 2015 08:46:59 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:35074)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Y9wNU-0006cX-K6
	for guix-devel@gnu.org; Sat, 10 Jan 2015 08:46:56 -0500
In-Reply-To: <87387i99n2.fsf@gmail.com> (=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Sat, 10 Jan 2015 19:07:29 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:
>>
>>> * gnu/packages/ninja.scm: New file.
>>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>>
>> [...]
>>
>>> +          'check
>>> +          (lambda _
>>> +            (and (zero? (system "./configure.py"))
>>> +                 (zero? (system "./ninja ninja_test"))
>>> +                 ;; SubprocessTest.InterruptChild fail when using 'sys=
tem*'.
>>> +                 ;; SubprocessTest.SetWithLots was skipped.
>>> +                 ;; XXX: Raise [ulimit -n] well above 1025 to make thi=
s test go.
>>
>> Does it mean that the test is currently failing?
> Yes, SetWithLots fail with the 'Raise ...' line.

Oh, I see.  Then can you make it clearer in the comment:

  ;; SubprocessTest.SetWithLots fails with:
  ;;
  ;;   Raise [ulimit -n] well above 1025 to make this test go.
  ;;
  ;; Skip it.

>>> +                 (zero? (system (string-append
>>> +                                 "./ninja_test "
>>> +                                 "--gtest_filter=3D"
>>> +                                 "-SubprocessTest.SetWithLots")))))
>>
>> Please use =E2=80=98system*=E2=80=99 (with separate arguments) rather th=
an =E2=80=98system=E2=80=99.
>> The latter runs =E2=80=9C/bin/sh -c ...=E2=80=9D whereas the former runs=
 the program
>> directly.
> Use 'system*' to run "./ninja_test" will cause InterruptChild to fail :(
> (as I mentioned in the comment)

Ah right, that=E2=80=99s weird, but could you mention in the comment (1) ho=
w it
fails, and (2) that because of this, we use =E2=80=98system=E2=80=99 instea=
d of
=E2=80=98system*=E2=80=99?

It=E2=80=99s important to explain both the problem and the solution/consequ=
ence,
otherwise it can be hard by reading the comment to understand if we=E2=80=
=99re
talking about an unfixed issue, a fixed issue, or a fix.

OK to push with these changes.

Thanks,
Ludo=E2=80=99.