From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Thompson <dthompson2@worcester.edu>
Subject: Re: [PATCH 03/15] gnu: xfconf: Update to 4.12.0.
Date: Sun, 01 Mar 2015 07:49:11 -0500
Message-ID: <877fv07uig.fsf@fsf.org>
References: <1425189446-6455-1-git-send-email-iyzsong@gmail.com>
	<1425189446-6455-3-git-send-email-iyzsong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40374)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1YS3JA-00028D-PU
	for guix-devel@gnu.org; Sun, 01 Mar 2015 07:49:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1YS3J9-0005K2-NE
	for guix-devel@gnu.org; Sun, 01 Mar 2015 07:49:20 -0500
Received: from mail.fsf.org ([208.118.235.13]:55837)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1YS3J9-0005Jy-Ji
	for guix-devel@gnu.org; Sun, 01 Mar 2015 07:49:19 -0500
In-Reply-To: <1425189446-6455-3-git-send-email-iyzsong@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>, guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (xfconf): Update to 4.12.0.
>   [arguments]: Add #:phases.  Remove #:parallel-tests? argument.
> ---
>  gnu/packages/xfce.scm | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 3679eb0..0e45ee4 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -89,7 +89,7 @@ Xfce Desktop Environment.")
>  (define-public xfconf
>    (package
>      (name "xfconf")
> -    (version "4.10.0")
> +    (version "4.12.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://archive.xfce.org/xfce/"
> @@ -97,9 +97,20 @@ Xfce Desktop Environment.")
>                                    "/src/" name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "0xh520z0qh0ib0ijgnyrgii9h5d4pc53n6mx1chhyzfc86j1jlhp"))=
))
> +                "0mmi0g30aln3x98y5p507g17pipq0dj0bwypshan8cq5hkmfl44r"))=
))
>      (build-system gnu-build-system)
> -    (arguments '(#:parallel-tests? #f)) ; parallel tests failed
> +    (arguments
> +     '(#:phases
> +       ;; Swap check and install phases.
> +       (alist-cons-after
> +        'install 'check
> +        (lambda _
> +          (setenv "HOME" (getenv "TMPDIR")) ; xfconfd requires a writabl=
e HOME
> +          ;; Run test-suite under a dbus session.
> +          (setenv "XDG_DATA_DIRS" ; for finding org.xfce.Xfconf.service
> +                  (string-append %output "/share"))
> +          (zero? (system* "dbus-launch" "make" "check")))
> +        (alist-delete 'check %standard-phases))))

So, tests need to be run *after* installation?  Weird...

>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("intltool" ,intltool)))
> --=20
> 2.1.2
>
>

LGTM!

--=20
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate