From: 宋文武 <iyzsong@gmail.com>
To: guix-devel@gnu.org
Subject: Re: [PATCH] profiles: Add 'hicolor' and 'HighContrast' icon theme hooks.
Date: Sat, 09 May 2015 13:11:03 +0800 [thread overview]
Message-ID: <877fsixrmg.fsf@gmail.com> (raw)
In-Reply-To: <1431147336-4274-1-git-send-email-iyzsong@gmail.com>
This is WIP.
> * guix/profiles.scm (gtk-icon-theme-hook): New function.
> (%default-profile-hooks): Add `(gtk-icon-theme-hook "hicolor")' and
> `(gtk-icon-theme-hook "HighContrast")'.
> ---
> guix/profiles.scm | 36 +++++++++++++++++++++++++++++++++++-
> 1 file changed, 35 insertions(+), 1 deletion(-)
>
> diff --git a/guix/profiles.scm b/guix/profiles.scm
> index 11d9bf0..9756685 100644
> --- a/guix/profiles.scm
> +++ b/guix/profiles.scm
> @@ -573,12 +573,46 @@ MANIFEST. Single-file bundles are required by programs such as Git and Lynx."
> #:modules '((guix build utils))
> #:local-build? #t))
>
> +(define (gtk-icon-theme-hook name)
> + "Return a profile hook that unions all NAME icons from manifest entries and
> +rebuilds the 'icon-theme.cache' file for the NAME icon theme."
> + (define gtk+
> + (module-ref (resolve-interface '(gnu packages gtk)) 'gtk+))
> +
> + (lambda (manifest)
> + (define build
> + #~(begin
> + (use-modules (guix build utils)
> + (guix build union))
> + (let* ((icon-dir (lambda (base)
> + (string-append base "/share/icons/" #$name)))
> + (destdir (icon-dir #$output))
> + (icons (filter
> + file-exists?
> + (map icon-dir '#$(manifest-inputs manifest))))
> + (update-icon-cache (string-append
> + #+gtk+ "/bin/gtk-update-icon-cache")))
> + ;; mkdir -p $out/share/icons
> + (mkdir-p destdir)
> + (rmdir destdir)
> + ;; Unions all the icons and update the 'icon-theme.cache'.
> + (union-build destdir icons)
> + (system* update-icon-cache "-t" destdir))))
> +
> + (gexp->derivation (string-append (string-downcase name) "-icon-theme")
> + build
> + #:modules '((guix build utils)
> + (guix build union))
> + #:local-build? #t)))
When to exclude this derivation?
1. the best would be whether icon dir exists or not
but is this posibble to implement? and how?
2. whether we have a gtk+ package in profile
And any better way?
> +
> (define %default-profile-hooks
> ;; This is the list of derivation-returning procedures that are called by
> ;; default when making a non-empty profile.
> (list info-dir-file
> ghc-package-cache-file
> - ca-certificate-bundle))
> + ca-certificate-bundle
> + (gtk-icon-theme-hook "hicolor")
> + (gtk-icon-theme-hook "HighContrast")))
Does these 2 enough? I think in practical, it does.
Or (better) as Federico Beffa said in:
http://lists.gnu.org/archive/html/guix-devel/2015-01/msg00108.html
We should rebuilds all the icon themes?
If so, I think the code will be more complex...
>
> (define* (profile-derivation manifest
> #:key
> --
> 2.2.1
next prev parent reply other threads:[~2015-05-09 5:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 4:55 [PATCH] profiles: Add 'hicolor' and 'HighContrast' icon theme hooks 宋文武
2015-05-09 5:11 ` 宋文武 [this message]
2015-05-09 14:10 ` Ludovic Courtès
2015-05-10 4:55 ` 宋文武
2015-05-10 19:57 ` Ludovic Courtès
2015-05-11 7:55 ` 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fsixrmg.fsf@gmail.com \
--to=iyzsong@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.