From: Mark H Weaver <mhw@netris.org>
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel <Guix-devel@gnu.org>
Subject: Re: [PATCH] daemon: Check for HAVE_CHROOT instead of CHROOT_ENABLED.
Date: Mon, 10 Aug 2015 20:04:57 -0400 [thread overview]
Message-ID: <877fp2pu52.fsf@netris.org> (raw)
In-Reply-To: <CAFtzXzPS96w1F1T4mKdHRE2tL-m5b9pab7CLLMccAiBW1iNXEA@mail.gmail.com> (Manolis Ragkousis's message of "Mon, 10 Aug 2015 21:15:10 +0300")
Manolis Ragkousis <manolis837@gmail.com> writes:
> There is an issue with the chrooted builds on Hurd. In
> nix/libstore/build.cc CHROOT_ENABLED
> is false because HAVE_UNSHARE && HAVE_SYS_MOUNT_H are not defined on Hurd.
>
> The part that we are interested from build.cc is at line 1768. The
> part of the code in that if, is used by the daemon for chrooted
> builds. At this specific part of the daemon we only need
> HAVE_CHROOT to be defined, which is true on hurd, for the builds to
> work. With this workaround,
> things seem to work for me until now. WDYT?
This won't be sufficient, because if you set up a chroot, you'll also
need to do some of the things within the "#if CHROOT_ENABLED" starting
on line 1997, such as setting up local instances of /dev and /etc.
Here's what I'd suggest: instead of using HAVE_CHROOT on line 1768,
instead split CHROOT_ENABLED into two separate flags: CHROOT_ENABLED and
maybe CONTAINER_ENABLED. All existing occurrences of CHROOT_ENABLED
would initially be replaced with CONTAINER_ENABLED. Then, define
CHROOT_ENABLED (now a newly defined name) to depend on a smaller set of
requirements, maybe just HAVE_CHROOT && HAVE_SYS_MOUNT_H.
We should assume that CHROOT_ENABLED is a requirement for
CONTAINER_ENABLED (which should ideally be made explicit in the code by
adding CHROOT_ENABLED to the right-hand-side expression for
CONTAINER_ENABLED), so there are only three cases to consider:
1. CONTAINER_ENABLED and CHROOT_ENABLED are both true.
2. CONTAINER_ENABLED is false and CHROOT_ENABLED is true.
3. CONTAINER_ENABLED and CHROOT_ENABLED are both false.
We should ensure that the code works properly in all three cases.
So, look at the code within "#if CONTAINER_ENABLED" and decide which
parts should still be run if CONTAINER_ENABLED is false but
CHROOT_ENABLED is true.
What do you think?
Mark
next prev parent reply other threads:[~2015-08-11 0:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 18:15 [PATCH] daemon: Check for HAVE_CHROOT instead of CHROOT_ENABLED Manolis Ragkousis
2015-08-11 0:04 ` Mark H Weaver [this message]
2015-08-18 16:48 ` Ludovic Courtès
2015-08-19 10:10 ` Manolis Ragkousis
2015-08-19 12:22 ` Manolis Ragkousis
2015-08-28 9:34 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fp2pu52.fsf@netris.org \
--to=mhw@netris.org \
--cc=Guix-devel@gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.