Re: [PATCH] gnu: magit: Update to 2.2.1.

[ludo@gnu.org (Ludovic Courtès)]

Alex Kost <alezost@gmail.com> skribis:

> Magit 2.2.0 is not actual anymore, so here is the updated patch.  I have
> a question however: I've noticed that there are 2 tarballs available:
>
> - <https://github.com/magit/magit/releases/download/2.2.1/magit-2.2.1.tar.gz>
>
>   This one does not include tests, but it has "magit-version.el" file so
>   there is no need to specify "VERSION" flag (see
>   <http://lists.gnu.org/archive/html/guix-devel/2015-08/msg00487.html>).
>
> - <https://github.com/magit/magit/archive/2.2.1.tar.gz>
>
>   This is a "raw" snapshot of the repo, so there are tests, but
>   "VERSION" flag should be specified.
>
> So what tarball should we use?  I think it's better to take the second
> one (with tests).

Yes, makes sense.

> From ae74c836d38f3fb60ba0682c0b5010b81f6793c9 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Mon, 17 Aug 2015 21:44:40 +0300
> Subject: [PATCH] gnu: magit: Update to 2.2.1.
>
> * gnu/packages/emacs.scm (magit): Update to 2.2.1.
>   [inputs]: Remove 'git:gui'.
>   [propagated-inputs]: Add 'dash', remove 'git-modes'.
>   [arguments]: Add PREFIX and DASH_DIR to 'make-flags'.  Remove
>   'configure', 'augment-load-path' and 'post-install' phases.

LGTM.

You should merge it with the magit-svn update at
<https://lists.gnu.org/archive/html/guix-devel/2015-08/msg00383.html> so
we keep a working tool set.

OK to push this combo!

Thanks,
Ludo’.