Re: [PATCH] Add gerbv.

[Ricardo Wurmus <rekado@elephly.net>]

Ludovic Courtès <ludo@gnu.org> writes:

>> * gnu/packages/gettext.scm (po4a): New variable.
>
> [...]
>
>> +               (string-append "--nonet "
>> +                              (assoc-ref inputs "docbook-xsl")
>> +                              ;; TODO: replace version string
>> +                              "/xml/xsl/docbook-xsl-"  "1.78.1"
>> +                              "/manpages/docbook.xsl")))
>
> ... can this be avoided altogether by adding libxml2 as an input (which
> sets $XML_CATALOG_FILES as a side-effect)?

Oh, I did not know this.  Yes, with libxml2 as an input this hackery is
not needed.  Thanks!

>> * gnu/packages/engineering.scm (gerbv): New variable.
>
> [...]
>
>> +            ;; Build rules contain references to Russian translation, but the
>> +            ;; needed files are missing; see
>> +            ;; http://sourceforge.net/p/gerbv/bugs/174/
>> +            (delete-file "po/LINGUAS")
>> +            (substitute* "man/Makefile.am"
>> +              (("PO_FILES= gerbv.ru.1.in.po") "")
>> +              (("man_MANS = gerbv.1 gerbv.ru.1") "man_MANS = gerbv.1"))
>> +            (zero? (system* "autoreconf" "-vfi")))))))
>
> Could you modify Makefile.in instead?  That would hopefully allow us to
> remove the dependency on the autotools.

Unfortunately, the tarball comes without the ‘configure’ script, so we
need to use autotools to generate it.

>> +     "Gerbv is a Gerber file (RS-274X only) viewer.  Gerbv lets you load
>
> What about giving a bit more context, along the lines of:
>
>   Gerbv is a viewer for files in the Gerber format (RS-274X only), which
>   is commonly used to represent printed circuit board (PCB) layouts.

Okay.  I’ll push with these changes.  Thanks for the review!

~~ Ricardo