From: Mathieu Lirzin <mthl@openmailbox.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add python-xlrd.
Date: Sat, 19 Sep 2015 22:37:16 +0200 [thread overview]
Message-ID: <877fnmno1v.fsf@openmailbox.org> (raw)
In-Reply-To: <87si6a5fzf.fsf@mdc-berlin.de> (Ricardo Wurmus's message of "Sat, 19 Sep 2015 22:08:52 +0200")
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
> Mathieu Lirzin <mthl@openmailbox.org> writes:
>
>>> + ;; so use nose to run tests instead for now.
>>> + (replace 'check (lambda _ (zero? (system* "nosetests")))))))
>>> + (native-inputs
>>> + `(("python-setuptools" ,python2-setuptools)
>>> + ("python-nose" ,python2-nose)))
>>
>> I don't know python packaging but when I look at other packages it
>> seems that these are usually used as “inputs” not
>> “native-inputs”.
>
> Nose is used for the tests only and setuptools is used at build time, so
> I think it’s fine like this.
Is this a general statement or something specific to this package? If
this is general it seems to be a good idea to make a big commit that
fixes all the python packages which use these dependencies as normal
inputs? WDYT?
--
Mathieu Lirzin
next prev parent reply other threads:[~2015-09-19 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-19 13:38 [PATCH] gnu: Add python-xlrd Ben Woodcroft
2015-09-19 15:49 ` Mathieu Lirzin
2015-09-19 15:53 ` Andreas Enge
2015-09-19 20:08 ` Ricardo Wurmus
2015-09-19 20:37 ` Mathieu Lirzin [this message]
2015-09-20 0:48 ` Ben Woodcroft
2015-09-27 20:10 ` Ludovic Courtès
2015-10-01 21:48 ` Mathieu Lirzin
2015-09-20 7:41 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fnmno1v.fsf@openmailbox.org \
--to=mthl@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.