From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: 01/01: gnu: Add pbzip2. Date: Thu, 22 Oct 2015 11:17:11 -0400 Message-ID: <877fmfj5l4.fsf@netris.org> References: <20151022142819.17853.79652@vcs.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpHcV-0002qO-Qc for guix-devel@gnu.org; Thu, 22 Oct 2015 11:17:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpHcS-0002QU-GA for guix-devel@gnu.org; Thu, 22 Oct 2015 11:17:35 -0400 Received: from world.peace.net ([50.252.239.5]:49203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpHcS-0002QC-CN for guix-devel@gnu.org; Thu, 22 Oct 2015 11:17:32 -0400 In-Reply-To: (Efraim Flashner's message of "Thu, 22 Oct 2015 14:28:26 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Efraim Flashner Cc: guix-devel@gnu.org Efraim Flashner writes: > efraim pushed a commit to branch master > in repository guix. > > commit 5d47eab0242d6f89a6837123141acdae68745328 > Author: Efraim Flashner > Date: Thu Oct 22 13:12:07 2015 +0300 > > gnu: Add pbzip2. >=20=20=20=20=20 > * gnu/packages/compression.scm (pbzip2): New variable. Thanks for this, but did you post it to guix-devel for review? It would be good to do so in the future. Please see below for comments. > --- > gnu/packages/compression.scm | 33 +++++++++++++++++++++++++++++++++ > 1 files changed, 33 insertions(+), 0 deletions(-) > > diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm > index 941844b..0bb3919 100644 > --- a/gnu/packages/compression.scm > +++ b/gnu/packages/compression.scm > @@ -7,6 +7,7 @@ > ;;; Copyright =C2=A9 2015 Ricardo Wurmus > ;;; Copyright =C2=A9 2015 Leo Famulari > ;;; Copyright =C2=A9 2015 Jeff Mickey > +;;; Copyright =C2=A9 2015 Efraim Flashner > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -225,6 +226,38 @@ decompression.") > "See LICENSE in the distribution.")) > (home-page "http://www.bzip.org/")))) >=20=20 > +(define-public pbzip2 > + (package > + (name "pbzip2") > + (version "1.1.12") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://launchpad.net/pbzip2/1.1/" ver= sion > + "/+download/" name "-" version ".tar.gz"= )) The quote (") on the line above should be aligned with the quote on the line above it. Also, instead of hard coding "1.1" in the URI, please use 'version-major+minor' instead. You'll find many examples of it in gnu/packages/*.scm > + (sha256 > + (base32 > + "1vk6065dv3a47p86vmp8hv3n1ygd9hraz0gq89gvzlx7lmcb6fsp")))) > + (build-system gnu-build-system) > + (inputs > + `(("bzip2", bzip2))) > + (arguments > + `(#:tests? #f ; no tests > + #:phases (modify-phases %standard-phases > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) > + (substitute* "Makefile" > + (("/usr") (assoc-ref outputs "out"))) > + #t))))) The alignment of the lines above is very confusing, to say the least. Anyway, it would be better to simply remove the 'configure' phase and instead add this: #:make-flags (list (string-append "PREFIX=3D" %output)) > + (home-page "http://compression.ca/pbzip2/") > + (synopsis "Parallel bzip2 implementation") > + (description > + "Pbzip2 is a parallel implementation of the bzip2 block-sorting file > +compressor that uses pthreads and achieves near-linear speedup on SMP ma= chines. > +The output of this version is fully compatible with bzip2 v1.0.2 (ie: an= ything > +compressed with pbzip2 can be decompressed with bzip2).") s/ie:/i.e./ > + (license (license:non-copyleft "file://COPYING" > + "See COPYING in the distribution.")))) Please align the open quotes. Thanks, Mark