From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Lirzin Subject: Re: [PATCH 0/4] Build man pages in $(srcdir). Date: Sat, 19 Mar 2016 23:50:07 +0100 Message-ID: <877fgyjd5s.fsf@gnu.org> References: <1458404286-10448-1-git-send-email-mthl@gnu.org> <87mvpudufm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahPhM-00032b-Ow for guix-devel@gnu.org; Sat, 19 Mar 2016 18:50:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahPhL-0005An-Nh for guix-devel@gnu.org; Sat, 19 Mar 2016 18:50:20 -0400 In-Reply-To: <87mvpudufm.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 19 Mar 2016 22:33:33 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Mathieu Lirzin skribis: > >> Anyway, inspired by what is done by Automake for info manuals I have tri= ed to >> build man pages in $(srcdir), which is fixing the issue too. The bonus = is >> that now all the documentation is consistently built in $(srcdir) and th= at we >> avoid adding another "case $? ..." trick. > > This sounds reasonable (in fact I wonder why we were not doing it > already given that things are supposed to live in $(srcdir)). Why were you expecting such thing? > Did you confirm that =E2=80=98make distcheck=E2=80=99 passes after that, = and that > =E2=80=98help2man=E2=80=99 is not invoked when building from a tarball? I can't confirm for =E2=80=98make distcheck=E2=80=99 right now, because of: --8<---------------cut here---------------start------------->8--- substitute: updating list of substitutes from 'http://hydra.gnu.org'... 33= .3% 4 packages are not substitutable: /gnu/store/5apc4w376ls7fhydg08plc20agry7pn4-emacs-24.5 /gnu/store/zfxj52lh6h6q7jmb1w2s34h004zsbaw3-emacs-24.5 /gnu/store/10qcwd0gxypm977ksbvhjrpa4m1xk334-emacs-24.5 /gnu/store/r8xphs9ka0lwmwhzxv6mfs9j8nm91843-emacs-24.5 Makefile:4913=C2=A0: la recette pour la cible =C2=AB=C2=A0assert-binaries-a= vailable=C2=A0=C2=BB a =C3=A9chou=C3=A9e --8<---------------cut here---------------end--------------->8--- However I have manually checked that with 'make dist' + (regular build or VPATH build) 'help2man' is not invoked. > Also, do these changes preserve the benefits of > 36629097523b0abd89d1b931293150cb9c1f242d (=E2=80=9Cbuild: Generate man pa= ges > after compiling Guile objects.=E2=80=9D)? Yes it is. That would be unacceptable if not. ;) --=20 Mathieu Lirzin